outsideopen / oo-bin-py Goto Github PK

We grep for the Bash version number here: https://github.com/outsideopen/oo-bin-py/blob/main/install.sh#L69

On Mac the output also contains a build number, and this breaks the install script.

We should only return the first matched version number

We can use Github's pre-release feature, to create a release that can be installed by QA users for testing, before general release.

We should update the install script to handle this

This should not be too difficult for vnc and rdp. We only need to come up with some structure for choosing ports.

For socks5 this is a bit more involved, because we need to set the port in the Firefox profile. (This should be doable, see comment)

We want to have the tunnels config remotely updated for OO employees, but we should also allow for a local set of config to amend this.

• Install Python with homebrew
• Fix Firefox path for firefox installed without homebrew

Change from socks5 to socks

The usage text is erroneously displayed when issuing oo tunnels rdp stop

arusch@oo-w10-04:~$ oo tunnels rdp stop
Usage: oo tunnels [OPTIONS] [PROFILE] COMMAND [ARGS]...

  Manage tunnels

Options:
  -S, --stop    Stop all running socks5 tunnels
  -s, --status  Socks5 tunnels status
  -u, --update  Update tunnels configuration from remote
  --help        Show this message and exit.

Commands:
  rdp  Manage rdp tunnels
  vnc  Manage vnc tunnels
Stopping tunnel to rind

Currently we update weekly, but @zinkwazi asked that we update daily.

• Add type support in tunnels.conf

type = "rdp" # socks5|rdp|vnc with socks5 being the default

• Add rdp|vnc subcommands

oo tunnels host # default, uses socks5
oo tunnels rdp host
oo tunnels vnc host

• Update tunnels script to support the new subcommands

Just a fun distraction from more serious stuff

Right now, we throw a FileNotFoundError, we should rather return an empty configuration

The way we ps and grep will not detect a command, unless it was started with the full path
i.e autossh vs /usr/bin/autossh

This can cause confusing behaviour, if a tunnel is started outside the oo script

This will use the tunnels config, but ssh to the jump_host instead of opening the tunnel

• Create PID files based on jumphost name
• Update the code that tests if the process in a PID file is still running
• Update status command to show all running profiles
• Update the stop command to be more fine grained. Stop specific instances, stop all instances

This will allow more robust configuration of hosts, and enable the supporting of rdp tunnels and ssh tunnels in the same script

Use process id file, instead of grepping for processes.

This will simplify the logic when adding rdp and vnc tunnels

The big reason for this, is because Click supports sub commands, where argomplete does not.

It appears we are going to have subcommands

oo tunnels [name] [url] should open specific host

Also
oo tunnels rdp [url] and oo tunnels vnc [url]

Bug introduced when changing to toml config

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

We get a FileNotFoundError when backing up the tunnels_config when the source file does not exist

• Add global config
• Add configuration for downloading the tunnels config from remote location
• Update the install script to create the global config
• Code to download tunnels config and copy it in place

autossh fails but tunnels don't wait long enough to detect this. Experiment with increasing the timeout