outmoded / bananas Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 5.0 31 KB

Minimal Loggly hapi plugin

License: Other

JavaScript 100.00%

bananas's People

Contributors

Stargazers

Watchers

Forkers

kpdecker zoraio iamdoron sffej framerate

bananas's Issues

Option to force plugin to apply to root server

In some cases, you want to load the plugin before creating connections for server.log() access but then any connection added after will be missed. This adds the root option which will listen on the server.root instead of the selected connections and will apply to the entire server.

Update deps

Static tag config

hapi v17

Error data is not logged

 {
  "event": "server",
  "timestamp": 1462048183528,
  "host": "02f8a84b728b",
  "tags": [
    "internal",
    "implementation",
    "error"
  ],
  "data": {
    "domain": {
      "_events": {},
      "_eventsCount": 1,
      "members": []
    },
    "domainThrown": true
  }
}

JSON.stringify does not serialize the important fields of Error instances. Doing something like this in my application-layer logging:

  if (info instanceof Error) {
    info = {...info, message: info.message, stack: info.stack};
  }

Include payload in any error response

Log request auth

Log startup

Logs fail completely when circular object is passed in

https://github.com/hueniverse/bananas/blob/master/lib/index.js#L40

.../bananas/lib/index.js:40
        const payload = holder.map(JSON.stringify).join('\n');
                               ^

TypeError: Converting circular structure to JSON
    at stringify (native)
    at Array.map (native)
    at [object Object].flush [as _repeat] (.../bananas/lib/index.js:40:32)
    at [object Object].wrapper [as _onTimeout] (timers.js:275:19)
    at Timer.listOnTimeout (timers.js:92:15)

Which blocks any sort of error data from being sent to loggly. Ideally some sort of tracking data for this would be logged with an additional error noting that the logging is failing.