ottosmops / hash Goto Github PK
View Code? Open in Web Editor NEWcreate and verify hash files
License: MIT License
hash's People
Stargazers
Watchers
Forkers
open-source-contributionshash's Issues
Consider fix test method name via PSR-2 coding style
As title, when using the composer check-style for PHP classes on `tests folder, it will present following errors:
.......
FILE: /data/hash/tests/Md5sumTest.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
--------------------------------------------------------------------------------
25 | ERROR | Method name "HashTest::it_can_validate_a_validate_manifest" is
| | not in camel caps format
33 | ERROR | Method name
| | "HashTest::it_can_validate_a_validate_sh1_manifest" is not in
| | camel caps format
43 | ERROR | Method name
| | "HashTest::it_can_validate_a_validate_manifest_binary" is not
| | in camel caps format
.......
IMHO, we should consider changing into method name to follow camel-case style.
For example, it can change into: itCanCreateManifestFlat or testCanCreateManifestFlat and remove /** @test */ comment annotation.
@ottosmops, do you have any idea about this?
Once this issue is accepted, I think I can work on this :).
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.