osmlab / osm-deep-history Goto Github PK

View Code? Open in Web Editor NEW

30.0 7.0 18.0 792 KB

A simple page to show the history of OSM objects.

Home Page: http://osmlab.github.io/osm-deep-history/

CSS 9.09% HTML 10.48% JavaScript 80.43%

osm-deep-history's Introduction

OSM Deep History

A better way to view the history of objects in OpenStreetMap.

Example history views:

Node
Way (The map needs a few seconds to load)

It's an enhancement base on osmlab/osm-deep-history with below update:

Common:

Improve map UI and fix issues
When mouse hover on table cell, highlight corresponding version of object on map and pan to center
In table, show version which is invisible in red (removed)
Base map layer: OpenStreetMap and Mapbox Satellite Streets
Export full data of specific version in Level0L format

Node:

Show lat, lon in table
Show way(s) which the node belongs to

Way:

Show history versions of way on map

Development

The source code has been rewritten mostly in ES6, using Promise and functional style.

To rebuild and run locally:

npm install
npm run build
npm start

osm-deep-history's People

Contributors

Stargazers

Watchers

Forkers

andrewharvey neogeomat pnorman flaviofalcao tilmanb tomhughes sukhjitsehra gileri aleung tordans altilunium someoneelseosm seanpm2001 bezdna deevroman

osm-deep-history's Issues

Keep left-most column stationary while allowing the version to scroll

Similar to Excel's frozen pane.

Always use HTTPS to communicate with OSM

Example query http://osmlab.github.io/osm-deep-history/#/way/442577309 .

Guessing here (given that the issue has hit a couple of other things this morning) - maybe this is related to the recent change of the OSM API to redirect from http to https?

Hint about Show More

Maybe it's just me, but even when on OSM Deep History, it wasn't immediately obvious that I could get visual history of a way (as I was looking for) and if it was possible that I could do it by clicking show more.

I wonder if some sort of basic tutorial guide, or a little hint for new users under the NWR and id boxes saying some text.

Or making the show more button text longer/more descriptive as to what it will show. For a node with more history will it also fetch further versions?

Vertical scroll bar hides the horizontal scroll bar

For example, in the deep history for relation 1703814, there is a vertical scroll bar caused by many tags and a horizontal scroll bar caused by many versions. In this case, the horizontal scroll bar is not always visible

The horizontal scroll bar is visible only when the page is scrolled all the way down, but now the header rows are not visible any more.

- Can both scroll bars are visible regardless of the position of the other scroll bar? - It would be even better if only the tag **values** part of the page will scroll, while keeping the visibility of: 1. The tag labels on the left, as currently happens 2. The top 5 rows of the table: Version, Time, Changeset, User, and Tags 3. The search form at the top

Pull request: feature enhancement

I've made some improvement on this project to add features:

Common:

Improve map UI and fix issues
When mouse hover on table cell, highlight corresponding version of object on map and pan to center
In table, show version which is invisible in red (removed)
Base map layer: OpenStreetMap and Google Satellite
Export full data of specific version in Level0L format

Node:

Show lat, lon in table
Show way(s) which the node belongs to

Way:

Show history versions of way on map

@iandees
I would like to contribute my change back to this project. But the changes are big, I don't know if all these are align with your plan on the project. The source code has been rewritten a lot with ES6, Promise and functional style. (It's supported by most of modern browsers.) So I hesitate to raise a PR. Would you like to have a look first?

Code and readme: https://github.com/aleung/osm-deep-history

Example:

Node
Way (The map needs a few seconds to load)

raw HTML in OSM tags shouldn't be inserted into the document

osm-deep-history/index.js

Line 128 in c89a7e9

.html(function (d) {

looks to be vulnerable to Stored XSS attacks. It doesn't appear that selection.html does any sanitation, so HTML in an OSM objects' tags are inserted into the DOM for example at https://osmlab.github.io/osm-deep-history/#/way/238028224

If we made

osm-deep-history/index.js

Line 178 in c89a7e9

 _.forEach(tags.sort(), tag => tbody.append('tr').call(row(tag, tag, null, true))); 

call a version of row that used selection.text it should solve the issue.

Integrate in the osm.org UI

This thing is great!! This should be part of the UI on openstreetmap.org!
Kudos to the devs.

Unclear map interface (objects without labels/indicators)

http://osmlab.github.io/osm-deep-history/#/node/1 - why 5 nodes displayed at map? If they mean first node position, then please also show associated version No.

There 13 versions, why here only 5 nodes? Which is first, which is latest on map?

Good tool otherwise

Visited link color often matches background

If you click on a username in a column that has the same value as the previous column, the link is styled white which matches the background of that cell.

I'm not sure what color would be preferred...gray seemed to work well when playing around. (Configured at https://github.com/osmlab/osm-deep-history/blob/gh-pages/css/style.css#L102-L104).

formatting bug with chrome

Hi,

A bug with chrome (I have the last version 96.0.4664.93) when history is very big = the columns are not aligned and the end of the second row (with the date of the changeset) is offset from the other rows :

With Firefox, colons are ok :

Best regards

Include geometries for different versions on a map

This is already there for node deep-history, but for ways it becomes quite a bit more complicated. We need some way of showing what a way looks like between each way version (because nodes can move without the way changing version).

I was thinking a timeline under the map with a point for each geometry change?

Also have to figure out how to handle the possibly long delay as the browser loads the history for each object.

This should probably not be done for relations quite yet.

Right click>Paste doesn't work if box is empty

Hi
<bit quiet around here, isn't it?>

I'm unable to right click & paste the id number into the box if it is empty. If there's is a number & I 'select all' I can do this.
Ctrl V works as expected.

secure page not working with current firefox

firefox now automatically removes some http-only links on https sites. Thats why deep history is not working any longer as https version, I fixed the secure connections and sent a pull request #5 some time ago

License?

The LICENSE file is Apache 2.0 license, while in package.json the license is BSD. Which one is correct?

show relation members

I think it would be useful if the relation history view could also show members in the diff, to see how the members of a relation has changed over its history.

Reverse order of versions

Hi
Although viewing the earliest versions of an object are useful, I find myself being most interested in the last two or three & having to scroll the list to the end. if think it would be beneficial to have the default view displaying the most recent at the far right, or maybe reversing the list so the recent edits were to the left.

No highlighting after clicking on "Show all"

If there are more then 20 iterations of an element the older ones are hidden by default.
After clicking on the button "Show all" the map highlighting does not work anymore.
Example: https://osmlab.github.io/osm-deep-history/#/node/82699742

Latest Features

Hi
I'm liking the latest updates. Request for a couple of tweaks:

Could the horizontal scroll bar be permanently visible at the bottom of the screen? If an entity is quite old it accumulates many historical tags making the list & scroll bar disappear off the bottom of the window.

Could abutment between the map & the tag list be horizontally slidable so the image can be reduced and/or an option to hide the map? This enable more edits to be displayed without scrolling.