osmlab / changewithin Goto Github PK

• Do not list nodes that are part of a way with building=* anyway

I’m curious about a couple Python stylistic decisions I’ve encountered.

The sets module has been deprecated since Python 2.6 in favor of native set() support. Is sets in use here because you need to support an older version of Python?

point_in_poly appears to implement a native algorithm instead of relying GEOS, OGR, or Shapely. Are those libraries unavailable where this code is being run?

The link surrounding the img tags are wrong.

The lat and lon are flipped the wrong way.

On line 136 of lib.py, you see the error clearly:

changeset['map_link'] = 'http://www.openstreetmap.org/?lat=%s&lon=%s&zoom=%s&layers=M' % (extent['lon'], extent['lat'], extent['zoom'])

If someone teaches me to make pull requests, I can fix problems faster :)

• Serge

python changewithin.py
Traceback (most recent call last):
File "changewithin.py", line 49, in
aoi_href = config.get('area', 'geojson')
File "/usr/lib/python2.7/ConfigParser.py", line 607, in get
raise NoSectionError(section)
ConfigParser.NoSectionError: No section: 'area'

Thumbnails don't quite reflect the are in which there were changes.

• At least use changeset bounding box
• Preferably use bounding box of all contained building+address changes

We'll need to build in some safety guard for very voluminous changes. Should be incredibly cheap in the first iteration. Like just saying after X changes "There are (TOTAL - X) more changes not captured in this notification"

1. Find 'centroid' of nodes in a way by just averaging them
2. Generate a MapBox REST API url for a static map
3. Embed that image in the email.

Right now the approach this takes is:

• Get all changes
• Find all nodes within the polygon
• Find the ways that have those nodes, filter out non-buildings

Some buildings are POIs, and we should support them too.

Say "changed addresses: none" or betterwhen there is no result. Same for buildings.

Better: skip the label 'changed addresses:' or 'changed buildings:' if there is no changed address or building.

@MateoV - Could you deploy the latest version of changewithin to benzene? We should also start versioning using semver.

http://planet.openstreetmap.org is available over https, and will start redirecting to https on 2018-05-07.

Your project seems to be using curl, which will not follow redirects by default.

Would it please be possible to update all files from http://planet.openstreetmap.org to httpS://planet.openstreetmap.org before then?

Ideally, would it be possible to make all requests to openstreetmap.org over https?

We can make the email prettier pretty simply

• https://github.com/osmlab/changewithin/blob/master/changewithin.py#L111-L160

Save any emails sent to disk with appropriate date.

• Track changes to address nodes (nodes that have an address but aren't buildings)

Right now changewithin flags any change to a building way. So if you add for instance a node on a straight way in a manner that does not change the actual shape of the way changewithin would still flag the change.

This leads to a lot of false positives for instance where user robgeb adds 3d details to buildings that actually don't have an impact on the building outline.

• Show changeset comment together with building changes
• This means we'll want to group changes by changesets (otherwise we'll wind up printing the same comment over and over again).

@iandees -

Can we deploy this change detection script on benzene? I know @tmcw has reached out to you already, but we'd love to set this up on benzene for testing.

/cc @tmcw @MateoV