Giter Club home page Giter Club logo

Comments (8)

ReSearchITEng avatar ReSearchITEng commented on August 15, 2024 1

Thanks for accepting the change.
FYI, we've added your docker image as the default keepalived option for to our project kubernetes installation project: https://github.com/ReSearchITEng/kubeadm-playbook/blob/50a26fd52ae32b6782caf23e941f44667771ede7/roles/keepalived/tasks/main.yaml#L26

from docker-keepalived.

ReSearchITEng avatar ReSearchITEng commented on August 15, 2024

I noticed that the docker image on docker-hub does not match the Dockerfile.
https://github.com/osixia/docker-keepalived/blob/stable/image/Dockerfile -> does contain curl, which the images from https://hub.docker.com/r/osixia/keepalived do not...

from docker-keepalived.

BertrandGouny avatar BertrandGouny commented on August 15, 2024

@ReSearchITEng it's the same file use on github and for the docker image
curl is installed and then removed check

from docker-keepalived.

ReSearchITEng avatar ReSearchITEng commented on August 15, 2024

yes, it's there in the Dockerfile, but not in the images...
Am I doing something wrong?

 docker run -d --name test osixia/keepalived:latest

 docker exec test curl
rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:247: starting container process caused "exec: \"curl\": executable file not found in $PATH"

docker exec test /bin/curl
rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:247: starting container process caused "exec: \"/bin/curl\": stat /bin/curl: no such file or directory"

[docker@docker01:0 ~]$ docker exec -ti test bash
bash-4.3# curl
bash: curl: command not found
bash-4.3# which bash
/bin/bash
bash-4.3# which curl
bash-4.3# which curl | wc -l
0

from docker-keepalived.

BertrandGouny avatar BertrandGouny commented on August 15, 2024

in the same run statement curl is installed to download keepalived sources and then removed, so yes it's not available in the docker image

install :

removed

from docker-keepalived.

ReSearchITEng avatar ReSearchITEng commented on August 15, 2024

Oh, sorry, I see the remove.
so, can we keep it, for the reason presented in this issue: check scripts usually do curl to figure out if their servers are healthy.
Other than that, it's a great image, where one can mount inside config and check scripts, without providing huge amounts of params.
(We have templates for config, so no need for passing too many params).

Should you agree with it, here is the PR: #30

from docker-keepalived.

BertrandGouny avatar BertrandGouny commented on August 15, 2024

Thanks for the PR will try no make a release later today :)

from docker-keepalived.

linkvt avatar linkvt commented on August 15, 2024

@BertrandGouny ticket can be closed, curl exists inside the container.

from docker-keepalived.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.