in nl skin zijn de check-boxen voor record selectie gedeactiveerd, waardoor het niet mogelijk is een rapport te maken van een record selectie.

in "metadatabeheer" zijn juist de geavanceerde zoek opties niet beschikbaar

In de code zie ik een isAdmin check voor weergave van checkboxen, dus blijkbaar is wel bedoeld om aan publieke zijde alsnog checkboxen te tonen als user ingelogd is als admin, echter dit werkt niet, hier checkboxen tonen (voor role (user)admin) lost dit probleem op

would be good to use the default region thesaurus, or provide a download link for the geodatastore thesaurus
https://www.nationaalgeoregister.nl/geonetwork/srv/dut/thesaurus.download?ref=external.place.administrativeAreas

Locationserver provides the full geometry of a selected feature if you request lookup with extended fields. Gazeteer can use that value to zoom more precisely (now is using a center-point + level-per-type)

should use configuration from settings

on v 3.8 the list.html view of search results has big font for header and could align some wider

it seems to be triggered by the 'remove element' button

with the move to new openlayers in 3.10, the zoom factors seem changed, now when you zoom to address or street, the zoom is too much detailed (and for me some 50m off).

suggesties vanuit RWS:

Bij WCS mag voeg toe aan kaart weg. Want wcs kan je niet direct visualiseren. Dat doe je met wms and arcgis rest.
Van de arcgis feature service zou ik knop maken open link zodat je de capabilities van de service ziet en je dan naar de viewer van arcgis online kun komen.
Ik zou het uitschrijven de de hele url weglaten en ook meer info over type service.
Dus net zoals bij downloads het geval is. Kort en overzichtelijk.
Ik twijfel nog of je een wms ook wilt kunnen openen (kopieren, openen in qgis). Maar dat kan je ook via kopie in je browser doen. In theorie zit je geen url te kopie pasten maar zoek je in je client op basis van CSW en voeg je daar data toe.

4 tabbladen: webservices, downloads, featurecatalog en metadata links

icon voorstel:

now is downloads, could also be general

De thumbnails bij de datasets worden “niet goed” getoond in lijstweergave, er wordt ingezoomd (werkelijke grootte?) op een deel van de foto.
In de vorige versie werd er uitgezoomd op het extend van de afbeelding en dat lijkt me beter.

In bijna alle browsers wordt het logo in juiste formaat weergegeven (280 x 70 pixels).

Alleen in de omgeving Citrix met IE (versie 11) de standaard browser is, wordt het logo klein weergegeven (112 x 28 pixels).

Probleem zit waarschijnlijk in

Wanneer ik op inspect element klik, zie ik onderstaande instellingen

De max height staat ingesteld op 28 pixels. Dit verklaart dat het logo wordt weergegeven op 112 x 28 pixels. Door het vinkje voor max-height uit te zetten, krijgt het logo de oorspronkelijke grootte (340 x 85 pixels).

In Firefox staat de 28 pixels instelling doorgestreept:

hoe kunnen we ervoor zorgen dat het logo in IE net zo wordt weergegeven als in de andere browsers?

java.lang.IllegalArgumentException: Found a dependency: search_filter_tags_directive that does not exist. It is a transitive dependency of gn_search_dutch. Dependency path [gn_search_dutch, dutch_search_controller, search_filter_tags_directive]

Used in https://github.com/osgeonl/geonetwork-dutch-skin/blob/3.4.x/javascript/DutchSearchController.js#L7

organisation logo on search results is only relevant if there are records from many organisations on the catalogue, so enable to configure a list view without logo, in stead display the thumbnail

The current behaviour is that a category=inspire has to be set on a record in order to display the inspire tab on md-view.

Is this a nice convention for the dutch skin, or should we make it unique for the ngr implementation?

in the dutch skin the link to update the password has been accidentally removed (it is available in the admin area). Link should be on username, and link to srv/dut/admin.console#/organization/users

if you query by location, the filtertags directive errors (not displaying filters)

• Herzieningsfrequentie: de gegevens worden in het Engels weergegeven (bijv. unknown of annually)
• ValidationStatus: graag de Engelse term veranderen naar een Nederlandse term, bijv. validatie status

Trying to use the 3.8.x branch of the skin in GeoNetwork 3.10.x causes the following issue:

Error: [$injector:modulerr] Failed to instantiate module ol.proj.EPSG28992 due to:
TypeError: Cannot read property 'setExtent' of null
    at http://localhost:8080/geonetwork/catalog/views/dutch/javascript/epsg28992.js:25:38

Probably related to the recent upgrade of OpenLayers in GeoNetwork.

Created this issue to create a new branch in the skin 3.10.x and upgrade the code to work with GeoNetwork 3.10.x.

in settings add a setting to set alternative recordview.html
if empty, use default recordview.html

position:fixed -> position:absolute omdat dutch view niet de volle breedte van de pagina vult (version gn 3.4.3)

liever d-m-y

now feature catalog opens in downloads tab, better to show in its own tab, hide the tab if no feature catalog is available.

The menu bar in the dutch view does not provide an option to update the user profile like the default product

on version 3.4.3 the brtachtergrondkaart does not load from default dutch owscontext
https://github.com/osgeonl/geonetwork-dutch-skin/blob/3.4.x/config-nl-viewer.xml

no method getcode from undefined

i checked, but the epsg:28992 is available

a suggestion could be is that is is related to the tilesetmatrixset "25831" in
https://geodata.nationaalgeoregister.nl/tiles/service/wmts?request=GetCapabilities
(although the map should be in epsg:28992)

What has to be done with this step:
In /WEB-INF/config/config-summary.xml, configure the facets to be displayed on the search results.? Which facets have to be configured?

And what has to be done in this step:
In /catalog/js/gnLocale.js, reference the skin language override file /catalog/views/dutch/locales/nl-core.json? How and where do you reference the skin?

Seems the epsg:28992 projection is not available to the editor, for now do not set the editor map projection to epsg:28992, else you'll get the error below

TypeError: Cannot read property 'getCode' of null
at Object.ol.proj.getTransformFromProjections (/geonetwork/catalog/lib/ngeo/ngeo-debug.js:6958:47)
at Object.ol.proj.getTransform (/geonetwork/catalog/lib/ngeo/ngeo-debug.js:6941:18)
at Object.ol.proj.transformExtent (/geonetwork/catalog/lib/ngeo/ngeo-debug.js:7042:29)
at Object.reprojExtent (/geonetwork/catalog/components/common/map/mapService.js:302:30)
at reprojExtent (/geonetwork/catalog/components/common/map/mapDirective.js:166:35)
at link (/geonetwork/catalog/components/common/map/mapDirective.js:179:14)

In the dutch skin is missing any support for the advanced rating functionalities (user feedback) introduced in the 3.4.2 version of GeoNetwork.

Check: https://github.com/geonetwork/core-geonetwork/blob/e1c70f2170f0acc3eabce37684b1127a10da31b0/web-ui/src/main/resources/catalog/views/default/templates/recordView.html#L409-L423

if you select 'binnen' (within), the filter is not applied

this functionality works fine in core, so there should be some code in dutch-skin breaking this

Describe the bug
When importing a valid metadata record that conforms to "Nederlands profiel op ISO 19119 voor services versie 2.0" with validation enabled, validation is unsuccessful.

To Reproduce

1. Log in as user with rights to create metadata records
2. Go to the "Mijn Metadata" dropdown button on top of the page and choose "Records Toevoegen"
3. On the "Records Importeren" page:

• choose the "Importeer een of meer lokale bestanden" radio option
• check the checkbox "valideren"
• select import action "Genereer een UUID voor de nieuwe metadata"
• upload this service metadata record

See also the attached screenshot.

Expected behavior
Record validates and is imported to the catalog.

Screenshots

Context

• Op https://nationaalgeoregister.nl/
• Afgeleide versie: 3.4.4-2-269-dirty
• Commit hash: ca2379be7533592b4cee46258d62db62478aafb4

Description

Validation status for a service metadata record (ISO19110) reads: Valide (iso19139.nl.services.2.0.0). See example here.

Expected behavior

Validation status should read: Valide (iso19110.nl.services.2.0.0).

Tried installing the geonetwork-dutch-skin on a GeoNetwork 3.4.1 on Tomcat by copying the files in the catalog/views folder. After activating the view I got a barebones HTML page:

Quick inspection of the browser developer panel learned that the following request failed with a 404 http://localhost:8000/geonetwork/static/gn_variables_dutch.less

Also in the JS console a bunch of errors where listed:

background layers does not show as a pull down

Various fields from iso19115/9 are shown but not the 19110 fields

this icon has a strange position, better to remove it

on v3.8 in list view the pull down of layers is empty

the specialisation of dutch skin to have logo in a header bar is now available in core as a configuration option, dutch skin should be updated to facilitate configuration of this option.

Ngr has a top menu added as a customisation, would be good to introduce this menu also in the dutch skin (and core?). The menu uses the static-pages-list-viewer directive with a section=top:

<div class="pull-right hidden-xs contact-links">
    <ul style="list-style:none;margin-left:0;margin-right:10px">
       <li gn-static-pages-list-viewer=""
        data-section="top" style="float:left"
        data-language="{{lang}}"></li>
      </ul>
  </div>

the top menu will only be visible if 'logo in header bar' is activated, it will probably position left if the logo is positioned right and vice versa

this problem does not occur on vanilla server, so my guess it relates to the dutch skin

this article describes how chrome facilites an opensearch use case, type the url, hit tab, type a term and hit enter. if chrome detects that this website has an opensearch interface, it will delegate the search to the opensearch mechanism of the website.

for geonetwork typing a url, tab and term works fine in chrome, however when hitting enter it will run a query including 2 spatial filters always returning 0 results

These filters are advertised in opensearch configuration, and may be suggested by the inspire opensearch recommendations...

Wanneer er geen link naar een bron is aangemaakt (en daardoor alleen de tabbladen ‘Beschrijving’ en ‘Contact gegevens’ beschikbaar zijn) wordt het tabblad ‘Contact gegevens’ niet zichtbaar als je er op klikt (zie onderstaande afbeelding). Als er wel een link naar een bron is aangemaakt (en er daardoor drie tabbladen beschikbaar zijn) werkt het tabblad ‘Contact gegevens’ wel.

I can not reproduce this on vanilla geonetwork, so i guess it is related to dutch view (locatieserver search).

Reproduce by:

• load a dutch map in epsg:28992 in a clean browser
• notice that panning works fine
• zoom to an address (with location search)
• refresh the page (f5)
• try to pan to other side of country
  -> the map prevents panning outside the initial location found with the search control

(maybe this happens if the metadata is auto generated from a geoserver capabilities)
on the dutch view all projections are shown 1 per line, which gives a very long list

suggest to show only first 10

Description

Validating metadata record from "Mijn metadata" page results in empty message [object Object], see screenshot.

Steps to reproduce:

• Go to "Mijn metadata" page
• Select any valid record
• Validate the selected record

Expected behaviour

Validating valid metadata should result in a meaningful message.

Context

Op https://nationaalgeoregister.nl/
Afgeleide versie: 3.4.4-2-269-dirty
Commit hash: ca2379be7533592b4cee46258d62db62478aafb4