oscoss / fiduswriter Goto Github PK

Typically the reviewers and the editor are allowed to comment on an article but not to edit it.

For testing created 4 comments and removed them using different methods. than after reloading i have 1 piece of text - highlighted

Database, comment column is empty

After rerendering page multiple times, still highlighted

Json exists in db, but container is empty

Examples for semantic comments (just to explain the broader context – let's turn the extra features into a separate issue later, but for now start with a simple subject classification of comments):

• "the selected text is related to my topic of interest <topic...>"
• "the selected text is related to something on the Web <e.g. URL of publication>"
• from a reviewer to an author: "Here, you should have used "

Feature request: be able to filter/search such comments, e.g. "display only those comments that are related to <topic...>"

Task: (help to) define how semantic structures in comments can be preserved in Fidus Writer

Imagine a hierarchical subject classification scheme like MSC in mathematics. (implemented in SKOS here: http://msc2010.org/resources/MSC/2010/info/.)

Something similar exists for social science; please download TheSoz from http://www.gesis.org/en/services/research/thesauri-und-klassifikationen/social-science-thesaurus/ and see http://www.semantic-web-journal.net/sites/default/files/swj279_2.pdf for a conceptual overview.

Requirements:

• The author of a comment types a label of a concept into an input field. (For now, let's have one such input field per comment.) Auto-completion guides the user in finding the desired SKOS Concept (one of those that have a label matching the user's input)
• the comment is then annotated with <comment> dct:subject <URI of chosen concept> (in future there could be multiple subjects per comment)
• Any reader of a document should be able to filter comments by subject. The UI for choosing the subject should be similar to the above. After a subject S has been entered, all those comments should be displayed that are annotated with that subject S, or with a subject that is skos:narrower than S (also transitively, i.e. S skos:narrower S1 . S1 skos:narrower SubjectOfSomeComment).

1. Add text. 2) Add multiple newlines 3) Add after newlines text () 4) We can see that above text () caret is smaller:
   

support for adding discussion comments in different roles and with different visibility profiles

• readers should be able to ask questions to the authors in public or confidentially;
• authors’ comments should be configurable to be invisible to reviewers;
• reviewers’ comments should be configurable to be visible to the editorial board only, or to others, etc.),
• for a filtered and ordered lookup of comments (e.g., all comments by reviewer 1, major concerns first).

For comment-only role on the client side I check only addMark, removeMark, but I also have to check which type of mark is that, because addMark can contain not only comment, but bold, italic, link transformations

User logout and profile menu dropdown doesn't work after clicking once.

How to reproduce: Click logout menu dropdown that is located on the top right. When dropdown shows, click anywhere on the page to close this dropdown. Now try again the same thing, menu will not open.

Possible cause: This issue usually occurs due to not handling DOM events properly. Registering an event multiple times causes multiple tigers of the same event.

Filtering by user roles and user names

Interface: Instead of button comments show/hide we have dropdown with list:

• filter by readers
• filter by reviewers
• filter by authors
• filter by editors
• filter by name [-> then appears centered - input for a name with ok button]
• show/hide [depends on the state]

How to recreate:

1. Create document
2. Open 5 tabs.
3. Add some comments
4. User 1, close and reopen document
5. User 1. add new comment.
6. This comment will not appear on other users screens

Why it happens. The problem can be caused by ProseMirror Update Scheduler. Need to check theEditor.mod... and theEditor.pm.mod...
How to see comments: theEditor.doc.comments

Adding json to top of document . :

{ ....,
  roles: { "user1" : "author",
              "user2" : "reader",
              "user3" : "reviewer",
              "user4" : "editor" }
}

Why json - to enable real-time filtering. Client just hides comments which are not relevant by filter

Important. For timebeing we assign users in a hardcode way

It must show the formula typed BEFORE

Probably adding different background color, or logo

It must be confirmed by Johannes firstly.

Because of problem, with constantly breaking teamviewer, it is very crucial to find a way to connect to the EIS03 host using SSH or other way.

Implement formula builder for people who dont know latex

Project documentation that is available in 3.0 branch doesn't generate html files. User can not generate documentation from reStructured Text sources.

How to reproduce: Run make html from inside docs directory. It generates several errors and doesn't create _build directory where documentation in html format should auto generate.

Possible reasons: Incorrect dependencies and configuration.

Closer look: Found few lines of code that has no relation with the project structure and project source code. Appears to have been copied from third party source as it is. Project is using Django 1.9.x but dependency configured for document generation was Django 1.8. This breaks how Django loads models for sphinx to access them.

Hey, @vinaymodi Could you please undo d442ad2 . As I mention in the comment there, this was fixed upstream a week ago, so the two fixes on top of each other mean that it's now breaking. You should probably pull the latest version directly from the fiduswriter repo.

@aw3s0me According to @vinaymodi's comments here, it sounds as if the sphinx code was copied from somewhere else. This is generally not a problem, as long as the license of the original code is so permissive that it allows you to commit this as if it were your own code. May I ask: Where did you find this?

When user 1 click on comment button, comment box appears immediately on user 2 editor too.
User 2 can write on the comment box which opened by user 1 and pressed "submit" and now it looks like that comment was made by user 1.

Write converter to RDF Graph

(Do it on server side, format (probably jsonld), same URI on server side router).
On client side there should be button (export to RDF). export only comments.

Comments:
you will only be able to describe the comments. The backend doesn't understand the structure of the document itself, and...
10:44
you only have access to the document the last time it was saved. which may be 2 minutes old
10:45
other people connecting to the editor will get the current version.

akorovin
10:46 PM so you mean that outside it is not possible to get document? it needs to be saved during 2 minutes time threshold?
10:46
for example: nobody accesses the document and some user outside wants info about annotations
10:46
it is not possible
johanneswilm
10:46 PM it is possible to see what is in the comments, yes.
10:47
but it's not possible to see what is in the document, or where the comments connect in the document
10:47
and the comments may be up to two minutes delayed, if someone is in the document.
10:47
if noone is in the document, the comments will be current.

if the last user leaves, it is saved immediately
10:50
also if the user changes the title
10:51
other than that every 2 minutes, if there have been changes to the text content
10:51
if the user just has changed comments or answered comments for half an hour, the document may be half an hour old

A basic implementation of tables is added by a patch in prosemirror repository.
As the tables are essensial for us and maybe nobody else works on it entensive, Johannes sujected to work with it to find the bugs and report to the prosemirror group in order to minimize bugs in the next release.

Once a document that is sent from OJS to FW, it must be recognized by FW later again by later access, and its history, including comments etc, must be kept and remembered by FW by later access that originates from OJS.

Add comment only role as another option in dialogue And add additional icons

When I try to filter by comments of owner, there are no information about owner in accessRights table (model).

Add newline. Cannot use delete or backspace to delete it.

When we add text and then multiple newlines, cursor can jump over some space (like 6-8 empty rows).

Type one letter and overflow property changes

Example: {...., "review:isMajor" : true .. }

firstly do a search if its an inherent problem of the python or the framework or its just a library/ server problem, estimate how much time will be needed to correct the issue.

Reported by Alexander: @aw3s0me

In disconnected mode, comment dissapears.
How to recreate: Write comment in disconnected mode. It will disappear immediately.

by johanneswilm
just add the gettext('') function call everywhere
7:55
the run ./manage.py makemessages

A user belonging to OJS should not need to be made again inside FW, but both FW and OJS must remember which user in OJS is active in FW and know their history.

The both OJS and Fidus use curl interface to interact with each other. So it is possible to send the link via this.
Also, the REST interface is being developed on OJS, so maybe there will be a possibility to avoid curl.

Roles defined and assigned to users in OJS and Roles assigned to users in FW should match to each other.

Just add prefixes about rdf, and other used vocabs.

For example: under the first review , submitted, original, under the second review , final

I started to write document wrote Title then below it wrote me disconnected then I wrote some sentence in body and program interrupted me in some moment and auto-updated. I lost all my changes.

Lost all changes after reconnection. It can be seen that Id is different. This is the new document.

Actually, after going back to document list, I realized that it saved document with 69 ID and some changes, but partly:

Connect annotations with ontology

Document json file //

{
  "@context": "http://fidus.com/contexts/oscoss.json"
}

Oscoss.json file:
link to ttl ontology

{
  "@context": "http://fidus.com/contexts/ontology.ttl"
}

Each metadata should contain namespace:

{ ...., review:isMajor : true }

Cant insert image at all. Just doesnt work

This issue for studying and information purpose
We need plugins on both sides (FW and OJS). Communication - is via curl.

1. Sending document link is via link
2. OJS plugin will receive link and show it in the document list, in OJS database there will be document containing information about fidus endpoint.

Previous attempt to integrate:
OJS plugin: https://github.com/asmecher/ojs-fiduswriter
FW plugin: https://github.com/OSCOSS/fiduswriter/tree/ojs-fidus