osbuild / cloud-image-val Goto Github PK

kernel-debug, kernel-debug-devel matching current kernel version are available in repo

Here is ami-val key steps:
run_cmd(test_instance, "sudo yum -y install install kernel-debug-devel-$(uname -r)", timeout=1200)
run_cmd(test_instance, "sudo yum -y install install kernel-debug-$(uname -r)", timeout=1200)

We discovered that sometimes the AWS keypairs are not created in time while an instance for the same region is being created and it fails due to "nonexistent keypair".

Areas of improvement are:

• Remove ".pub" in line 94
• Modify Terraform controller to handle the Terraform configuration and create keypairs first
• Remove "cloud" attribute from Configurator constructor. It already comes from resources.json
• Add "get_cloud_provider_from_resources_json" function to configurator

In osbuild/images#567 we made a non-functional change to the way we write systemd unit files. The Environment option in the osbuild stage now supports multiple entries. At the same time, we made it so that key=value assignments are quoted, which makes it easier to work with values with spaces.
From the systemd-exec man page:

ENVIRONMENT
       Environment=
           Sets environment variables for executed processes. Each line is unquoted using the rules described in "Quoting" section in
           systemd.syntax(7) and becomes a list of variable assignments. If you need to assign a value containing spaces or the equals sign to a
           variable, put quotes around the whole assignment.
...

           Example:

               Environment="VAR1=word1 word2" VAR2=word3 "VAR3=$word 5 6"

I think this change made CIV start failing to validate because it expects the unquoted strings in some of the cloud systemd units like here:

The line now is Environment="NM_CLOUD_SETUP_AZURE=yes" instead of Environment=NM_CLOUD_SETUP_AZURE=yes.

float values are not safe for comparisons, especially equality. They should not be used for version (or really, anything other than math). This codebase is already using packaging.version's parse for some of the version handling. The floats should be converted to do this as well.

Reference ticket:COMPOSER-1804.