originalutkin / custom-hooks Goto Github PK

Case: here is the feature branch. VERSION file should be changed at the the moment once feature is done (or right before release it to master). In case feature is being developed by multiple developers and each of them create smaller MRs for that, he won't be able to push it to feature branch without update VERSION fail in their MR.

Such behaviour isn't correct. As possible solution, target branch could be provided to script and in case it isn't master one, just skip any check.

Currently version checker expects that environment variable with files specified will be set. This approach has no issues in CI runner since this variable could be passed to container in config. However it is not obvious in local use case and if variable is not set locally, hook will always pass (condition won't be executed correctly).

In order to prevent such behaviour, it would be easy to use arguments. In that case, pre-commit hook will set required arguments automatically and hook will work in the same way in either pipeline or locally

In order to add additional logic to VERSION checker it could be implemented as Python script