organice / djangocms-maps Goto Github PK

According to feedback from @jmelett the aldryn_config.py file is missing in this project to make it show up on the Aldryn marketplace.

After adding that you have to select "django CMS" under "COMPATIBLE PROJECT TYPES" (inside the "Package" section).

Examples

• aldryn-newsblog
• djangocms-googlemap
• djangocms-picture
• djangocms-style
• djangocms-text-ckeditor

There are (English) text strings in JavaScript code that show up on the map UI. Those text segements are not captured by Django's gettext based extraction and the transifex translation process.

Examples

• Mapbox: "Streets", "Satellite", "Hybrid" layer labels (mapbox.js:L93-95)

Resources, And Possible Tools Or Solutions

• django-jsgettext
• i18n in JavaScript code (Django docs)

The JavaScript implementations currently initialize the center value to an arbitrary point in Switzerland:

• googlemaps.js, line L61
• mapbox.js, line 65

This results in the map "jumping" from an initially drawn location in Switzerland to the location specified by the plugin user (the website). The behavior seems unnecessary and can be avoided.

Expected Result, Expected Implementation

• The map should draw the requested location immediately. No "jumping" should be noticeable.
• The options.center value can be initialized correctly before the map is initialized and drawn.

After detecting and fixing syntax errors in the long description of the package (use anonymous links, use uniform section markup; commit 578f6ca) PyPI refuses an upload of a package filename with the same, current version number:

$ python setup.py sdist upload
...
running upload
Submitting dist/djangocms-maps-0.1.0.tar.gz to https://pypi.python.org/pypi
HTTP Error 400: This filename has previously been used, you should use a different version.
error: HTTP Error 400: This filename has previously been used, you should use a different version.

for example:

  |   File "/usr/local/lib/python3.7/site-packages/djangocms_maps/migrations/0001_initial.py", line 23, in Migration
web_1  |     auto_created=True)),
web_1  | TypeError: __init__() missing 1 required positional argument: 'on_delete'

ugettext_lazy was deprecated in Django v2.2

https://github.com/Organice/djangocms-maps/blob/main/djangocms_maps/models.py#L5

  File "/usr/local/lib/python3.11/site-packages/djangocms_maps/models.py", line 5, in <module>
    from django.utils.translation import ugettext_lazy as _
ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation' (/usr/local/lib/python3.11/site-packages/django/utils/translation/__init__.py)

When a website is served via HTTPS then a HERE Map is not shown. This is because JavaScript resources are loaded via HTTP, hence new browsers refuse to load "insecure content" for a "secure site".

Details

mapsjs-core.js:51 Mixed Content: The page at 'https://demo.organice.io/about/directions/?edit' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://1.base.maps.api.here.com/maptile/2.1/maptile/newest/normal.day/16/34…L_JSMv3.0.12.4&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng'. This request has been blocked; the content must be served over HTTPS.response.Nc.qn.arraybuffer @ mapsjs-core.js:51
mapsjs-core.js:51 XMLHttpRequest cannot load http://1.base.maps.api.here.com/maptile/2.1/maptile/newest/normal.day/16/34…L_JSMv3.0.12.4&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng. Failed to start loading.response.Nc.qn.arraybuffer @ mapsjs-core.js:51

Update 1 (03-Mar-2018)

When viewing https://demo.organice.io/about/directions/?edit the browser console still spits out:

No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://demo.organice.io' is therefore not allowed access. The response had HTTP status code 403.

The total console output is rather lengthy, and repeats the following pieces several times:

mapsjs-core.js:170 
GET https://3.base.maps.api.here.com/maptile/2.1/maptile/7c6ed1603b/normal.day/16/34122/23064/256/png8?xnlp=CL_JSMv3.0.17.0&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng 403 ()
?edit:1
Failed to load https://3.base.maps.api.here.com/maptile/2.1/maptile/7c6ed1603b/normal.day/16/34122/23064/256/png8?xnlp=CL_JSMv3.0.17.0&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://demo.organice.io' is therefore not allowed access. The response had HTTP status code 403.

The closing error message is:

here.js:110 Error: [timeout] https://geocoder.api.here.com/6.2/geocode.json?xnlp=CL_JSMv3.0.17.0&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng&searchText=Isles%20of%20Scilly%2C%20TR24%200QH%20Isles%20of%20Scilly request failed
    at Object.Zc (eval at <anonymous> (mapsjs-core.js:56), <anonymous>:11:176)
    at b (eval at <anonymous> (mapsjs-core.js:56), <anonymous>:9:440)
    at eval (eval at <anonymous> (mapsjs-core.js:56), <anonymous>:10:43)

Maybe Worth Mentioning

The top of the errors in the browser console says:

Uncaught SyntaxError: Unexpected token <
geocode.json?xnlp=CL_JSMv3.0.17.0&app_id=1ORPrZhy42YS0Ktrf6ZQ&app_code=OHnW8ll7OllNXLfpGd5Lng&searchText=Isles of Scilly%2C TR24 0QH Isles of Scilly&jsoncallback=H.service.jsonp.handleResponse(5):1

... and a comment on StackOverflow mentions:

Note, since I just wasted half a day chasing this bug - If the server side script fails with an internal server error, the browser may interpret it as if the request wasn't allowed due to Access-Control-Allow-Origin and report this as the error.

Update 2 (04-Mar-2018)

After trying to set CORS headers using django-cors-headers the response doesn't change.

A Note on Access-Control-Allow-Origin

Note that in the CORS architecture, the ACAO header is being set by the external web service (service.example.com), not the original web application server (www.example.com). CORS allows the external web service to authorise the web application to use its services and does not control external services accessed by the web application.

Source: Wikipedia

In other words, HERE Maps needs to set the ACAO (Access-Control-Allow-Origin) header.

ViaMichelin doesn't support hiding only the zoom control and the scale bar via their JavaScript API.

ViaMichelin support suggests to simply set the display style attribute of the related elements to none andblock, respectively.

Possible Solution

control.find(".ui-map-navigation").style.display = data.zoom_control ? "block" : "none";
control.find(".ui-map-scale").style.display = data.scale_bar ? "block" : "none";

In addition the ui-navigation-mode-selector (hand/lens icon above the zoom control) should generally be hidden, because it's not available with other map providers:

control.find(".ui-navigation-mode-selector").style.display = "none";

When switching map provider and leaving the zoom level (number) untouched different providers display the same zoom level differently, closer or further away.

While, strictly speaking, this is not a bug it may be an improvement from a user experience perspective to have the map be displayed at the same zoom level (flight height) for an unchanged number across map providers.

Seen with osm.

In German, we separate decimal places with a comma instead with a period like in English.

Hence, parseFloat(data.lat) will not work correctly. The decimal places of latitude and longitude are ignored.

I'll create a pull request that fixes this for Openstreetmap.

Google Maps is nice, but why not give a choice? After all it has real disadvantages and concerns to be dependent on Google Maps (privacy issues, you need an API key - since 2016, etc.), and FOSS solutions are grown out of kindergarden. A lot of business grade alternatives to Google Maps build on OSM today.

OpenStreetMap -- et alterae

Alternatives should include OSM, but may not be limited to them. Other map providers (that could be offered as "map style" or simply "map provider" in some "Advanced Settings", maybe), most if not all of them use OSM data anyway, could be:

• HERE maps (developer docs)
• MapQuest (developer docs) - will be discontinued in 2018
• ViaMichelin (developer docs)
• Bing Maps (developer docs)
• OSM via Leaflet.js (see FREITAG store pages for map examples)
• etc.

For easier maintenance (of the websites created using django CMS) we should offer all those providers in a single plugin rather than building separate plugins that would have to be added to INSTALLED_APPS.

No API Key Required

Alternatives to Google Maps may also make the requirement to specify their API key obsolete (see django-cms#40). Without an API key specified in the settings Google Maps, as an option, could simply be disabled while all the other options ("map provider") would just work.

See also Divio's djangocms-googlemap issue #27 (this is where this fork started).

The times of Travis CI are long gone (since it was acquired by Idera in 2019). We should migrate the setup to GitHub Actions. This will allow us to also run the test suite against Windows and macOS, in addition.

Examples to look at

• django-probes
• django-analytical
• pyclean