orforio / magiguide Goto Github PK

Tapping the Active Park selector on mobile causes the whole page to zoom in slightly. This is because the select element text is smaller than 16px. It should be changed to 16px to stop it from zooming in.

Add a new eagerly-loaded module called Attractions. It will power both the Ride and Show components (subject to API capabilities).

Convert the FastPasses component to a feature module

UpsertFastpassComponent should set the form's nextAvailableTime according to the following rules:

• if the startTime is within 2 hours of the current time, use the startTime
• if the startTime is more than 2 hours after the current time, use the current time + 2 hours

UpsertFastpassComponent should automatically adjust the endTime form element so that it is 30 minutes after the startTime at all times. It is still user editable. Editing the endTime does not affect the startTime.

CodeClimate shows a lot of repeated code in unit tests, mainly due to mock Fastpasses. It would be more convenient to consolidate these into a set of Fastpass fixtures to avoid repetition.

Allow users to input new FastPass details, specifying ride, start time and time next FastPass will be available.

Ride will initially be a static drop-down. This will be dynamic once the Ride feature is complete.

The last merge has introduced a bug which completely breaks the app.

The Ngrx Store initialiser is reporting that "e is not a function". This may have to do with how the metareducers array is being initialised.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Add a settings page to the main page, with a settings property in the root store.

The first setting should reset the stored data on the user's device. This will aid development.

It's not currently obvious which Fastpasses are active, upcoming or expired. Fastpasses should be sorted into groups:

• Active: Fastpasses which are able to be used
• Upcoming: Fastpasses which will be able to be used later today
• Expired: Fastpasses which may no longer be used

The FastPass model needs the following properties:

• Ride (for the time being this can be an enum or array - in future this will be tied to the Rides feature)
• Start time
• End time
• Next available time (to calculate when next FastPass will be available)

• Travis-CI
• Greenkeeper
• Code Cimate
• Netlify

Users should be able to delete individual FastPasses. There should be some sort of confirmation before FastPasses are deleted.

E2E tests should be written for all currently available features once templates have been locked down. Future features should have tests written first.

Set up Router module with the first routes necessary for the FastPass feature

The dependency @fortawesome/free-brands-svg-icons was updated from 5.8.1 to 5.8.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@fortawesome/free-brands-svg-icons is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Add the nextAvailableTime property to the Fastpasses store. It should be updated during all relevant actions.

Users should have the option of editing an existing FastPass.

List all available attractions in the API along with their current wait times.

Display attractions in alphabetical order rather than Store/ID order.

The Dashboard should show the next active FastPass as a card, as well as the time the next FastPass will be available. Clicking on the Next Available time will go to the Add FastPass feature, clicking on the active FastPass will go the View FastPasses feature.

The "Remove old Fastpasses" is currently functionally useless. The app will automatically remove old Fastpasses whenever the user goes to the Fastpasses page so there is no occasion when this button would be useful. A better idea would be to turn this into a user setting, in case the user wants to keep a record of expired passes.

Changing the Active Park should change the list of available Attractions automatically.

Pre-requisites: #69

The "Expired" Fastpasses group should have a "remove all expired" button to quickly clean up the list of expired Fastpasses, should the user wish to do so before they are automatically removed at the end of the day.

When there are no Attractions in the store, selecting the Fastpasses tab triggers an infinite loop that locks up the browser.

Install and set up the Store for NgRx

The form currently supplies NgbTimeStruct DateTime objects to the FastPass model. It should convert these to JS Date objects for storage.

Add initial Dashboard design and a menubar hooked up to the router, with mobile navigation mind.

The list of the active park's attractions should be added to the state if the list is empty or the data is more than 12 hours old.

Dates from the API are arriving as Date strings, not Date objects. They need to be turned into Date objects before they go into the Store. The Attractions Selectors are currently failing because of this.

The user should be able to switch the "currently active" park. This will set a state flag, changing the attractions the user sees in the Attractions and Fastpasses feature.

UpsertFastpassComponent should set the startTime form element to the current time, rounded up to the nearest 5 minutes.

With the AttractionsService retrieving live Attraction data, Fastpass should use this data instead of the hardcoded values.

According to https://securityheaders.com/?q=magiguide.com&hide=on&followRedirects=on we are missing two security headers.

• Content-Security-Policy: https://scotthelme.co.uk/content-security-policy-an-introduction/
• Feature-Policy: https://scotthelme.co.uk/a-new-security-header-feature-policy/

Show active FastPasses as cards, with the ride, start time and end time clearly visible

When adding a new Fastpass, clicking the Add Fastpass button should clear out the form, resetting to defaults

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Set up the Actions, Effects and Reducers for current FastPasses functionality.

Whenever FastPasses are requested, the service should delete FastPasses that belong to days in the past, but not expired passes from the same day.

Example:
Current date and time is 3rd June, 15:00.
All 2nd June FastPasses should be deleted.
3rd June FastPass at 11:00 should not be deleted.

The list of available attractions should be limited to the current active park, and only attractions with Fastpass active.

FastPasses Service should handle CRUD operations for FastPasses, saving details to browser's local storage.

Exact implementation to be researched - IndexedDB?

• https://localforage.github.io/localForage/
• https://github.com/Alorel/ngforage

Need to design several icons to skin the PWA properly:

• Favicon
• App icon
• Splashscreen

On the Dashboard and Fastpasses page, the "Next Available Time" should be turned into a card, similar to the one used by ViewFastpass. Investigate turning the card into the UpsertFastpass component when clicked on the Fastpasses page. On Dashboard it should redirect to the Fastpasses page.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

The dependency @fortawesome/free-brands-svg-icons was updated from 5.7.2 to 5.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@fortawesome/free-brands-svg-icons is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency karma-jasmine-html-reporter was updated from 1.3.1 to 1.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

karma-jasmine-html-reporter is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴