orbinson / aem-dictionary-translator Goto Github PK

The publish button for dictionaries is gone.

When publishing labels, the labels get published but also an error occurs every time:

"Bad Request"

When exporting a dictionary and updating the translations, after trying to import the changes an error occurs.

"The label already exists"

How to reproduce:

• create dictionary with multiple languages (e.g. en, nl, fr)
• export CSV
• change the order of languages to something else (e.g. fr, en, nl)
• import CSV

You will receive error:
please only add languages that exist in the dictionary

This will also occur if you only import 1 language and the dictionary contains multiple languages.
If the dictionary contains of en, nl, I want to be able to only import nl

Steps to reproduce

• create a dictionary with multiple languages (e.g. EN, FR & NL)
• add a label
• add translations for this label in all languages except FR

Finding

A node is created in JCR in the FR section. This node has an (empty) sling:message.
Because a sling:message is available in FR, it's blank value is shown in the FR site-section instead of a falling back to the filled-in EN translation.

I expect that if an author deletes a label / dictionary / language, it also unpublishes it so that there isn't a difference between author and publish

I have installed the tool on my AEM on premise (6.5 with SP 6.5.21).
Unfortunately the tool for me doesn't work at all. I am not able to create any dictionary or seeing the existing one.
Check screenshots

We would like to use this tool for our AEM implementations but not possible if is like that...

When selected a dictionary or label, the publish button is always available and do not take ACLs into account

You get always a successful message (Label/Dictionary published), despite it not being published if you do not have the correct permissions.
( in the Logs it is visible it was not published:
*ERROR* [[0:0:0:0:0:0:0:1] [1709119475475] POST /apps/aem-dictionary-translator/content/granite/dialog/dictionary/publish/items/properties/items/columns/items/column/items/form HTTP/1.1] be.orbinson.aem.dictionarytranslator.servlets.action.ReplicateDictionaryServlet ReplicationException occurred when trying to replicate dictionary in ReplicateDictionaryServlet
)

Also when you dont have the rights to create a label or update a label, you always get the info message Label saved while the operation was not successful

When opening a dictionary labels page, there is no visual way to go back.

export

Add the option to export the key and translations for all labels (in all defined languages) for a selected dictionary to CSV.

The resulting file should have

• 1st column, containing the label's key (column header 'KEY`)
• a columns for each language defined in this dictionary, containing the label's translation for this language (column header = the language-code for this language)

import

Add the option to import a CSV file into a selected dictionary.

The import file should be considered invalid (and an error should be shown if)

• the file is empty or invalid
• column 'KEY` is missing
• column 'KEY` contains keys that are not available in the selected dictionary
• other column-headers contain a value that does not match with a language-code defined for the selected dictionary

Remark: Not ALL languages defined in the selected dictionary should be present in the import CSV. This will allow a user to import translations language per language (if this is needed)

If the import file is valid,

• the translation-value of a label is updated for all languages provided in the import file
• a translation node is created if it is not yet available in CRX
• if a translation value is empty, the sling:message for this node should be removed

No clear indication when trying to create a label which name already exists.

Test steps:

1. Create a label with name test
2. Submit dialog to create the label
3. Create a new label again with the same name test

Expected behaviour:
A clear message should be shown to indicate this label already exists

Actual behaviour:
A generic error message Server Error is being shown

Exporting a csv with a language with only empty translations sometimes gives completely empty file.