The vs-transitions from orangechannel

some bugs

Great transitions for vapoursynth!

There is a bug in vs_transitions, in "fade_to_black" and "fade_from_black" , where black clip is hard coded to 24fps (using BlankClip),
so at the end of those two functions could be in init.py:
black_clip_resized = black_clip_resized.std.AssumeFPS(fpsnum=src_clip.fps.numerator, fpsden=src_clip.fps.denominator)

also to make it work for API4 it needs something like:
try:
isAPI4 = vs.__api_version__.api_major >= 4
except AttributeError:
isAPI4 = False
and to add in "wipe" function:
if isAPI4: ptr = np.asarray(fout[0])
else: ptr = np.asarray(fout.get_write_array(0))

bugs "_squeeze_expand" "fade_to_black" and "fade_from_black"

Hello ! Thanks for a great resource !

Within function "_squeeze_expand" there is a at least 1 bug : referencing width instead of height for up/down.

Partial fix to reference height may not work, not tested properly, so far "up" yields no direct errors

	elif direction in [Direction.UP, Direction.DOWN]:
		h_inc = math.floor(scale * clipa.height)
		h_dec = clipa.height - h_inc

		if h_inc == 0:
			return clipa_t_zone

		if direction == Direction.UP:
			return StackVertical_wrapper(ID, 
				[clipa_t_zone.resize.Spline36(height=h_dec), clipb_t_zone.resize.Spline36(height=h_inc)]
			)
		elif direction == Direction.RIGHT:
			return StackVertical_wrapper(ID, 
				[clipb_t_zone.resize.Spline36(height=h_inc), clipa_t_zone.resize.Spline36(height=h_dec)]
			)

however in a debug version of the code, "down" yields

2023-03-26.19:14:36.454997 DEBUG: vs_transitions: linear_boundary: Entered _squeeze_expand ID=14 clipa_movement=squeeze clipb_movement=expand direction=down
2023-03-26.19:14:36.454997 DEBUG: vs_transitions: linear_boundary: Entered _squeeze_expand ID=14 clipa_movement=squeeze clipb_movement=expand direction=down
2023-03-26.19:14:36.548749 Post set_output: Consistency Check: FAILED to get_frame at frame 101 (base 0) of 1649 (base 0): FrameEval: Function didn't return a clip
2023-03-26.19:14:36.548749 Post set_output: Consistency Check: FAILED to get_frame at frame 102 (base 0) of 1649 (base 0): FrameEval: Function didn't return a clip
2023-03-26.19:14:36.548749 Post set_output: Consistency Check: FAILED to get_frame at frame 103 (base 0) of 1649 (base 0): FrameEval: Function didn't return a clip

I guess I'll look over at https://github.com/Irrational-Encoding-Wizardry/vs-transitions :)

Also _AI_ has mentioned blankclip fps (and perhaps implies format=) related issues in https://forum.videohelp.com/threads/408230-ffmpeg-avc-from-jpgs-of-arbitrary-dimensions-maintaining-aspect-ratio/page3#post2685292 where I guess I'd probably consider looking to create/convert blank_clip straight away to have the same properties as the incoming source clip(s).

Cheers !

orangechannel / vs-transitions Goto Github PK

vs-transitions's People

Contributors

Stargazers

Watchers

Forkers

vs-transitions's Issues

some bugs

bugs "_squeeze_expand" "fade_to_black" and "fade_from_black"

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent