global read method can't be limited by allowIO or redirected by fileSystem about graaljs HOT 8 CLOSED

Thanks for the report! We'll fix that.

from graaljs.

Does this apply to readFully as well? I am currently debugging an issue with readFully not honouring a custom filesystem, and this might be the cause.. any ETA on a fix? This would seem to be a pretty big gap for FS operations..

from graaljs.

Hmm seems like none of the globals have any reference to the Context configured custom filesystem?

read and readFully as well as readbuffer and likely others just end up trying to new File(path) as per:

https://github.com/graalvm/graaljs/blob/master/graal-js/src/com.oracle.truffle.js.builtins/src/com/oracle/truffle/js/builtins/GlobalBuiltins.java#L410

static File resolveRelativeFilePath(String path) {
        CompilerAsserts.neverPartOfCompilation();
        File file = new File(path);
        if (!file.isAbsolute() && !file.exists()) {
            File f = tryResolveCallerRelativeFilePath(path);
            if (f != null) {
                return f;
            }
        }
        return file;
    }

Is custom filesystem not supported yet? If not it should probably be called out in the docs somewhere or should throw if a custom filesystem is configured.

from graaljs.

Hi nhoughto,

you are correct, this polyglot feature has not yet been implemented in Graal.js. It is on our TODO list for this quarter. I think support (at least for the core JavaScript engine) will land in the release early October.

from graaljs.

from graaljs.

We usually close the issue when the feature has landed in the master branch of this repo. You can then use it if you build Graal.js from source yourself. If you depend on our pre-built binaries, the feature should typically be in the following release (unless it misses the feature freeze, around a week before the release).

from graaljs.

We have implemented the feature for the GlobalBuiltins (read[Fully], readbuffer, load). Again, this only affects the core JavaScript engine; no work has been done for our Node.js implementation.

This feature is on the master branch of graal.js (cda6016) and will land in the RC6 release early September.

from graaljs.

What about loadWithNewGlobal ? 🤞

from graaljs.