Number.isInteger is incorrectly false for a java.lang.Long about graaljs HOT 3 CLOSED

e.g. 28ba85f - is this expected?

No, it is not expected that isInteger()/isFinite() return false for long. It is a bug. It is an unfortunate/unexpected consequence of the changeset that you have mentioned i.e. of the fact that JSRuntime.isNumber() does not return true for long anymore.

I assume that the change in JSRuntime.isNumber() is intentional i.e. that this method should return true just for arguments that represent a numeric value that can be converted to JavaScript Number (i.e. to double) without the loss of the precision. This is not the case for long. Unfortunately, the specializations for some nodes were not updated to match this change.

from graaljs.

Fwiw, even Number.isFinite(longNumber) is false.

@woess looks like you worked on something relevant in March, e.g. 28ba85f - is this expected?

from graaljs.

Fixed by 1c51911

from graaljs.