opty-fi / earn-protocol Goto Github PK

• Use adapter contracts from team defi adapters for unification

The harvest finance adapter requires the vault contract to get white listed. This changes needs to be done in the test cases if the same.

Please refer defi-adapter-kit for inspiration.

This is with respect to this PR.

• _getBestAPR is handling the edge for WETH token as of now. However, if using getTokenConfigBySymbol(symbol) of Compound, then MKR token's edge case can be added as MKR contract returns MKR's symbol's hash and not "MKR" as string.
• This has to be explored bit more as well as if MKR is possible scenario or not.
• Also, Maybe we can use getTokenConfigByUnderlying(token) with an exception for MKR. However, this function also returns error right now for MKR token address and therefore needs more exploration.

Two new functions:

1. withdrawFor
2. depositFor

The purpose of these functions is to permit a contract to perform a withdraw or deposit function on behalf of a user - in particular it is useful for tracking deposits/withdrawals made by LimitOrder contract suite on behalf of users (order.maker).

There is uncertainty of protocols distributing rewards. This should be handle dynamically by making web3 calls when test cases are executed.

This refactoring to dynamically determine the status of reward distribution can be applied across other protocol adapters as well.

This is with respect to this PR.

• Remove returns(bool) from setter functions
• Repetitive checks and do code re-use
• No need to check address(0) if isContract() check is done.

• Handle strategy manager when OPTYTokenDistributor and ODEFIVaultBooster are zero addresses
• Document with clarity for _emergencyBrake() inVault.sol
• Document getPricePerFullShare and getPricePerFullShareWrite in Vault.sol stating the edge case scenario when last step step is curve
• In RegistryProxy.sol, remove initialization of setOPTYDistributor(msg.sender) from constructor
• In ModifierController.sol, check that _OPTYDistributor is not an EOA.
• Write unit test to verify all the changes.
• Vault exceeds 24kb

• The strategy hash compose is incorrect.
• Perform keccak256 hash of tokensHash and strategy step

• Unit testing for OPTY distributor w.r.t #265

Problem

• Whenever Vault deposit to the strategy through series of function call using MultiCall contract, it does not consider return values if any protocol returns on deposit.
• Whenever Vault withdraws from the strategy through series of function call using MultiCall contract, it does not consider return values if any protocol returns during withdraw.

Possible Solution

• Deposit : Check the difference of vault balance in underlying token before and after deposit. Some protocols may limit the investment so consider that via calls made to the adapter.Revert if the difference is not as expected
• Withdraw : Check the difference of vault balance in underlying token before and after withdraw. Revert if the difference is not as expected.

• The protocol requires a Library of Error codes.
• Motivation : https://github.com/aave/protocol-v2/blob/master/contracts/protocol/libraries/helpers/Errors.sol

This PR has been closed due to DyDx Solo Layer 1 winding down. (https://dydx.exchange/blog/layer-1-wind-down)