Hi,

I got 2 issues with the new version:

1. when saving a filter with an Expression Search - NG rule the condition is changed from "Match all of the following" to "Match any of the following". If I remove the Expression Search - NG condition and save it, then "Match all of the following" is saved as it should.
2. the search term is not shown in the form field when reopening the rule (although it's correctly saved in the msgfilterrules.dat). I saw this issue with another filter addon (FiltaQuilla). Apparently the field does not get populated due to a change in TB a few versions ago. According to that addon's developer this issue can be solved easily by adapting the code to the new programming of TB.

Here is the rule as saved under msgfilterrules.dat:

name="HackAnhang"
enabled="yes"
type="17"
action="Delete"
condition="OR (expressionsearch#attachmentNameOrType,contains,.7z)"

(as you can see the condition is changed to "OR", but the search string is present)

The screenshot shows the filter after reopening it. It was save with "Match all of the following" and the Attachmeng Name/Type" field should show ".7z"

Would it be possible to have an option in settings where I could preset some options? For example since I search most of the time in subject it would be s:

I have a couple of mails which have both labels iA and e0.

This search string works as it should (it shows all mails with both labels iA and e0.):
(label:iA label:e0) or (label:i0 label:e0) or (label:iA label:eA)

This search string does not work (it returns no search results):
(label:i0 label:e0) or (label:iA label:eA) or (label:iA label:e0)

Note that only the order of the search terms is changed.

When creating message rules with regex, the filter works, but the text disappears after closing the edit dialog. The Match any/all radio buttons won't save, and new rules can't be added after the regex rule, and other weirdness. The filter will still run but can't be properly edited anymore.

Thank you very much for maintaining a very good addon.
In the recent version of Thunderbird 102 I have a problem when the addon is enabled and I try to move a tab to a new window.

Software

• windows 10
• Expression-Search-NG: 3.4.2
• Thunderbird: 102.2.0
• I have other addons, but the tests below are with only Expression-Search-NG enabled (others are disabled).
• I use the vertical view layout, but the issue occurs with classical also.
• Settings for expression search are:

Steps to reproduce:

1. In a Thunderbird main window click the calendar icon to open the calendar in a new tab
2. Right-click the calendar tab and select "move to new window"

Expected results:

• new window opens
• new window has the 3 pane tab with Inbox and calendar displaying

Actual Results

• new window opens
• only some elements are visible; there is no inbox visible; only one tab with no title (see screenshot below)

Error console log with verbose information enabled

TypeError: browser is null
[ext-mail.js:702:19](chrome://messenger/content/parent/ext-mail.js)
    emitDetached chrome://messenger/content/parent/ext-mail.js:702
    handleEvent chrome://messenger/content/parent/ext-mail.js:579
    closeTab chrome://messenger/content/tabmail.js:1177
    replaceTabWithWindow chrome://messenger/content/tabmail.js:1287
    <anonymous> chrome://messenger/content/tabmail.js:2081
Uncaught TypeError: domNode is null
    _bindUI chrome://messenger/content/quickFilterBar.js:257
    _init chrome://messenger/content/quickFilterBar.js:46
    onLoad chrome://messenger/content/msgMail3PaneWindow.js:561
[quickFilterBar.js:257:7](chrome://messenger/content/quickFilterBar.js)
    _bindUI chrome://messenger/content/quickFilterBar.js:257
    _init chrome://messenger/content/quickFilterBar.js:46
    onLoad chrome://messenger/content/msgMail3PaneWindow.js:561
    onLoad self-hosted:1115

Thank you again

Hi,

just a little flaw: The search field doesn't darken when the dark mode is activated:

Frank

1. Create a saved search with two custom headers, e.g. Precedence and X-AMAZON-MAIL-RELAY-TYPE
2. Go to Expression Search Settings and hit "save".
3. Open properties from saved search created in step 1.

RESULT: Custom headers are scrambled:

Only tested with saved search. Maybe normal filters are also affected.

78.9.0 (64-bit), Mac OS 10.15.7

I installed it, restarted TB and the search bar tried to work (see my other post). But once I restart TB this function also disappears, like the add-on was never added.

Thanks for all your help fixing this essential tool!

I've had Nostalgy installed for years, and recently installed three of your other addons: Expression Search NG, Quicker Quicksearch, and New Thread to All (also called New Email to All and Reply++).

In each case, after installing a window popped up with information about the plugin:

I have no issues with you displaying this information. But this window had no easy way to close it -- the buttons at the top right (in my OS and UI) that normally close a window weren't there. Clicking outside the window didn't automatically close it, like a modal on a website. There was no "close" button at the bottom of the window. Finally I figured out that right-clicking the window I could close it that way, but that's a little ridiculous. I don't know if you're intentionally disabling the normal window chrome or if this is a bug, but please make it more straightforward to dismiss the post-install window.

I tested installing a few other addons and none of them had this issue, but I also couldn't find another addon that displays a popup window, so I'm not completely sure if this is specific to your addon's use of the popup window, or if it would affect any plugin using a popup window.

I'm running Thunderbird 91.6.0 on Linux Mint 20.3 (based on Ubuntu Focal).

This happened with all three of your addons mentioned at the top, but to reduce duplication I'm just posting it in this issue queue.

Relatedly, if you're working on this window anyway, the information contained in it was in English but linked to the German-language pages for your addons.

Summary

In the extension description I noted the following: This extension adds a new search text box to the end of your quick search bar, but I am unable to see, or, find a way to use, expression-search-ng in Thunderbird Daily.

I am unsure whether the extension is intended to support this version, or whether the supported version declaration is incorrect, in that it declares support for versions higher than it presently actually supports.

Environment

• OS: Windows 10 Pro 20H2 19042.964 (x64)
• Thunderbird: 90.0a1 (2021-05-04) (64-bit)
• Expression-Search-NG: 2.9

Isolation Tests

• Disable Proton
• Restore toolbar items to default
• Search all Menu items
• Try entering operators (is:replied) in both search fields

Screenshot

Thank you very much for reviving this helpful add-on!

With TB v91.2.1 at every startup the tooltip pops up completely empty and closes after ~20 secs.
Expression-Search-NG v3.1
Windows 10 Professional 64 bit.

Hi There. In my Ubuntu with Thunderbird in dark mode tooltip shows in dark green, dark red and dark magenta over black and is unreadable. so unusable.
It whould be very nice if tooltip colours could be changed or selected among several themes. Or at the very least, the tooltip window background color changeable.

Thanks and keep the good work.

by Paul:

is it possible to make the square of the search space a little longer?

I will put that as a feature request for the future into the issues on github

Expression search NG is not working with thunderbird 91.0.

Pls add support for thunderbird 91.0.

Probably a GPL infringement, should be added to master

https://github.com/wangvisual/expression-search/blob/master/LICENSE

Thanks for your efforts!

I'm running TB 91.8.0.

Based on reading the instructions there should be an Options Dialog where one can do things like turn off tool tips. However there's no wrench Icon for this tool in the 'Manage Your Extensions' screen, and I don't see any other way to activate it.

I have tried to use this saved search functionality, however for me it does nothing.

Left Control + Enter -> nothing
Right Control + Enter -> selects the text (seems like Ctrl+A)

Does this functionality work for you?
If it does - then it's perhaps something on my side and I will create new profile and test with the fresh profile.

Thanks and best regards.

This extension rocks!

Joc

For some reason, typing anything in the Quick Filter Bar now kicks up the following error 100% of the time (below).

I'm running 78.14.0 64-bit on a Windows 10 machine. Expression Search NG has been running flawlessly until a week ago. The version I have installed was last updated on September 2, 2021.

Here is a dump of the error text being reported...

Caught Exception TypeError: normalFilterState is undefined
appendTerms@chrome://expressionsearch/content/ExpressionSearchFilter.js:390:30
createSearchTerms@resource:///modules/OuickFilterManager.jsm:547:34
createSearchTerms@resource:///modules/QuickFilterManagerjsm:l 70:31
update Search@chrome://messenger/content/quickFilterBarjs:659:39
_deferredlnvocUpdateSearch@chrome://messenger/content/quickFilterBar.js:642:25

First, thank you for the great extension. It's a life saver.

I'm having an odd issue. On startup, TB displays a blank alert for about 10 seconds. It started when I installed this extension and it does not happen if I turn off or remove the extension (and happens immediately if I turn the extension on again). Any ideas on what it's supposed to say or how to stop it from happening? Thanks!

Hi Opto,

This is still a great extension and I can't live without it. Thanks for your work to keep it going despite Thunderbird's best efforts to destroy its extension ecosystem.

When I put the Expression Search search box in the Mail Toolbar, the Quick Filter Bar below it doesn't auto-hide when no search is being done.

Setup: Options, Move Expression Search To: Mail Toolbar
Action: After a search, end it (by pressing Esc a few times)
Expected behavior: The Quick Filter Bar, under the search box, with the Filter messages by buttons (Sender, Recipients, ...), disappears
Actual behavior: That bar becomes empty, but it stays where it is, taking up useless space. In the menu, View... Toolbars, the Quick Filter Bar has a checkmark, and clicking that doesn't remove the bar (or the checkmark) - it seems the bar is locked.

System: Thunderbird 91.5.0 on macOS 12.1 (on an Apple M1 processor), Expression Search - NG 3.1

Remarkably, I had the same problem 7 years ago with the then-current versions of Mac OS X, Thunderbird and Expression Search. It was resolved by the author - perhaps the change made then can be of some help in solving this?

TB 78

when I trying to find for mails by attachment type - there is no result

file:pps - does not give back anything

I'm from Japan, and I found I cannot donate to the developer through the PayPal link. It said donating from Japan to the developer's country is not supported. If the developer could provide other ways to donate, I'm quite happy to do it.

Even though I'm still using TB 68 and haven't moved to TB78, I'd like to donate because now I'm ridiculously happy to see here is a hero maintaining the extension...

Hello, and thanks a lot for the work 👏

I can't disable the tooltip dialog 🤷‍♂️
There's no option in the add-on menu in Thunderbird so I can't see how to do this.

It's a bit annoying as this tooltip appears each time.

I succeed to disable it thanks to this configuration item

But it's not realy user friendly :)

Thanks you

Hi:

The original Quick Filter does not "find" emails by First and Last names. It only finds emails with a match in the actual email address. This add-on does not seem to correct that. When I examine the source of an email, I see that the From field only has the email address. The To field has the email AND the names. I think this might be the cause.

In any event, hope this can be fixed/added. It is frustrating to remember that typing a name hoping to find hits, only finds emails where the name is in the recipient and not the sender.

Thanks

Have been using this for over a year now, but a couple of weeks ago it just stopped working.
I have it set so that if no pattern is typed, it reverts to the normal Thunderbird search.

Now you type and nothing happens. You hit return and still nothing happens. The Thunderbird From/To/Subject options don't pop up and no change happens in the list of messages shown.

I disable Expression-Search, restart TB and the TB search works. I Re-Enable it and restart TB, again nothing happens when I type, whether I just type a string or a pattern.

My TB version at this point is 102.2.2, and my Expression Search is 3.4.3

I removed the add-on and reloaded it, same.
I uninstalled TB and re-installed (but did not clean up profiles or anything like that) - same result.

When I type "b:B137" in the search field to find all messages containing B137 in the message body I get some results that do not include that string and messages that do contain that string are not included in the results.

I use:

• Thunderbird 91.3.2
• Expression Sear - NG 3.1 update November 22nd, 2021

I understand Expression Search 3.1 is not yet updated to fully support TB91.3.2, but in the description it is noted that the search works already.

So I hope my report helps point out a bug and further improve Expression Search.

Please let me know if I can help by providing more information on this bug/observation.

Thank you for this awesome Add-On, though!
I will try and get my boss to make a donation.

The location of the Expression Search tools is fixed in the Quick Search toolbar. The setting for its location has no effect: the tools don't move to the Mail toolbar, the Menu bar or the Tab bar.

EDIT: it seems the extension is also not doing anything. When I type search terms, no filter is applied to the displayed mails. (Further edit: it does activate Global search if you hit Shift+Enter after typing the search terms. But it doesn't filter at all.)

This is v3.4.2 in Thunderbird v102.2.0 on macOS 12.5.1.

My settings:

This is more of a question than a bug report, but I didn't find another option to address this, sorry.
When I click on a folder with subfolders, I want to have the whole tree searched. How is this possible?
If I click on "Local folders" or on the header of an IMAP account, the search box disappears and I can't search. How do I search in a complete mailbox?

The help window, which pops up in the lower right corner when klicking in the search field, is nearly unreadable in dark mode:

Frank

Hi
Right now it does not seem to work with 91.9.0. I see a spinning "processing symbol" I guess that's part of the search but it just spins and that's it. No search results even after a longer time. This symbol is an indicator for an ongoing index'ing?

Hi,
Locale date format is accepted for date: , d: => d:15/04/2021 (french locale) works perfectly
Unfortunately, it is not for before: , after: => after:15/04/2021 does not (but after:2021/04/15 is fine)

Maybe it has something to do with lines 674 and 683 in ExpressionSearchFilter.js , seeming to handle dates differently ?

674:
else if (e.tok == 'date') attr = { type:nsMsgSearchAttrib.Custom, customId: 'expressionsearch#dateMatch' };

vs 683:
else if (e.tok == 'before' || e.tok == 'after') attr = nsMsgSearchAttrib.Date;

Edit: I found a little time to dig a tiny little bit deeper.
The magic seems to be done in the definition of dateMatch, line 180 of same file.
There should be a way to define a dateGreaterThan and a dateLessThan inspired from dateMatch.
So line 683 above could become (if I somehow got the logic) :
else if (e.tok == 'before') attr = { type:nsMsgSearchAttrib.Custom, customId: 'expressionsearch#dateLessThan' };
else if (e.tok == 'after') attr = { type:nsMsgSearchAttrib.Custom, customId: 'expressionsearch#dateGreaterThan' };

If needed I ca help to translate to Slovak language. Sorry for using issues for this but I could not find any other was to contact you.

I can't find the source code.

If I enter a simple search (s:tax) in a folder where no messages match, TB prompts to search all folders and I reply yes, the other folders aren't searched.

If I enter the search and enter Ctrl-Enter the other folders aren't searched.

Thunderbird allows users to define virtual search folders based on search criteria and folders to be searched.

When I click on "Select All" for the folders to be searched, I get the following exception:

Caught Exception ReferenceError: fixIterator is not defined
changeAllFolder@chrome://expressionsearch/content/es.js:1396:28
oncommand@chrome://messenger/content/virtualFolderListEdit.xhtml:1:24
chooseFoldersToSearch@chrome://messenger/content/virtualFolderProperties.js:326:10
oncommand@chrome://messenger/content/virtualFolderProperties.xhtml:1:1
editVirtualFolder@chrome://messenger/content/folderPane.js:3366:12
editFolder@chrome://messenger/content/folderPane.js:3038:12
oncommand@chrome://messenger/content/messenger.xhtml:1:23

A similar error occurs when I select "Current & Descendants" for the click change and then select a folder:

Caught Exception ReferenceError: fixIterator is not defined
changeSubFolder@chrome://expressionsearch/content/es.js:1382:25
initFunctionHook4VirtualFolder/<@chrome://expressionsearch/content/es.js:1371:32
aspect@chrome://expressionsearch/content/aop.js:93:25
onClick@chrome://messenger/content/virtualFolderListEdit.js:100:10
onclick@chrome://messenger/content/virtualFolderListEdit.xhtml:1:16
chooseFoldersToSearch@chrome://messenger/content/virtualFolderProperties.js:326:10
oncommand@chrome://messenger/content/virtualFolderProperties.xhtml:1:1
editVirtualFolder@chrome://messenger/content/folderPane.js:3366:12
editFolder@chrome://messenger/content/folderPane.js:3038:12
oncommand@chrome://messenger/content/messenger.xhtml:1:23

TB Version: 78.8.1
Addon Version: 2.9

To begin with: thaaaaanks a lot for the resurrection of the most useful Thunderbird extension !!!
No single difficulty while installing, I restarted just in case, and it works wonderfully again, like in the good old times !!

Just 2 little issues for now, absolutely not important, but I suppose it's the aim of this place to let users tell you about anything they may notice.

First one: (second one -> new issue)
While typing an expression-search (ex: f:martin), the tooltip appears, but the blue line isn't clicable any more.
I think I remember it used to open a help-window (or a help page in the browser or something like that).
This was very useful at the beginning to learn better search possibilities than just "from:foo" ou "to:bar"
And it sometimes still is, later, for specific searches which don't occur every day.

Once again, thanks a lot.

Hi,

I love this extension's functionality, but these essential permissions "Full access to Thunderbird and computer" do not sound very secure and expect a lot of trust. Are those permissions really needed? Please clarify.

Just new to Expression-Search-NG.
Tried to search for a chapter reference number mentioned in some email with the expression "b:5.9". But the mail has not been found.
What did I do wrong?

The extension only searches the current folder. Pressing enter again as the tooltip suggests for a global search does nothing.

Expression-Search-NG 3.1
Thunderbird 91.10.0
Windows 10 Professional 64 bit

Hi,

No idea if this is specific to Expression-Search-NG or if it is bound to Thunderbird globally :
when starting a search, "Search in progress"(*) appears at the left of the lower info bar.

-> This text keeps showing after the search result is displayed.
This is sometimes confusing for long searches (ex. body full text search in big folders) -> is it really still searching? Or is the result set already complete? Should I wait a little more?

I share this notice here just for the case it would just be a matter of calling some API "hide_caption()" function or so. But it's actually no big affair, if it's more complex than that, then it's not a problem to let it shown, as long as the search works ;-)

(*) I don't know the exact English label, I actually get "Recherche en cours" in French

A user found that when using FiltaQuilla's subject regex ( it's id is [email protected]#subjectRegex) the edit boxes wouldn't fill - I could reproduce it once when installing Expression Search NG once. Didn't reproduce it after removing and reinstalling. But in all cases, the following error is thrown:

es-ng-error.log

The error is caused by an invalid parameter for custom search terms (length) , when calling customTerm.getAvailableOperators() while accessing the valueIds() getter.
https://searchfox.org/comm-central/source/mailnews/search/content/searchWidgets.js#627

You can see that the ExpressionNG follows the pattern that is being used in filters.jsm (which still contains the length parameter)
https://searchfox.org/comm-central/search?q=getAvailableOperators

The last time getAvailableOperators would have worked with the length parameter is Thunderbird 68 - it was removed in Thunderbird 78 going forward.

Hi,

I have installed ExpressionSearchNG_3.4.zip (Thunderbird v102.0.2 on MacOS) and I have noticed that whilst the Click2Search Setting (Ctrl+RightMouse click) still works for the Date and From columns, it no longer works on the Subject column.

Could this please be fixed or am I doing something wrong?

Thanks.

Thunderbird version: 78.14

When setting search to is:ImapDeleted no mails appear, when setting to is:-ImapDeleted all emails are present, including the ones that are pending for removal.

Hi opto,

just installed 2.4 beta in TB 78.7.1 (64 bits)
I got the search Area (with tips text in bottom s,to,cc) bug no searchs are performed when entering any text.
Normal filter however still function.

78.9.0 (64-bit), Mac OS 10.15.7

The add-on is installed, I restarted thunderbird. When I click on a subject it correctly put it in the search bar (e.g. simple:test) or if I type something into the box (e.g. f: David) the pop tooltip window comes up, like its going to search... but the search doesn't actually happen.

Installing the extension does not change the search box.
Typing from:xxx will lead to a search on the expression "from:xxx" instead of a search on senders xxx.

Thunderbird 91.2.1 (64-bit)
MacOS BigSur 11.6 (20G165)

When you switch from one folder to another, the search expression is cleared. Another extension (TotalQuickFilter) features a Sticky button, which keeps and activates the search expression, when changing folders.

Since Expression Search - NG works without (additional) buttons, I could imagine that capitalized keywords could keep the search active, e.g.
F:foo t:bar
becomes
F:foo
after switching to a different folder (Note, the capitalized F: is kept, whereas t: is deleted), but there might be a better approach!

Would it be possible to implement such a feature?

this warning pops up on every start (even after several restarts):

Please make compatible with TB 102.
Release candidate 1 (RC1) is available at https://archive.mozilla.org/pub/thunderbird/candidates/102.0-candidates/build1/