Giter Club home page Giter Club logo

Comments (7)

Borengar avatar Borengar commented on August 31, 2024

Side effect of the fix in #51. Because the stats_get_prediction stays in finished state forever now every game start after the first one will be slower.
Gonna try to get a fix out soon ™️

from totsugeki.

optix2000 avatar optix2000 commented on August 31, 2024

Thanks for the report and fix!

from totsugeki.

fefo-dev avatar fefo-dev commented on August 31, 2024

Had a short test session and the PR worked, closing and opening the game again didn't reproduced the issue.

After a few games I had a network error - training in lobby, quit to floor menu and tried to reenter > disconnect - likely unrelated to 🐬 but here are the steps for further testing.
This network error threw me back to start menu (normal behaviour sadly). Entered the main menu (still disconnected, normal) and then went to Network to trigger a reconnect. This reconnect however was a slow one, with Totsugeki window behaving just like the reported cases.
Does it pass through different steps from start? I clearly remember reconnecting from there with speedups in effect.

from totsugeki.

optix2000 avatar optix2000 commented on August 31, 2024

So I just did some tests with R-Codes with #57. This works with viewing R-Codes in the park or tower, but doesn't work if you view multiple R-Codes through Rankings since there's no /tus/read call to reset it.

I'm thinking it might be better to just do some heuristics.

  • If all expected calls are complete, reset.
  • If a call that was complete gets called again, reset and clear all the queues.

This should in theory cover everything.

from totsugeki.

Borengar avatar Borengar commented on August 31, 2024

Damn it 😆 I only tried tower and replays and loading multiple r-codes worked there.
I'm gonna take another look at it and see if I can solve it your way. Using those conditions to reset sounds a lot better than using random requests that come after the stats ones.

from totsugeki.

optix2000 avatar optix2000 commented on August 31, 2024

🙏 https://github.com/optix2000/totsugeki/releases/tag/v1.5.0

from totsugeki.

optix2000 avatar optix2000 commented on August 31, 2024

Probably fixed now with #57 and #58.

from totsugeki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.