Giter Club home page Giter Club logo

react-oui-icons's People

Contributors

acacia-m-pappas-zz avatar angushtlam avatar ayeshakmaz avatar cristianparcu-epi avatar davemn avatar daverau-optimizely avatar elepert avatar inakiaranzadi-optimizely avatar jordangarcia avatar pauloptimizely avatar quarklemotion avatar spham1412 avatar zleach avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

react-oui-icons's Issues

Module build includes react in the distributed code

Currently, the react-oui-icons build process includes a copy of development react, production react, and prop-types within the code that is built for the NPM module. This is not ideal as the application using react-oui-icons should be responsible for including the appropriate versions of these libraries.

Fix PM icon so fill prop works

  1. Convert PM icon strokes to outlines
  2. Figure out why when I update the svg inside /assets/svgs it doesn't update the yarn storybook icon.

Clarify steps for adding icons

Hey @jamesopti, I know it's been a while since we last looked at this together but I am confused when working in this repo with these two issues:

  1. Do we still require yarn build (which runs npm run babel && gulp svg:combined)? If so, should we we incorporate this into a single yarn icons command?

  2. Which icon folder is the source of truth now?
    /assets/svgs/*.svg (used in yarn svgson)
    or
    /src/Icon/icons/*.svg

React Icons 3.0: Simplify

Todo

  • Simplify build steps so SVGs can be used directly with transparency effects and other visuals that might not fit within the rigid svg -> json structure
  • Remove svgson from build step
  • Create build script that generates React components for each SVG
  • Update documentation so adding icons is as easy as: 1) add icon, verify in storybook, release
  • Release 3.0 icons update and present at FECoP

Questions

  • How do we handle 16 and 24px versions
  • How do we handle stroked icons

add data attr for mappin

Since root-id attr have been remove from react, we need to add a data attr to map where are the React components in the Optimizely app while transitioning to React.

missing key on iteration

The icons have an error caused by the iteration of the generator of shapes on the construction of the SVG.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.