optimizely / php-sdk Goto Github PK

Hi there 🙋‍♂

Tests seems to fail on PHP 7.4, 7.3 still fine though.

Another problem that I don't know is that if this package will upgrade its dependencies like Monolog, because I'm writing a wrapper/integration with Laravel for one of my projects so it requires monolog 2.x from Laravel and so it has dependencies conflicts (specially with monolog)

Hey there,

do we really need to fix monolog/monolog to a specific version? As of right now the sdk requires version 1.21.0 and I would be surprised if something like ^1.21.0 doesn't work as well.

Best,
Daniel

Hi guys,

We're using the Optimizely PHP SDK at Patientco and it looks like we ran into an issue the other day.

Some quick background:
We've been running the Optimizely SDK for a few months now with no problems. This afternoon we rolled out another PHP package via Composer that required Guzzle 5.3 and we started noticing some PHP Fatal Errors coming from the Optimizely package. It looks like the versioning in your composer.json allow it to use either Guzzle 5.3 or 6.2, but the SDK isn't actually compatible with 5.3 because it calls a function on the \GuzzleHttp\Client class that only exists in 6.2.

The error:
PHP message: PHP Fatal error: Call to undefined method GuzzleHttp\Client::request() in [application path]/vendor/optimizely/optimizely-sdk/src/Optimizely/Event/Dispatcher/DefaultEventDispatcher.php on line 53

We're going to try to roll the other package up to 6.2 as a workaround in the meantime, but if you could take a look that would be great. For reference, we are currently on Guzzle v5.3.1 and Optimizely v1.3.0. Thanks!

The bug reported 🐛

There is a typo in phpdocs here:

https://github.com/optimizely/php-sdk/blame/master/src/Optimizely/UserProfile/UserProfileServiceInterface.php#L26

Because there is no class with name userProfile.
Seems like intention was to specify UserProfile or array instead.

Background

In some case insensitive file systems, like MacOS APFS (default). It's impossible to have userProfile.php and UserProfile.php in same directory. Meanwhile in case sensitive file systems it's possible.

In my use case specifying return type hint as userProfile (by sdk) is causing issues when trying to add ignore configuration to ignoreErrors in phpstan-baseline.neon. During the execution of phpstan on each filesystem, the error list is different - because of case insensitivity and type specified in phpdocs.

Description

There are (at least) 2 remaining deprecated definitions of dynamic properties, in OptimizelyConfigService and CustomAttributeConditionEvaluator.

All properties (at least outside of the tests) should use explicit property definition.

Benefits

Get rid of deprecation infos in runtime.

$notification_callback is documented as a string, but it should be callable. This causes problems for people using static analyzers (such as https://github.com/phan/phan) that try to enforce this.

Optimizely::__construct() allows us to pass a logger that will be used to log any errors detected by the SDK.

That's great but for some strange reason the constructor overrides the logger with it's own DefaultLogger whenever a validation/connection error occurs; making the custom logger completely useless.

To make matters worse, the DefaultLogger uses the standard php://output stream to send it's messages, causing every site to leak error messages to it's users whenever a connection issue occurs (e.g. the outage last week).

composer unable to pickup and install php-sdk due to the error below.

First Attempt:

➜ registration git:(develop) ✗ composer require optimizely/optimizely-sdk:1.5.0
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- The requested package optimizely/optimizely-sdk could not be found in any version, there may be a typo in the package name.

Potential causes:

• A typo in the package name
• The package is not available in a stable-enough version according to your minimum-stability setting
  see https://getcomposer.org/doc/04-schema.md#minimum-stability for more details.

Read https://getcomposer.org/doc/articles/troubleshooting.md for further common problems.

Installation failed, reverting ./composer.json to its original content.

Second Attempt:
➜ registration git:(develop) ✗ composer require optimizely/optimizely-sdk

[InvalidArgumentException]
Could not find package optimizely/optimizely-sdk at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability

require [--dev] [--prefer-source] [--prefer-dist] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] []...

Getting a Deprecated warning on php 8.2.

Deprecated: Creation of dynamic property Optimizely\ProjectConfigManager\HTTPProjectConfigManager::$isDatafileAccessTokenValid is deprecated in /vendor/optimizely/optimizely-sdk/src/Optimizely/ProjectConfigManager/HTTPProjectConfigManager.php on line 97