Add Flexible Voting to Governor about openzeppelin-contracts HOT 4 OPEN

Hello, Ben from ScopeLift here 👋

Thanks, @rsolari, for suggesting this and notifying me that you had. Unsurprisingly, we are in favor of this be included in OZ. We see growing interest in Flexible Voting and the kinds of integrations it enables. I just wanted to add that we already have a PR upgrading the extension to work with OZ v5. We would be more than happy to migrate this to a PR against the main contracts repo and to work with the OZ team to integrate any feedback they would have to get it where it needs to be in order to be merged. Thanks in advance for the consideration!

from openzeppelin-contracts.

Hey, thanks @rsolari for putting everything together, and also thanks @apbendi for sharing your input here.

After reviewing ScopeLift's implementation, it seems to rely mostly on GovernorCountingFractional. In my opinion that'd be already a good first step. Would you say it unblock the use cases you're looking for?

I added the 5.x milestone given we already have work committed for the upcoming months and 5.1. Ideally, we'd take ScopeLift's implementation (tysm though!) but, of course it requires time for a review of both @Amxx and me, aside from some time to release.

from openzeppelin-contracts.

Yes, GovernorCountingFractional would unlock the use cases I have in mind!

from openzeppelin-contracts.

For the record, this question came to the forum asking for the effect of delegations when depositing to a liquidity pool.

from openzeppelin-contracts.