openworksgroup / badge-it-gadget-lite Goto Github PK

Hi

In get-my-badges.php there is another warning that briefly displays a warning:

$badge = str_rot13($_GET[id]);

should read

$badge = str_rot13($_GET['id']);

line 52 contains the same error (and that one seems to cause the javascript error i also reported.

regards
wvd_vegt

Hi

When i try to click the badge link presented after issuing a badge i get a

Javascript is required to get your badge. Please enable it in your preferences.

error in all three major browsers (IE9/FireFox/Chrome).

Also (and maybe related) the link: Click here to get your badge! does not do anything.

regards
wvd_vegt

Hi

The index.php script gives quite some warnings that make it unsable when testing.

I changes the following lines to supress these warnings:

1. line 40, inserted:
   $bf = array();

2. line 45 rewrote as:
   if (array_key_exists('success', $bf)) {

3. line 49 rewrote as:
   if (array_key_exists('errors',$bf)) {

4. line 63 rewrote as:
   if (array_key_exists('posted_form_data',$bf) && $i == $bf['posted_form_data']['badgeId']) {

5. line 75, 76, 77 rewrote all three like:

   Recipient Name:*

The basic warnings where all about non existing keys but are shown in the input areas when certain warning levels are turned on in php.

Lastly in the gadget-settings.php I had to prepend a '/' t the start the start of "badge-it-gadget-lite" based paths ($root_path and $json_dir). This was neccesary when running on Windows/IIS where $_SERVER['DOCUMENT_ROOT'] does not end with a trailing slash.

Ideally these two variables should be set with a little code determining if a slash is or is not present.

But thanks for publishing the code it helps tackeling the openbadges api.

regards
wvd_vegt

The following two items could be added to the "In Action" section of the readme:

http://mars.webmaker.org/Unit1/
http://mars.webmaker.org/Unit2/

as referenced from:
https://ben.makes.org/thimble/marswebmakerorg-teaching-kit