openweave / cirque Goto Github PK

User can pip3 install cirque package, and then use binary to initiate cirque-service, and use cirque-cli to orchestrate devices in virtual home. User can also run command to setup all example resources.

While using cirque I ran into some warnings concerning process management:

/usr/lib/python3.8/subprocess.py:942: ResourceWarning: subprocess 28203 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/lib/python3.8/subprocess.py:942: ResourceWarning: subprocess 28202 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
cirque/connectivity/socatpipepair.py:48: ResourceWarning: unclosed file <_io.BufferedReader name=3>
  self.socat = None
ResourceWarning: Enable tracemalloc to get the object allocation traceback

Following changes would fix it. Feel free to use them as you feel fit:

diff --git a/cirque/connectivity/socatpipepair.py b/cirque/connectivity/socatpipepair.py
index 2b64149..c3c2c38 100644
--- a/cirque/connectivity/socatpipepair.py
+++ b/cirque/connectivity/socatpipepair.py
@@ -45,6 +45,8 @@ class SocatPipePair:
     def close(self):
         if self.socat is not None:
             self.socat.terminate()
+            self.socat.wait()
+            self.socat.stderr.close()
         self.socat = None

     def __del__(self):
diff --git a/cirque/connectivity/threadsimpipe.py b/cirque/connectivity/threadsimpipe.py
index 02de636..6ad360f 100644
--- a/cirque/connectivity/threadsimpipe.py
+++ b/cirque/connectivity/threadsimpipe.py
@@ -64,6 +64,7 @@ class ThreadSimPipe:
             self.radio_fd = None
         if self.radio_process is not None:
             self.radio_process.terminate()
+            self.radio_process.wait()
             self.radio_process = None
         if self._socat_pipe is not None:
             self._socat_pipe.close()

Thanks and regards

cirique-cli would act as the client, and can post several requests to cirque service and orchestrate virtual home topology

for example, create-home "home name", which can create home request to cirque service,
start "docker node name", which can bring up particuler docker
list "docker node name", which can list the meta data about this node, for example, name, ip address
exec "cmd", which can execute the command,
destroy "home name", which can tear down the home.

Currently, cirque always download openthread's master code, which is not stable since change in openthread will break cirque.

There are two ways that can make this better,

1. Use a fixed openthread commit id and update it regularly,
2. Allow user specify the path of openthread and use it here

docker port forwarding(mapping) enables the feature for user to be able to access service in docker container remotely. the feature will redirect traffic that coming to a specific port number on the host machine to a mapped port number which owns by a service inside docker container