The library does not work with the last version of grpcio (1.18.0)

Hi, we've been using grpcext.intercept_server() UnaryServerInterceptor and inspecting the server's return code like this:

def intercept_unary(self, request, servicer_context, server_info, handler):
    try:
      handler(request, servicer_context)
    except:
      code = servicer_context._state.code
      ...

We know this is not great: technically _state is private, but the ServicerContext offers no other public API for getting the code out of it.

The problem comes when we ALSO try to use open_tracing_server_interceptor(). When we do that, the servicer_context is replaced with an _OpenTracingServicerContext. And _OpenTracingServicerContext does not expose _state, so the above code breaks.

Yes, we know it's our fault for relying on the private _state field. But would it be possible to request a way to read the code/details from within a UnaryServerInterceptor, that would work whether or not we're using open_tracing_server_interceptor()?

We do not use opentracing yet, but we do use the wrapper for unary and streaming server interceptors.

The new grpcio lib has support for server interceptor, but we could not get it to do things with the response.

We ended up using grpcext from this lib. Is it possible to make it into a separate library?

Having CI going would be good here. I'll look into it.

My builds halt at

[   30s] + /usr/bin/python3 setup.py test
[   31s] running pytest
[   31s] running egg_info
[   31s] writing grpcio_opentracing.egg-info/PKG-INFO
[   31s] writing dependency_links to grpcio_opentracing.egg-info/dependency_links.txt
[   31s] writing requirements to grpcio_opentracing.egg-info/requires.txt
[   31s] writing top-level names to grpcio_opentracing.egg-info/top_level.txt
[   31s] reading manifest file 'grpcio_opentracing.egg-info/SOURCES.txt'
[   31s] writing manifest file 'grpcio_opentracing.egg-info/SOURCES.txt'
[   31s] running build_ext
[   31s] ============================= test session starts ==============================
[   31s] platform linux -- Python 3.8.6, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
[   31s] rootdir: /home/abuild/rpmbuild/BUILD/python-grpc-1.1.4
[   31s] collected 43 items

Build project at https://build.opensuse.org/package/show/home:jayvdb:opentracing/python-grpcio-opentracing , where full logs can be obtained for the builds.

The only obvious difference is Python 3.8 instead of the 3.6 used locally here in CI.

grpc channel is usually used with with statement like here -> https://github.com/grpc/grpc/blob/master/examples/python/helloworld/greeter_client_with_options.py#L31

but...

import opentracing
from grpc_opentracing import open_tracing_client_interceptor
from grpc_opentracing.grpcext import intercept_channel
from grpc import insecure_channel

ic = open_tracing_client_interceptor(opentracing.global_tracer())
with intercept_channel(insecure_channel("localhost:5000"), ic) as ch:
  pass  # blabla

Traceback (most recent call last):
  File "testwith.py", line 7, in <module>
    with intercept_channel(insecure_channel("localhost:5000"), ic) as ch:
AttributeError: __enter__

This repo needs a license file.

Hi, grpc/grpc#19299 added a handy wait_for_termination method to the grpc.Server interface.
It would be cool to implement this in _InterceptorServer and pass through to the underlying server.
...
Though looking at it, I think #14 will resolve this since it removes the wrapped server entirely. Is there an ETA on that PR at all?

I have installed the requirements from examples/requirements.txt and when I am trying the trivial example, it's failing with the following error
Traceback (most recent call last): File "trivial_server.py", line 13, in <module> import command_line_pb2 File "/Users/mahendra/python-grpc/examples/trivial/command_line_pb2.py", line 6, in <module> from google.protobuf import descriptor as _descriptor ModuleNotFoundError: No module named 'google'

To resolve this error I had to install protobuf. It will be better if we can add it to our requirements file.
Thanks

My server-side tracing is working well, however testing a client-side interceptor fails immediately with this error:

Traceback (most recent call last):
  File "client.py", line 29, in <module>
    channel = intercept_channel(channel, interceptor)
  File "/home/ray/.virtualenvs/grpc-GRTZPqPV/lib/python3.6/site-packages/grpc_opentracing/grpcext/__init__.py", line 95, in intercept_channel
    return _interceptor.intercept_channel(channel, *interceptors)
  File "/home/ray/.virtualenvs/grpc-GRTZPqPV/lib/python3.6/site-packages/grpc_opentracing/grpcext/_interceptor.py", line 216, in intercept_channel
    result = _InterceptorChannel(result, interceptor)
TypeError: Can't instantiate abstract class _InterceptorChannel with abstract methods close

This is the code:

import grpc
import yaml
from jaeger_client import Config
from grpc_opentracing import open_tracing_client_interceptor
from grpc_opentracing.grpcext import intercept_channel
from calculator import CalculatorStub

SERVICE = "calculator-client"

with open("config.yaml") as file:
    config = yaml.load(file)


def init_tracer(service_name=SERVICE):
    tracer_config = Config(config=config["jaeger"],
                           service_name=service_name,
                           validate=True)
    tracer = tracer_config.initialize_tracer()
    return tracer


tracer = init_tracer()
interceptor = open_tracing_client_interceptor(tracer, log_payloads=True)
channel = grpc.insecure_channel("localhost:50051")
channel = intercept_channel(channel, interceptor)
client = CalculatorStub(channel)

This is my config:

jaeger:
  sampler:
    type: const
    param: 1
  local_agent:
    reporting_host: 127.0.0.1
    reporting_port: 5775
  logging: true

Python 3.6.5, opentracing==1.3.0, grpcio-opentracing==1.1.1

Thanks

gRPC python now support interceptors, link , any plan to support it?

In https://github.com/opentracing-contrib/python-grpc#integrating-with-other-spans
you should pass CustomActiveSpanSource instance but not the class directly, or you should set the get_active_span method as a classmethod.

Can we please add support for wait_for_ready https://github.com/grpc/grpc/blob/75a3e1bb4581c36779600909e07557d96c59e911/examples/python/wait_for_ready/wait_for_ready_example.py#L61

error:

TypeError: __call__() got an unexpected keyword argument 'wait_for_ready';

My organization has been using a forked version of grpcio-opentracing to add tracing to one of our projects and it has been great! Thanks for sharing the code, @rnburn.

However, we'd like to propose some upstream changes (namely support for grpcio >1.80.0), but it looks like this repo isn't actively maintained. I just wanted to reach out to @rnburn and @carlosalberto before opening a PR to get a better idea of who has ownership over this project. If you need help with maintenance, I'd love to help keep things up to date!

cc @austinlparker @iredelmeier - Apologies for the random tag, but it looks like you might be admins of this org?

When I use the python-grpc module on a server, the only way I can access the active span in the code is using the RPC context (that includes the span). That's because the RPC context is the only place that keeps track of the scope manager and the current active span. However, if I'm not mistaken, it's a pretty common pattern that the general opentracing module would be aligned with the tracing activity that the framework-specific module is generating.

why?

1. this would enable me to access the active span anywhere my the code by calling opentracing.tracer.active_span without being required to pass the context to every function I call from the RPC.
2. that would enable me to generate more complex spans activity on top of the activity the python-grpc module generates. (for example, opening and closing spans for child functions of the RPC).
3. that would enable third-party software products that uses or communicates with the opentracing data to be able to do so, by importing opentracing and using it anywhere it wants. (That's actually how I bumped into this issue, my company's agent is accessing the server's tracing data for advanced features)è

how?
#35

I have documented the code, error message in this post. https://stackoverflow.com/questions/64192211/how-to-convert-grpc-serverinterceptor-to-grcp-aio-serverinterceptor