Giter Club home page Giter Club logo

Comments (8)

pavolloffay avatar pavolloffay commented on July 25, 2024 1

This is not an issue, however we should migrate from a deprecated API anyways. I will close this. Feel free to comment if there are more questions.

from java-spring-web.

wcarmon avatar wcarmon commented on July 25, 2024 1

@larchanjo It's only an issue for people that want to use the newest versions of the OpenTracting API.

If people are stuck on older versions, they won't notice.

@pavolloffay That's fine, I was pointing out where this lib might break in the future. (Due to misalignment with the OpenTracing java api)

from java-spring-web.

pavolloffay avatar pavolloffay commented on July 25, 2024 1

It will be done in #116

from java-spring-web.

luramarchanjo avatar luramarchanjo commented on July 25, 2024

@wcarmon I don't understand why this is a issuer?

from java-spring-web.

denisw avatar denisw commented on July 25, 2024

The deprecated ScopeManager methods have been remove from the OpenTracing v0.33 API. This has now thus become an issue because it prevents teams from upgrading Jaeger to v1.0.0, which implements the v0.33 API.

from java-spring-web.

geoand avatar geoand commented on July 25, 2024

I do plan on working on the move to the latest OpenTracing and Jaeger Client versions in the next few weeks.

from java-spring-web.

denisw avatar denisw commented on July 25, 2024

Why is this closed? There are still uses of ScopeManager#activate(Span, boolean) in the codebase, like:

java-spring-web/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/webfilter/TracingOperator.java

Line 73 in 653166f

try (final Scope scope = tracer.scopeManager().activate(span, false)) {
.

from java-spring-web.

luramarchanjo avatar luramarchanjo commented on July 25, 2024

Ok, thank you soo much!

from java-spring-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.