Comments (7)
I think we have a "chicken and egg" problem here, and that's exactly why I opened this ticket:
- You just can't reasonably test such general performance change on your home machine, but it gives you some hint (and I already have it).
- Testing it on a less used server (like @rrzefox) is a bit closer to reality, but not conclusive (and I also asked him to test it).
- Testing on 1 out of 4 "real" servers is still not the same as rolling the release, and still not conclusive - but this is the closest to reality and still a test.
So: when would you be "reasonably confident" with testing? For me that would be comparing real OSMF server as much as it's possible, keeping in mind that it's still not the same as full production deployment. If that's not enough for you, it would mean a "release as a test" kind of situation, which is what I'd like to avoid.
from chef.
I don't really understand what you're asking for, and I don't have any way of evaluating anything other than rolling it out and seeing what happens.
Are you saying that you'd like me to stage the next rollout and do one server at a time so you can see how they compare?
I'm not sure it would tell you much as the servers are all rather different so any change from this would likely be tiny compared to changes caused by different load patterns or hardward capability.
from chef.
Are you saying that you'd like me to stage the next rollout and do one server at a time so you can see how they compare?
Yes, that was my intention.
I'm not sure it would tell you much as the servers are all rather different so any change from this would likely be tiny compared to changes caused by different load patterns or hardward capability.
I thought of before/after comparison - that should tell us something.
from chef.
I thought of before/after comparison - that should tell us something.
Only if we've horribly broken something. Before/after changes since all the tiles are dirty and need re-rendering.
from chef.
I have not thought about making all the tiles dirty. On the other hand visual changes should be subtle and a change on 1 server is still easier than announcing new release and rolling it on all the servers.
I don't expect this patch to break anything. While re-rendering dirty tiles changes overall usage pattern for about a week, you can still observe the worst/best/average performance per (meta)tile. You can also compare it with previous re-rendering pattern on this server.
But if you think this is not worth the effort, I can go with a typical release cycle.
from chef.
I don't expect this patch to break anything. While re-rendering dirty tiles changes overall usage pattern for about a week, you can still observe the worst/best/average performance per (meta)tile. You can also compare it with previous re-rendering pattern on this server.
No you can't! At least, not if you want useful results. The load varies too much. Sure, you might catch if the rendering times have doubled, but if this happens unexpectedly then we've put out a horribly broken release.
But if you think this is not worth the effort, I can go with a typical release cycle.
It's our job to release stylesheets which we're reasonably confident work, including performance. We're not perfect about this - see our patch releases for a history - but pretty good. When we get it wrong, anyone who's put our release into production will need to roll back, or if we've managed to catch and fix it before they do, upgrade to a patch release.
from chef.
This patch is most probably harmless - just increasing performance/decreasing memory usage, so even if we're not sure how much we would gain this way, separate testing is not critical (problems are related to possible loosing of details on rendering).
But it's a good moment to review our testing strategy in case there is a risk of loosing performance (see: gravitystorm/openstreetmap-carto#1287). I guess it will require some kind of cooperation with OSMF server admins anyway.
from chef.
Related Issues (20)
- Tilecache nginx loop possible HOT 10
- New OpenStreetMap Carto release, v5.1.0
- New OpenStreetMap Carto release, v5.2.0
- Updates for geoip databases? HOT 2
- Broken urls on the OWG website feed HOT 1
- *-latest.torrent redirections do not work correctly (not updating to latest torrents) HOT 3
- Generate RSS/Atom feed for .torrent files? HOT 15
- New OpenStreetMap Carto release, v5.3.0 HOT 4
- New OpenStreetMap Carto release, v5.3.1 HOT 1
- Kitchen: local testing HOT 3
- Use tilelog to generate tile logs HOT 4
- RSS feed does not work in all RSS readers HOT 6
- Would you be intressted in a free Teleport Pro account? HOT 1
- New OpenStreetMap Carto release, v5.4.0 HOT 1
- New OpenStreetMap Carto release, v5.5.0
- New OpenStreetMap Carto release, v5.5.1
- New OpenStreetMap Carto release, v5.6.0
- New OpenStreetMap Carto release, v5.6.1
- Install R v4.1.2 and Redis v6 on dev server HOT 4
- New OpenStreetMap Carto release, v5.7.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chef.