openshift / okd-machine-os Goto Github PK

As part of testing I have added several new overlays:

overlay.d/99okd/etc/systemd/system/ovsdb-server.service.d/99-okd-permission-fix.conf
overlay.d/99okd/etc/jef-test

These seem to get processed during the Dockerfile.ci build

'/src/overlay.d/99okd' -> './overrides/rootfs/overlay.d/99okd'
'/src/overlay.d/99okd/etc' -> './overrides/rootfs/overlay.d/99okd/etc'
'/src/overlay.d/99okd/etc/jef-test' -> './overrides/rootfs/overlay.d/99okd/etc/jef-test'
...
'/src/overlay.d/99okd/etc/systemd/system' -> './overrides/rootfs/overlay.d/99okd/etc/systemd/system'
'/src/overlay.d/99okd/etc/systemd/system/ovsdb-server.service.d' -> './overrides/rootfs/overlay.d/99okd/etc/systemd/system/ovsdb-server.service.d'
'/src/overlay.d/99okd/etc/systemd/system/ovsdb-server.service.d/99-okd-permission-fix.conf' -> './overrides/rootfs/overlay.d/99okd/etc/systemd/system/ovsdb-server.service.d/99-okd-permission-fix.conf'
...

but the files are not present in a new cluster build... I was able to delete files though so I know the image build ok...

99-okd-worker-disable-mitigations.yaml is added to fix an issue on AWS m6 virtualized instances (according to commit message), this should not be applied on other machine types such as bare metal.

intel_pstate will be better managed by Node Tuning Operator.

Is there a work around to remove this on the existing OKD cluster? Deleting the machine config results it being recreated by the ClusterVersion.

Can there be a better way to machine specific patches?

Is there any descrition more detail about the build process ？The Build process in README.md is too little to follow.
e.g:
https://coreos.github.io/coreos-assembler/building-fcos/

AIUI current OKD is using machine-os-content as a way to find "the default OS image" - it's making it be a new format image.

I guess actually we could just do that for OCP/RHCOS too, i.e. do a hard cutover and just ship rhel-coreos-8 as a retagging. I'm not opposed to that. But it feels better to make a "clean cut" and have a new image in the new format, and crucially define a better way to find "the default OS image". Which could just be another new tag...like default-operating-system or something.

Anyways the bootstrap phase currently does

MACHINE_CONFIG_OSCONTENT=$(image_for machine-os-content)

and this will eventually break if we do openshift/machine-config-operator#3364

The README includes details on the diff between FCOS and OKD. Let's figure out how to address each of them without having to rebuild FCOS.

At README section the building process links are not working.

See #135 (comment)

Why did you do fa36292 ?

This breaks the basic experience of layering a custom image.