Giter Club home page Giter Club logo

Comments (5)

jcantrill avatar jcantrill commented on June 22, 2024

@ewolinetz My concerns here may be addressed by your refactorings

from elasticsearch-operator.

ewolinetz avatar ewolinetz commented on June 22, 2024

It looks like resources can be overridden still... is that a concern or was it just images?

from elasticsearch-operator.

jcantrill avatar jcantrill commented on June 22, 2024

It looks like resources can be overridden still... is that a concern or was it just images?

It reasonable to me to override resources per individual node types. It is NOT to be able to override images. Allowing override of the image makes it dangerously possible to mix versions that may not be compatible.

from elasticsearch-operator.

jcantrill avatar jcantrill commented on June 22, 2024

@ewolinetz did we address this? can we close

from elasticsearch-operator.

ewolinetz avatar ewolinetz commented on June 22, 2024

https://github.com/openshift/elasticsearch-operator/blob/master/pkg/apis/logging/v1/elasticsearch_types.go#L82-L89

from elasticsearch-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.