Giter Club home page Giter Club logo

Comments (8)

richm avatar richm commented on September 24, 2024 1

I think it is more important to be consistent with what ever other component of openshift is using - we don't want to move to json file log format while every other component is using something else

That being said - we should allow users/admins to globally change the way all openshift components are logged e.g. if there is some sort of log4go configuration file that applies to all components running on a node, or all components in the cluster.

from elasticsearch-operator.

ewolinetz avatar ewolinetz commented on September 24, 2024

Do you have an example output in the JSON format?

from elasticsearch-operator.

ewolinetz avatar ewolinetz commented on September 24, 2024

I think we also need to go through and clean up the output for the operator(s). Looking at the other demos, they only seem to write output when a change is happening. We should not see the same message repeat multiple times in a row.

from elasticsearch-operator.

josefkarasek avatar josefkarasek commented on September 24, 2024

Log format configurable either by --log-format=logfmt|json or LOG_FORMAT envar. logfmt (plaintext) is the default.

Log level configurable either by --log-level=debug|info|warning|warn|error|fatal|panic[1] or LOG_LEVEL envar. info is the default.

Cmd arguments take preference.

[1] https://github.com/sirupsen/logrus/blob/master/logrus.go#L25

from elasticsearch-operator.

richm avatar richm commented on September 24, 2024

How would we dynamically set this? Do we need to add log level to the elasticsearch CR? and add code for it in the operator? We can't oc set env deploy/elasticsearch-operator LOG_LEVEL=debug because OLM will reset it. Do we need a configmap for this?

from elasticsearch-operator.

josefkarasek avatar josefkarasek commented on September 24, 2024

The operator is a stateless application. I don't see any issue with restarting it. It runs in 5 seconds intervals anyways.

from elasticsearch-operator.

jcantrill avatar jcantrill commented on September 24, 2024

Re purposing this issue to move all logging to rely on the logging adapter functions that wrap logrus. The operator currently has 2 log libraries it uses and these should collapse into one where we can configure it as we like.

from elasticsearch-operator.

openshift-bot avatar openshift-bot commented on September 24, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from elasticsearch-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.