Plugin test failure
From git commit 7f68cf5

cargo clean; cargo build; cargo test
...
failures:

---- plugins::openshift_secondary_metadata_parser::plugin::tests::compare_quay_result_fixture_20200220104838 stdout ----
thread 'plugins::openshift_secondary_metadata_parser::plugin::tests::compare_quay_result_fixture_20200220104838' panicked at 'assertion failed: (left == right)

Pulled most recent code: 7f68cf5

cargo clean ; cargo build
error[E0277]: *mut (dyn std::ops::Fn() + 'static) cannot be shared between threads safely
--> graph-builder/src/plugins/github_openshift_secondary_metadata_scraper/plugin.rs:261:80

message is

*mut (dyn std::ops::Fn() + 'static) cannot be shared between threads safely

The API : "/api/upgrades_info/v1/graph" has a parameter named "arch". but there are no docs on swagger doc

https://api.openshift.com/?urls.primaryName=Upgrades%20information%20service#/

The following branches are being fast-forwarded from the current development branch (master) as placeholders for future releases. No merging is allowed into these release branches until they are unfrozen for production release.

• release-4.12
• release-4.13

For more information, see the branching documentation.

Build on Fedora 30:

Compiling policy-engine v0.1.0 (/home/ayoung/devel/cincinnati/policy-engine)
Finished dev [unoptimized + debuginfo] target(s) in 4m 27s
Running target/debug/policy-engine --address 0.0.0.0
error: Found argument '--address' which wasn't expected, or isn't valid in this context

Could this be an issue with the version of Rust used to build

Steps to repro:

git clone....
cd cincinnati/
export CINCINNATI_REGISTRY="https://quay.io"
cargo run --package graph-builder -- --address 0.0.0.0 --registry "${CINCINNATI_REGISTRY}" --repository "${CINCINNATI_REPO}" &
cargo run --package policy-engine -- --address 0.0.0.0

Its the last command that fails. I got that from the README.

$ export CINCINNATI_REPO="redhat/openshift-cincinnati-test-public-manual"
$ export CINCINNATI_REGISTRY="https://quay.io"
$ cargo run --package graph-builder -- --service.address 0.0.0.0 --upstream.registry.url "${CINCINNATI_REGISTRY}" --upstream.registry.repository "${CINCINNATI_REPO}"
Finished dev [unoptimized + debuginfo] target(s) in 0.16s
Running target/debug/graph-builder --service.address 0.0.0.0 --upstream.registry.url 'https://quay.io' --upstream.registry.repository redhat/openshift-cincinnati-test-public-manual
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }

could not open '""'

A spec clarification request to @crawford on https://github.com/openshift/cincinnati/blob/95db15a823b231636c7a3aaeef25b6c22e6c9a8b/docs/design/cincinnati.md#graph-api.

The current implementation in cincinnati is stricter than the design spec, and these are the points that I'd like to have explicitly noted regarding the JSON API of the graph endpoint:

• is version a freeform string or a semver label?
• is a "" allowed as a version value?
• must a version value be unique in the "nodes" array?
• is the payload field required and is an empty-string allowed there?
• is the client supposed to pass additional parameters somehow (e.g. as query parameters)?
• is the edges "empty object for future use" still a thing? (it isn't in example nor in deserializer code)

As a user of the graph, how do I know what channels are available or presented by my Cincinnati service?

Hi,

Our team want to use the api /api/upgrades_info/v1/graph in a frontend app.
but the API not support called by JavaScript from other domain.
Is that possible to support it ?

I think it should be easy to support by add a middleware https://docs.rs/actix-cors/0.5.4/actix_cors/

Then, the frontend developer could use the api with following code

fetch("https://api.openshift.com/api/upgrades_info/v1/graph?channel=fast-4.5")
    .then(res => res.json())
    .then((result)=> console.log(result))

[2019-12-02T13:57:42Z ERROR cincinnati::plugins::internal::cincinnati_graph_fetch] error fetching graph: failed to fetch upstream graph: http://offline.url.test/: error trying to connect: failed to lookup address information: Name or service not known
[2019-12-02T13:57:42Z ERROR policy_engine::graph] Error serving request with parameters '""': failed to fetch upstream graph: http://offline.url.test/: error trying to connect: failed to lookup address information: Name or service not known
[2019-12-02T13:57:42Z ERROR actix_http::response] Internal Server Error: FailedUpstreamFetch("http://offline.url.test/: error trying to connect: failed to lookup address information: Name or service not known")

[2019-12-02T13:57:42Z ERROR policy_engine::graph] Error serving request with parameters '"channel=invalid:channel"': invalid client parameters: channel 'invalid:channel' does not match regex '^[0-9a-z-.]+$'
[2019-12-02T13:57:42Z ERROR policy_engine::graph] Error serving request with parameters '"channel=invalid=channel"': invalid client parameters: channel 'invalid=channel' does not match regex '^[0-9a-z-.]+$'
test graph::tests::webservice_graph_json_response ... ok
[2019-12-02T13:57:42Z ERROR policy_engine::graph] Error serving request with parameters '"channel=':'"': invalid client parameters: channel '':'' does not match regex '^[0-9a-z-.]+$'

Currently, to check the latest OCP version available this is needed:

curl -sH 'Accept: application/json' "https://api.openshift.com/api/upgrades_info/v1/graph?channel=stable-4.4&amd64" | jq -r '.nodes|map(.version)|.[]' | sort -V | tail -1

You need to know the minor version (4.4) and the channel (stable) beforehand.

It would be nice to expose that value in an API endpoint such as https://api.openshift.com/api/latest or https://api.openshift.com/api/stable-4.4/latest or https://api.openshift.com/api/fast-4.4/latest, etc.

I'm not sure if this RFE belongs here but just in case.

As you known, x86_64 and amd64 are same arch.

The API should support x86_64 as arch parameter, it is blocked by regex pattern....
At least add a alias for it :)