Comments (4)
I'm not too sure about this default, it seems the docs specify that the default should be 0 if unspecified (here), This also seems to be the behavior for the ROS parser
from urdf-rs.
I'm not too sure about this default, it seems the docs specify that the default should be 0 if unspecified (here), This also seems to be the behavior for the ROS parser
looking at the docs them selves:
<limit> (required only for revolute and prismatic joint)
An element can contain the following attributes:
lower (optional, defaults to 0)
An attribute specifying the lower joint limit (in radians for revolute joints, in meters for prismatic joints). Omit if joint is continuous.
upper (optional, defaults to 0)
An attribute specifying the upper joint limit (in radians for revolute joints, in meters for prismatic joints). Omit if joint is continuous.
Omit if joint is continuous.
this implies there are instances where ROS assumes there are no limits like on continuous joints. I suppose it makes sense from a safety sense, but its still inconvenient.
Maybe there should be a JointLimit::unlimited()
then?
from urdf-rs.
Yap there are continuous joints, it's a separate type (not revolute), have a look here.
Now someone could make the case that we could exploit Rust's enum system better and make sure JointLimit
is only contained if the joint is of a variant where it makes sense, but that would make serialization / deserialization a fair bit trickier
from urdf-rs.
One option would be to add a method that returns Option<Range>
based on JointType
like this.
Given that it would complicate the parsing code, it would not necessarily be easy to embed the limit in the JointType
. However, it would probably be the most type-safe way to do it.
from urdf-rs.
Related Issues (13)
- `Option` type for optional tags HOT 6
- SDFormat HOT 11
- Improve xacro error HOT 1
- Rust error from {argument} HOT 1
- Sort collision and visual in link
- Inertial Data ignored HOT 1
- Add support for passing arguments to xacro files HOT 1
- write_to_string exports with "Robot" tag instead of "robot" HOT 3
- Bad namespace HOT 3
- [BUG] If <origin> is below <geometry> in a urdf file, then <origin> doesn't load. HOT 7
- Color in material doesn't seem to parse. HOT 8
- Consider moving away from yaserde HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from urdf-rs.