Giter Club home page Giter Club logo

openholidaysapi.data's Issues

OpenHolidays API down?

https://openholidaysapi.org/SchoolHolidays?countryIsoCode=DE&languageIsoCode=DE&validFrom=2024-03-15&validTo=2024-04-15&subdivisionCode=DE-BW should result to Osterferien.
Since the changeover to summer time, the query returns a 'null' value.

Add regional public holidays in France

In France, we have specific holidays for some regions

Alsace-moselle (FR-57)

  • 26 december
  • Good Friday is the Friday before Easter Monday

Also, the overseas territories all have a particular public holiday which is the date of abolition of slavery:

  • Guadeloupe May 27
  • Guyana June 10
  • Martinique May 22
  • Mayotte April 27
  • Reunion December 20
  • Saint-Barthélemy October 9
  • Saint Martin May 27

I saw in the repo that there were files by region for Spain in particular. Is it enough to use the same model to contribute to the repo dedicated to France?

Thanks :)

New public holiday in Latvia

Latvia changed 29 May 2023 to a public holiday because their ice hockey team performed unexpectedly well. Although the date is already passed, it should be reflected in the data set.

Nice to have: addition field to specify the source

In order to allow easy validation, it would be nice if the source was specified:

{
  "id": "94498ba1-28e3-4dcd-b28f-d7aaf4cc56d7",
  "startDate": "2023-01-01",
  "endDate": "2023-01-01",
  "type": "Public",
  ...
  "source": "https://www.bmi.bund.de/DE/themen/verfassung/staatliche-symbole/nationale-feiertage/nationale-feiertage-node.html"
}

Quality assurance missing

It is a problem that the data in this project is not really reliable. There are again several occurences where the holiday end date is before the start date or is over a year later. There are also obvious typos like " D" instead of "DE" as a language code. Most of these Bugs could be automatically detected.

Ideally there would be a GittHub action running for each Commit and Push request that performs some costistency checks.

Mauritius Day

Regional holiday Mauritius Day is missing but is given in the source on page 21

How are Ids built?

I might be interested in adding data for more European countries, like Italy which is missing right now. How are the unique ids being generated? Is this done by scripts or should one generate them manually and check that they are unique? That seems a bit like a hassle...

NL King’s Day in 2025 is day earlier

The public holidays data for Netherlands has the wrong date for King’s Day in 2025.

31349587-ddaa-4fd0-9752-7fc786c25208;NL;2025-04-27;;Public;NL Koningsdag,DE Königstag,EN King’s Day

2025-04-27 happens to fall on a Sunday, which means it's celebrated a day earlier.

https://en.wikipedia.org/wiki/Koningsdag#Changing_of_the_date

if not on a Sunday. If that occurred, which was true for 2014 itself as well, King's Day will again be held on Saturdays preceding the 27th.

https://publicholidays.nl/kings-day/
https://www.koninklijkhuis.nl/onderwerpen/koningsdag (only available in dutch)
https://www.amsterdam.nl/toerisme-vrije-tijd/evenementen/koningsdag-2025/
https://www.kalender-365.nl/feestdagen/koningsdag.html
https://www.iamexpat.nl/expat-info/dutch-holidays

On behalf of my country I'm sorry for these exceptions ;)

DE school holidays

Hi,

For subdivision DE-BY Bavaria, there is a missing floating date for each school year, could you fetch them plz ?

Examples of dates missings :
2020-11-18, 2021-11-17, 2022-11-16, 2023-11-22, 2024-11-20, and so on till 2030

Wrong School holidays data for Slovakia

Hi, don't know if this is the right place to post, but the data for public holidays in Slovakia are not correct.
For example christmas holidays (id: 14886d4b-c0f4-43a7-ade7-da43a2fcf115) are marked as not nationwide although it is.
Basically each school holiday that is in fact nationwide and is marked incorrectly in the API is missing this subdivision: SK-BL (bratislavsky kraj).
How can I help to fix this?
Many thanks:)

Non-statutory holidays

Optionally, non-statutory holidays such as christmas and sylvester would be a nice2have

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.