openfin / excel-api-example Goto Github PK

When I add sheetChanged event to worksheet, it is only working for manually changed cells. But for cells which has formula, even after value changed event is not getting triggered.

In versions above 1.2.0, main.js has a line in it:

fin.desktop.Excel = require('./ExcelApi.js').LegacyApi;

but it seems that ExcelApi.js file is missing in src/. Although version 1.0.1 has it in the root folder of the repo: https://github.com/openfin/excel-api-example/tree/1.0.1

One of our test Excel versions is:

The installation of the addin fails with the following error:

The file format and extension of the file don't match. 
The file could be corrupted or unsafe. 
Unless you trust its source, don't open it. 
Do you want to open it anyway?

Looking at the old VBScript installer, it seems that the 64 bit version is being incorrectly chosen. The logic is this:

if Mid(excel.ProductCode, 21, 1) = "0" then
    addInFile = addInFile & "\OpenFin.ExcelApi-AddIn.xll"
else
    addInFile = addInFile & "\OpenFin.ExcelApi-AddIn64.xll"
end if

I assume it's similar in the EXE installer. However, our excel.ProductCode is {9AC08E99-230B-47e8-9721-4577B7F124EA}, so 64 bit is chosen, even though the Excel is 32 bit.

It would be nice if you gave a link-back on your README.md to ExcelDna, given you use it to make the add-in ...

Not a biggie, but it might be nice ...

The app shows "Excel not connected. Start by launching Excel." When I click "launching Excel" and Excel instance opens, but when I open a workbook and click any cell, the status bar at the bottom changes from "Ready" to "Disconnected from Openfin".

Hi, it seems the current add-in version (commit 4e5c34f) does not work with 64-bit Excel at all. The error is the same as in #10. Tested with both Excel 2016 64-bit and Excel 2013 64-bit.

Preload from app.json will 404