Mix advertised & attr FEC mode? about sai HOT 3 CLOSED

@lguohan - can you comment? Especially the model of processing multiple attributes (individually or summation)

Typically most folks assume RS is higher priority than FC if both are advertised. Is this a safe assumption since RS is newer than FC?

In interpretation #2, instead of re-using an existing enum for the purpose of FEC prioritization (If user wants to set FC > RS), would it be better to create a new enum?

from sai.

I think most folks are more into interpretation #1.

This means that for folks who want control of the "request" bits for AN, there is no attribute. Should we create a new one like SAI_PORT_ATTR_ADVERTISED_FEC_REQUEST_MODE and maybe change existing to SAI_PORT_ATTR_ADVERTISED_FEC_ABILITY_MODE to make it explicit what part of AN process this is controlling

since SAI_PORT_ATTR_ADVERTISED_FEC_MODE == AN ability bits currently

from sai.

I've created PR#640 to address this issue.
#640

I've added the request bit as an explicit parameter to be toggled and added comment about ability bit implicitly set if FEC is advertised.

from sai.