Giter Club home page Giter Club logo

Comments (8)

svrnm avatar svrnm commented on July 3, 2024 1

This discussion links to the official GH documentation about the topic:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

And:

If you do want to trigger a workflow from within a workflow run, you can use a GitHub App installation access token or a personal access token instead of GITHUB_TOKEN to trigger events that require a token.

Using a PAT seems to be a reasonable solution for me.

from opentelemetry.io.

svrnm avatar svrnm commented on July 3, 2024 1

Using a PAT seems to be a reasonable solution for me.

We have one already, and maybe using it consistently will help. Let me raise a PR for that.

from opentelemetry.io.

svrnm avatar svrnm commented on July 3, 2024 1

Reverting the last change, as you did was what I had in mind too. Thanks for doing that and investigating further 🙏

I am worried we are in a position where neither token gives us all the things we need, as it looks like the PAT is not allowed to push to forks. In my research I came across a page that listed solutions to this problem but I closed it so I have to find it once again will keep you posted.

from opentelemetry.io.

svrnm avatar svrnm commented on July 3, 2024

looks like #4345 did not solve it. I tested it with #4349 and now checks were run afterwards.

from opentelemetry.io.

svrnm avatar svrnm commented on July 3, 2024

So the "good" news is that we are not the only ones running in those issues, so there is some info out there that is helpful, but this is a rabbit hole, looks like the checkout action adds additional trouble:

https://github.com/orgs/community/discussions/26220

from opentelemetry.io.

chalin avatar chalin commented on July 3, 2024

@svrnm - we're hitting permission issues now, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/8822774576/job/24221719586:

image

from opentelemetry.io.

svrnm avatar svrnm commented on July 3, 2024

@chalin that's odd because this step was not updated by any of the 2 latest changes:

https://github.com/open-telemetry/opentelemetry.io/blame/adb72161798991fe272251de4f6d9a8bfd8bc799/.github/workflows/pr-actions.yml#L105

from opentelemetry.io.

chalin avatar chalin commented on July 3, 2024

Reverting the last change, as you did was what I had in mind too. Thanks for doing that and investigating further 🙏

from opentelemetry.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.