Giter Club home page Giter Club logo

Comments (9)

L-M-Sherlock avatar L-M-Sherlock commented on June 28, 2024

Bad case 1: very low initial stability

image

image

image

Solution: decrease the lower limit of w[0], w[1], w[2] and w[3] from 0.1 to 0.01.

from srs-benchmark.

L-M-Sherlock avatar L-M-Sherlock commented on June 28, 2024

Bad case 2: very long elapsed days for first reviews

image

image

image

image

image

Solution: filter out reviews with delta_t > 100.

from srs-benchmark.

L-M-Sherlock avatar L-M-Sherlock commented on June 28, 2024

Bad case 3: non-monotonous initial stability

image

image

The user's initial stability of good is lower than the initial stability of hard. And the data is enough.

Solution: don't compare initial stability with each other when the number of reviews is enough.

from srs-benchmark.

Expertium avatar Expertium commented on June 28, 2024

So do you think we should allow S0 to be non-monotonous? I think we shouldn't - users will be confused if, for example, their Easy interval is shorter than their Good interval.

from srs-benchmark.

L-M-Sherlock avatar L-M-Sherlock commented on June 28, 2024

It doesn't affect most users. And it could improve the accuracy of affected users significantly.

from srs-benchmark.

Expertium avatar Expertium commented on June 28, 2024

I think the confusion outweighs any accuracy benefits. @user1823, what do you think?

from srs-benchmark.

user1823 avatar user1823 commented on June 28, 2024

Solution: don't compare initial stability with each other when the number of reviews is enough.

Just like Expertium, I don't think that it is a good idea because interval for Good being less than Hard (or any other pair) would not be acceptable.

I think that in this case, the user has two (or more) different types of cards. So, more accurate parameters can be obtained if the user generates different parameters for different types of cards.

from srs-benchmark.

Expertium avatar Expertium commented on June 28, 2024

Solution: filter out reviews with delta_t > 100.

I agree that this makes sense for Again, Hard and Good, but probably not for Easy. For Easy, the limit should be higher. Perhaps 365 days?

from srs-benchmark.

L-M-Sherlock avatar L-M-Sherlock commented on June 28, 2024

OK. I reverted the solution of bad case 3 and relaxed the filter for bad case 1.

from srs-benchmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.