Giter Club home page Giter Club logo

peekaboo's People

Contributors

akashkdigio avatar ksjmgrkks avatar l2hyunwoo avatar onseok avatar renovate[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

peekaboo's Issues

Jpeg compression quatlity as parameter for rememberImagePickerLauncher

It would be great if together with resize options we can also pass jpeg compression rate to the rememberImagePickerLauncher.
As far as i see currently it's always set to 1.0 in UIImage.toByteArray() function called for picked images before returning on iOS side. And should be as easy to change on android side in resizeImage function of PeekabooImageResizer.

Thanks for the library!

Issue

this doesn't work on android 11 and above

Doesn't work on all devices

Image squeezed into square size on iOS

When picking a non-square image on iOS, it is squeezed/stretched into a square

My code:

val picture = remember { mutableStateOf<ByteArray?>(null) }
val imagePicker =
        rememberImagePickerLauncher(
            selectionMode = SelectionMode.Single,
            scope = scope,
            onResult = { byteArrays ->
              byteArrays.firstOrNull()?.let { picture.value = it }
            },
        )
val pictureValue = picture.value
if (pictureValue != null) {
      Image(
          bitmap = pictureValue.toImageBitmap(),
          contentDescription = "Profile Picture",
          modifier = Modifier.fillMaxSize(),
          contentScale = ContentScale.Fit,
      )
}

Original image:

Cat03

Rendered Image:

Screenshot 2024-01-13 at 1 06 19β€―AM

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

github-actions
.github/workflows/ci_check.yml
  • actions/checkout v4
  • actions/setup-java v4
.github/workflows/iosBuild.yml
  • actions/checkout v4
  • actions/setup-java v4
  • actions/cache v4
  • maxim-lobanov/setup-xcode v1
  • hendrikmuhs/ccache-action v1
  • macos 13
gradle
gradle.properties
settings.gradle.kts
build.gradle.kts
convention-plugins/settings.gradle.kts
convention-plugins/build.gradle.kts
convention-plugins/src/main/kotlin/module.publication.gradle.kts
convention-plugins/src/main/kotlin/root.publication.gradle.kts
gradle/libs.versions.toml
  • org.jetbrains.kotlin:kotlin-test 1.9.21
  • androidx.activity:activity-compose 1.8.2
  • androidx.compose.ui:ui 1.5.11
  • androidx.compose.ui:ui-tooling 1.5.11
  • androidx.compose.ui:ui-tooling-preview 1.5.11
  • androidx.compose.foundation:foundation 1.5.11
  • androidx.compose.material3:material3 1.1.2
  • org.jetbrains.compose.components:components-resources 1.5.11
  • io.github.gradle-nexus.publish-plugin:io.github.gradle-nexus.publish-plugin.gradle.plugin 2.0.0-rc-1
  • androidx.core:core-ktx 1.12.0
  • junit:junit 4.13.2
  • androidx.test.ext:junit 1.1.5
  • androidx.test.espresso:espresso-core 3.5.1
  • androidx.appcompat:appcompat 1.6.1
  • com.google.android.material:material 1.11.0
  • com.google.accompanist:accompanist-permissions 0.32.0
  • androidx.camera:camera-camera2 1.3.1
  • androidx.camera:camera-lifecycle 1.3.1
  • androidx.camera:camera-view 1.3.1
  • androidx.exifinterface:exifinterface 1.3.7
  • com.android.application 8.2.2
  • com.android.library 8.2.2
  • org.jetbrains.kotlin.android 1.9.21
  • org.jetbrains.kotlin.multiplatform 1.9.21
  • org.jetbrains.compose 1.5.11
  • com.diffplug.spotless 6.25.0
peekaboo-camera/build.gradle.kts
peekaboo-image-picker/build.gradle.kts
peekaboo-ui/build.gradle.kts
sample/android/build.gradle.kts
sample/common/build.gradle.kts
gradle-wrapper
gradle/wrapper/gradle-wrapper.properties
  • gradle 8.5

  • Check this box to trigger a request for Renovate to run again on this repository

startRunning should be called from background thread.

When using peekabooCamera on ios side i get following error in logs:

Thread Performance Checker: -[AVCaptureSession startRunning] should be called from background thread. Calling it on the main thread can lead to UI unresponsiveness

But then camera still runs and capture images.

Still would be good to fix the issue. There is a similar problem reported on apple forums with a fix being in wrapping that call like this:

/* starting capture session */
DispatchQueue.global(qos: .background).async {
self.captureSession.startRunning()
}

INSTALL_FAILED_CONFLICTING_PROVIDER

Issue while installing app in phone.
Issue can be reproduce by below steps

  • Try to install the sample app of peekaboo library or implement peekaboo library in your project. And install app in your phone
  • Now try to add peekaboo library in different project or create any sample project. Then install in phone
  • IDE would give an error "The application could not be installed: INSTALL_FAILED_CONFLICTING_PROVIDER" while installing second app.
  • This happens because both app is using same library and library have the same authorities in both project that's causing the conflict issue with provider.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.