onnwards / ped Goto Github PK

Names of persons in the app: hi, Roy Balakrishnan, Irfan Ibrahim, David Li, Charlotte Oliveiro, Bernice Yu, Alex Yeoh.

command used: sort descending

expected: names sorted in alphabetical order, ie hi between David and Irfan.

actual: hi at the top

since features like find are case insensitive, this should be too, which is why this feature is not complete (ie. feature flaw)

UG mentions that

This command only applies to the commands that make changes to the list of contacts, e.g. add, edit, delete, undo etc.

however, for undo to apply to undo:
a second consecutive undo would perform a redo, which does not happen.
the UG is mildly misleading on this.

dark/light mode should be saved on app close/re-open. however, it currently isn't.

this should be saved because a user would not want their UI to default to dark mode every single time they open the app, and have to swap over to light mode every time if they prefer to work in light mode.

therefore the feature is not really complete and is considered a feature flaw.

user keys in (a valid add) add n/hi..., then find n/roy (finding one person), then undo

expected: undo undoes the valid add, and resets the list to show all persons again.

actual: undo undoes the valid add, but does not reset the list to show all persons.

attached video:

2021-04-03 14-44-47.mp4

since the commands that undo applies to: eg. add, edit, delete, all reset the predicate to show all persons in the list, it is reasonable to assume that undo should do so as well.

black bar appears in the app UI sometimes on commands that reduce the list to a smaller one

pure cosmetic, styling problem

for the feature titled Review previous commands,

when user presses up after an invalid command,
expected: invalid command is not saved, and KEYUP reverts user to the last valid command.

actual: the invalid command is saved.

Keying in invalid command

after KEYUP pressed

after KEYUP pressed again

there is also no clarity on this in the UG.

The UG specifies: add n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]…​, and the relevant examples:

• add n/John Doe p/98765432 e/[email protected] a/John street, block 123, #01-01
• add n/Betsy Crowe t/friend e/[email protected] a/Newgate Prison p/1234567 t/criminal

However, these commands do not work.

the mode of contact (m/) that is required is not specified anywhere, except in an example in the app.

Undo result states undo operation successful without mentioning what was undone.

if the user wanted to undo many times, the user would not remember what modification to the list the user performend before the multiple undos.

with a command collect n/ s/"\n"

expected:

Roy Balakrishnan

Irfan Ibrahim

David Li

Alex Yeoh

this makes it even harder to read than in the UI itself.

If the feature was meant to be for easy copying, the UG should mention it. otherwise, the feature is currently incomplete.

Image in UG

Image in App:

when there is nothing to undo, the result of the command undo is cannot undo. user has to guess at the reason why, ie. nothing to undo? or undo failed because something went wrong.

UG mentions:

Start Index < End Index and End Index cannot be larger than the number of contacts in the list.

however, start can be equal to end index for massdelete

top of picture indicates the command that was typed.

presumably because no spacebar between the ### and the words

user typed the command light

expected: nothing happens

actual: light mode activates.

there is no mention of this feature in the UG at all.

through some experimentation, dark is also a feature that is not mentioned.

if it is not mentioned, user is not able to make use of it, and it differs from normal expectations.
it thus causes occasional inconvenience to the user.

there was no mention of the black background in the UI having a special meaning, ie. blacklisting a person turns a user's background black.