ongr-io / currencyexchangebundle Goto Github PK
View Code? Open in Web Editor NEWCurrency exchange calculation bundle
License: MIT License
Currency exchange calculation bundle
License: MIT License
Configuration file exists, but travis is not running.
Currently there is functionality of providing a front-ended currency switches using javascript witchcraft:
https://github.com/ongr-io/CurrencyExchangeBundle/tree/cd2b264f9de87f3bac60d9c66d19f4e2288d61a8/Resources/public/scripts
This functionality is not only non functioning, it is not necessary for the bundle, it should be removed.
Word "default" makes no sense here. This method actually returns the name of the currency to which other currencies are compared, i.e. usually where rate = 1. It could be named getBaseCurrency()
An exception has been thrown during the rendering of a template ("Notice: Array to string conversion") in ONGRCurrencyExchangeBundle:Price:currencyList.html.twig at line 3.
Problem is that PriceExtension::getCurrencyList returns multidimensional array not array of strings.
Remove setters support. This is not needed for custom services, only for our OpenExchangeRatesDriver
. It would be better to add optional config parameter for that.
Config should look like this:
ongr_currency_exchange:
# ...
driver: app.my_currency_driver
Or in case of OpenExchangeRatesDriver
:
ongr_currency_exchange:
# ...
driver: ongr_currency_exchange.open_exchange_driver
open_exchange_rates_id: XXX
We need an option to store currency rates in specified currency which can be different than base.
Currently guzzlehttp/guzzle
is required only when OpenExchangeRatesDriver
is used. It would be nice to eliminate it from required packages. We could add it to suggestions or replace it with plain PHP (why to require 3rd party library for single optional request?).
We should move defaults to config. Leave possibility to set template directly to filter.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.