Did you have a particular license in mind when making this work available? Would you mind adding one to help ensure the future availability of these tools? I recommend GPL v3. It's what I use myself.

Expected <Planet>.getApparentEquatorialCoordinates was geocentric, but it seems to remain heliocentric, how could I get geocentric coords of a planet?

Related: onekiloparsec/SwiftAA#24

The unit tests must run automatically on each push on at least one CI service.

Hey, excellent project! I'm trying to integrate in a personal project built on node.js.
I can't do that out of the box because only the src/ folder is distributed via npm (node doesn't support es modules at this time). So I have to build it using rollup:

$ rollup node_modules/aa.js/src/index.js --file aa.js/index.js --format cjs

Then I can import it doing:

const { moon } = require("./aa.js");

It's obviously not ideal. I can see a webpack configuration, but the resulting files should be added to npm and a new version of the package published.

> AA.transits.getRiseSetTransitTimes(sun.apparentEquatorialCoordinates())
Thrown:
TypeError: Cannot read property 'midnightJulianDay' of undefined

looks like https://github.com/onekiloparsec/AA.js/blob/master/src/transits.js#L9 should maybe be

var jd = (new julianday.JulianDay(jdValue)).midnightJulianDay();

AA+ has evolved in version. Before integrating new code, let check whether the existing one must be changed.

I performed an npm install aa-js into my Typescript project and VS Code is giving this linting error on the import statement.

I followed the example in the readme and started by importing julian days.

import { juliandays, Earth } from 'aa-js'

const jd = juliandays.getJulianDay(new Date())

Under the 'aa-js' it provides an error and this is the message:

Could not find a declaration file for module 'aa-js'. '/[appname]/node_modules/aa-js/dist/aa-js.js' implicitly has an 'any' type. There are types at '[appname]/node_modules/aa-js/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'aa-js' library may need to update its package.json or typings. ts(7016)

For example, this code does work:

import {
  Sun,
  coordinates,
  type JulianDay,
  GeographicCoordinates,
  HorizontalCoordinates,
  EquatorialCoordinates,
} from "aa-js";

export const calcSunAltitude = (
  jd: JulianDay,
  coord: GeographicCoordinates
): HorizontalCoordinates => {
  const sunGeoEquCoord: EquatorialCoordinates =
    Sun.getGeocentricEquatorialCoordinates(jd);
  return coordinates.transformEquatorialToHorizontal(jd, sunGeoEquCoord, coord)
    .altitude;
};

Although I am able to compile and run the web application with this error, I am not provided with any Typescript intellisense or typechecking.

Thank you for this awesome library! I use it to make an app that calculates precise age.

However I noticed that precision wasn't great. Specifically because of the function MapTo0To360Range, so I removed it in a local version. This also made my code simpler because I was reimplementing the lost information anyway (number of orbital cycles between dates).

Could This be removed and have this function be available to be used independently by developers? This is a breaking change so I suggest a whole new function, but without MapTo0To360Range, while the current function would become a wrapper.

I can make a PR if this sounds good!

@onekiloparsec As mentioned creating a new issue for fixing tests. Please accept if this is fine with you.

Hi I'm trying to see if I can use this library, I tried your basic example:

import { julianday, moon } from 'astronomical-algorithms'

...

const jd = julianday.getJulianDay(new Date()),
const coords = moon.equatorialCoordinates(jd)

but at compile I get this error:

"export 'julianday' was not found in 'astronomical-algorithms'

I know it's still a wip, I'm just trying to understand if i'm making mistakes on my side, thanks

Ongoing work on the #develop branch.