Giter Club home page Giter Club logo

omnibridge-ui's People

Contributors

0xapotheosis avatar akolotov avatar alexkeating avatar brossetti1 avatar crisog avatar dan13ram avatar ebkhalilzadeh avatar jtakalai avatar lazyfish77 avatar maxaleks avatar scottrepreneur avatar sunguru98 avatar yadatashy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

omnibridge-ui's Issues

Open Confirm Transfer modal on Transfer click

When the user selects Transfer, open the Confirm Transfer modal #9 to provide the details of the transfer to be approved.

  • Check again for approved allowance
  • Check again for enough balance

Use chakra-ui for networkSelector

Replace "react-select" with PopOver component from chakra-ui to make the components looking uniform.
This also removes unwanted bulky "react-select"

custom token swap

i have add a custom token to swap but it show an error : 0x969ee7e66bd4f3b4460e957ca583a2e09fa84ddd

image

any idea why?

small ui tweak

noticed the popover arrow has a bit of an odd layering of the box shadow compared to the popover box the content lays in.

this:

Screen Shot 2020-09-20 at 3 33 51 PM

Approve ERC-20 for Transfer

Unlock the amount set to transfer with the approve() function on the token contract

  • Show warning if the amount to transfer is higher than the user's balance

Add links to footer icons

Also need hover effect for the icons.
For this need to convert .svg files to react components using createIcon from chakra-ui so that color can be changed from css.

Custom token modal

Allow the user to add a custom token by address. Comes from Select Token Modal #7

  • Look up the symbol and decimals for the contract
  • Remember tokens added locally

Screen Shot 2020-08-29 at 11 14 15 AM

Setup BridgeContext

Setup BridgeContext in BridgeTokens to share data/methods between different components such as FromToken, UnlockButton, TransferButton.

API to pre-setup a particular tokens and the direction for transfer

There is a request from third party applications to have an ability to specify a particular token and direction for transfer to be set when the OB UI is opened.

For example, if a project operates with a token X, it could have a link in their app like "Bridge X to Mainnet". When a user clicks on the link the OB UI must be opened where the required token on the xDai chain is chosen automatically (in the left side of the main window). The only thing the user must do is to specify the amount and press the transfer/request button.

BTW, the amount to transfer also could be part of the API request.

Fees are displayed for tokens added through the overrides mechanism

Tried to transfer MOONs from xDai to Ethereum Mainnet. The OB UI displays that fees will be collected as part of the transfer.

image

The MOONs tokens were added to the OB UI through the mechanism of overrides when a separate mediators are specified for a specific pair of tokens. The mediators responsible for transferring MOONs are not configured to collect fees.

This is the executed transfer on the Mainnet: eventually 1 MOON was transferred as it has been requested: https://etherscan.io/tx/0xe919c63b5c3482cf4eb523ff4081cb2769608219c11050bbdcdeb70955090f6d.

walletconnect passing undefined to functions

I'm having trouble getting the bridge to play nicely with the Gnosis Safe via walletconnect.

Connecting the safe to the bridge brings in the right balances and confirms the allowance, but sending the functions returns an error. Happens on both unlock and transfer calls currently.

  • Connect via WalletConnect to Gnosis Safe
  • switch to token (WETH)
  • attempt to unlock max
  • if unlocked, attempt to transfer (relay)

"invalid BigNumber value (argument="value", value=undefined, code=INVALID_ARGUMENT, version=bignumber/5.0.12)"

Catch submitted Transfer

When the user confirms the transfer show a count of the necessary block confirmations

  • Include a link to the ALM for the transaction
  • Close on dismiss or add closer?

Screen Shot 2020-08-29 at 7 52 55 PM

Move fetching limits logic

Currently system limits are being fetched along with balance on selecting a new token.
Can move this logic to onClick on System Feedback button

Retrieve historical transactions

Retrieve the user's historical transactions on the current network and show them on the History page.

  • Link to block explorer for the current network
  • Need separate links for ALM and Etherscan?

Screen Shot 2020-08-29 at 11 34 39 AM

Allow to turn off notifications about unclaimed transfers

Consider to extend the "Settings" tab with a parameter which will allow to turn off the notifications about unclaimed transfers. If this parameter is enabled I will still get the request to claim an outstanding transfer but the notification will not appear if I open the app, switch the network, change the account in MM etc.

History tab does not reflect a transfer made with the alternative receiver feature

If a user A transfers a token and specifies an address B in the recipient address field the user B do not see this transfer on the history tab (therefore they cannot claim it).

Consider to implement the logic as so both the user A and the user B will be able to see in the history tab the transfers sent by using the alternative receiver feature. If some transfer is not finilized yet both users will need to have an ability to press the 'Claim' button.

fetch balanceInUsd for tokens

explore if any public apis exist for this
if no comprehensive solution exists then discuss removing the dollar value from UI,
since it is 0 always currently.

Fetch tokensList from subgraph

For all networks: Fetch tokens from subgraph
For mainnet: Combine list fetched from subgraph with list on default-token-list repo
For all networks: (xdai & mainnet) get logo from default-token-list repo

fix amount input becomes too small for larger values

If the name of the token is really large, and amount value also is larger than 4-5 digits
then the amount value gets hidden and user has to move cursor over the input field to see the full amount.

possibly need to change design for this

Confirm transfer modal

When the user selects Transfer, confirm the details of the transfer in modal #14

  • Continue submits the relay transaction to the current blockchain
    • on Ethereum Mainnet, relayTokens() will send the tokens to the mediator contract
    • on xDai, there's no approval necessary, call transferAndCall() to send to the xDai mediator contract.
  • If the wrong network is connected, show the change network warning #6.
  • On submit, show transaction confirmations #10

Screen Shot 2020-08-29 at 11 18 31 AM

Use wallet provider where possible

Currently we are using InfuraProvider for most read calls and using WalletProvider only for write calls.
In order to reduce the read calls on our InfuraProvider, we must move to using the WalletProvider whenever available.

add support for OWL and custom mediators/tokens

Need to allow tokens to share a custom mediator and token implementation to be integrated into the bridge. When they share the mediator addresses and token addresses we should update the token list and mediator override.

  • Need to look into how this affects the subgraphs

OWL custom mediator

{
    "homeBridge": {
        "homeBridgeMediator": {
            "address": "0xbeD794745e2a0543eE609795ade87A55Bbe935Ba"
        },
        "bridgeableErc677": {
            "address": "0x0905Ab807F8FD040255F0cF8fa14756c1D824931"
        }
    },
    "foreignBridge": {
        "foreignBridgeMediator": {
            "address": "0xed7e6720Ac8525Ac1AEee710f08789D02cD87ecB"
        },
        "bridgeableErc20": {
            "address": "0x1a5f9352af8af974bfc03399e3767df6370d82e4"
        }
    }
}

Warn user on wrong network

We need to warn the user when they set a network on the application but their wallet is set to another wallet.

The developer instance implements this when attempting to send the relay.

switch wallet to other network

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.