olemb / readlisp Goto Github PK

Thanks for writing this and making it open source -- very helpful!

Lines 156, 168, 170, and 172 have a tab used as a substitute for 8 spaces (2 levels of indentation), which causes an error in python3:

$ python3 readlisp.py
File "readlisp.py", line 156
return '(%s)' % ' '.join(map(writelisp, obj))
^
TabError: inconsistent use of tabs and spaces in indentation

By default when the program is run as a standalone program, it reads input from test.lisp. IMO a better default for standard use would be to read from stdin.

StringIO is used in one place, and StringIO is not present in python3. There is some material here on how to modify code using StringIO so that it is compatible with both python2 and python3: https://stackoverflow.com/questions/11914472/stringio-in-python3 . I think the try-catch method shown in nobar's answer is probably a good one.

The program goes into an infinite loop on this input:
(a |b|)
I don't know much about s-expressions, and wasn't able to figure out what the |...| meant, but the real-world expression that caused the crash was this output from the computer algebra system Maxima:
(DSKSETQ $MYEXPRESSION '|$%pi|)