olefredrik / foundationpress Goto Github PK

Love this Foundation 5 WordPress starter theme. Excellent job - thank you. It would be great if like on underscores site you could create a new download with new theme name and slug integrated...

again thank you

A

If you're logged in on a small device, the FoundationPress Navbar is covered by the Wordpress navbar.

I've got no idea why the wordpress navbar drops down, but two options to solve it are to set top:-46px on the #wpadminbar container, or override Wordpress' media query in /wp-includes/css/admin-bar.min.css to use relative positioning

media="all"
@media screen and (max-width: 600px)
#wpadminbar {
position: absolute;
/* Override with relative positioning to solve overlap? Does it cause other issues? */
}

I was wondering why none of the foundation js was working, turned out the call to $.fn.foundation was happening before most of the dom elements were in place. Wrapping it in a document.ready fixed the issue. I'd be happy to make the change and issue a pull request if you'd like.

After Clean installing Wordpress and Theme i'm there is still issue with jquery from different addons. Example is addon:
Gallery
This plugin allows you to implement gallery page into web site.
Version 4.1.6

Error:
Uncaught TypeError: Cannot read property 'msie' of undefined jquery.fancybox-1.3.4.pack.js:18

Wordpress version: 3.8.1.

Before applying the theme i did run (locally on windows)

mv FoundationPress your-theme-name
cd your-theme-name
npm install && bower install
While you're working on your project, run:

grunt

Hello,
How do I configure the foundationPress 'top-bar-l' menu to use the default links generated by wordpress?

Inserting a picture with a caption causes the div with class wp-caption to have a fixed width, making it to exceed the boundaries of the post column.

Hi, great theme, moved here from reverie and it taught me how to use grunt.

How do I compress and add my custom theme scripts to app.js.

Right now I have it as a separate Js file in the /js folder. Knowing this will be great to reduce the files loaded.

Thanks

I'd like to access my installation on a custom domain like mysite.dev instead of localhost.

Ideally I'd also like to be able to create more sites in different folders, each with their own domain mapped to them. I've looked at the approach taken by Varying Vagrant Vagrants where the Vagrantfile is parsing custom vvv-hosts files, dynamically adding (and removing) them to/from the guests hosts file when vagrant is started and stopped (using the the hostsupdate plugin).

I'd like to add something similar to this project. What do you all think about this?

Hello,
I install everything is working the off-canvas is working but the menu when you click it doesn't link to the page. I click but nothing shows

What is the point of looping the register_sidebar() in a foreach()? It is only one sidebar and only one footer. And if more was to be added the would all get the same ID.

Also, why the <strong> tag in the title? Should that be set by styling <h6> with css?

Hi. Can you simply use compass on this theme? I'm not having luck.

I can't seem to get the off-canvas menu to work. WP 3.9.1. I made sure to have "Mobile" checked in the Menus section and I copied over a fresh header.php and _settings.scss file just to make sure I didn't have any strange settings in place. Can you verify that it works in 3.9.1?

Thanks for the great work on the framework. I'm still quite new to this stuff and this is my first WordPress website.

I'm currently working on a mate's personal website but having an issue with the footer floating:

http://stephenmorris.ie/brown-thomas-so-parisian/

I've tried stuff on sticky-footer, Rick Fait et al but nothing is working right for me

Hi,
I was trying to set the $topbar-input-height variable as showed here: http://foundation.zurb.com/docs/components/topbar.html, but it's not working.

Hi,

After FoundationPress installation my console outputs the typical "Uncaught TypeError: Property '$' of object [object Object] is not a function" error in file js/app.js.

Changing $(document).foundation() to jQuery(document).foundation() at the end fixed it.

Is this normal?

Many thanks!

First of all: great work! its a very nice and clean theme that fits almost all my needs.

I have just a little suggestion:
I am writing a complete childtheme and several plugins to use them with foundationpress. It would be great to add several hooks (do_action) to some places (at the beginning and the end of the main layout, before and after opening/closing tags in the template files etc.)

With the hooks, it would be possible to inject own code without "hacking into" your theme and losing the ability to upgrade it.

If you need some helping hands, let me know :-)

Thanks for your reply

Adrian

Hey there,

After running into headache after headache getting my mac to install Node.js, etc, I'm back to just wanting to use good 'ol CodeKit to compile my SCSS and js.

However, your documentation encourages using grunt, bower, etc. Considering I can't get the *%(@ stuff to install, I have no idea what it does or what it's for. Do I need this? Or can I just write my own SCSS, JS, and let CodeKit compile them into the CSS and JS I need? Will it hurt anything as far as dev with FoundationPress? Or inhibit upgrades in the future?

I've attempted making the top-bar sticky by placing the "sticky" class (with and without the contain-to-grid class) in several locations and none seems to make it "stick". Would you be able to suggest a location of where to put the class, or is there something else I'm missing?

Thanks,
David

Hi, the admin bar in the smallest devices overlaps the mobile menu.

http://bit.ly/1kQqYG0

Actually Zurb decided to drop IE8 support in Foundation 5. So officially IE8 is a lost case if you’re using FoundationPress.

BUT, there’s a thread in the Foundation Forum that claims to have a neat workaround for this: http://foundation.zurb.com/forum/posts/241-foundation-5-and-ie8

Haven’t tried it myself, but it might be worth checking out. :-)

Issue with this mediaquery i think: media="all" @media screen and (max-width: 600px)

Removing #wpadminbar {position: absolute;} in admin-bar.min.css seems to resolve this issue. Haven't had any other issues by removing this.

I experienced some bugs (dropdown not working) while the init-foundation.js was like:
$(document).foundation();

after long research I realized that it was the common Wordpress bug with jQuery in NoConflict mode so I changed init-foundation.js to:

jQuery(document).foundation();

now, it works like a charm ;)

bye

I've noticed a few issues with plugins that assume Wordpress will load jQuery in the header, whereas FoundationPress is enqueing in the footer.

http://wptest.io/ data includes a Videopress example that hits this problem [not core, but one of Automattic's plugins].

I've opted to return jQuery to the header by setting the last paramater on the enqueue to false (and stick in a cdn version)

wp_enqueue_script( 'jquery', '//ajax.googleapis.com/ajax/libs/jquery/2.1.0/jquery.min.js', array(), '1.0.0', false );

Yes I am wanting to create Advanced menu with your theme. Like the link below.
http://foundation.zurb.com/docs/components/offcanvas.html

I know how to create a menu but I was trying to customize your existing menus. My question is do you have documentation for you theme or can you tell me how to customize the menu in your theme.

Thanks

Is there a way to target individual list items in the mobile manu? My goal is to have different icons (as background images) for each.

Any advice greatly appreciated.

When validating a page containing blogpost I get an Error stating "Attribute pubdate not allowed on element time at this point."

Example:
http://validator.w3.org/check?uri=http://foundationpress.olefredrik.com/category/first-category/

I couldn´t find that attribute in the current draft either.
see: http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-time-element

Since I´m quite new to git and not yet familiar with all the functions I´d rather not make a pull request here since I´dont want to mess things up ;)

My suggestion: Just remove 'pubdate' in 'entry-meta.php' on line 4.

Best regards

I've discovered a strange behavior with the img_unautop function.

If in a post you insert a picture and then start the next text paragraph with a link, it happens that the whole thing (the image and the paragraph) gets wrapped in the <figure> tag, displaying the text with a different line height.

An example:

<a href="some_link"><img class="alignnone" alt="error" src="image.png" /></a>

<a href="http://example.com">Example</a> Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem.

I've found that a solution is to put an empty <span> tag before the link in the paragraph.

Hi,

It seems there is a conflict with this theme and woocommerce.

After installing the Woocommerce plugin, the console reports a type error on line 3 of app.js:

undefined is not a function

I have had a look inside the enqueue scripts file that you created with this plugin and it looks like everything is done by the book, but this error still appears. I have also tried including the app.js in the header rather than the footer and I have also tried using the bundled version of jQuery included with Wordpress and that still doesn't solve the conflict.

Any ideas on how to solve this issue with your theme?

Many thanks

Hi Olefredrik,

First off you're awesome! This repo saved me weeks of time.

Just wanted to let you know that doing a search that returns no results will return an error. I verified this here:

http://foundationpress.olefredrik.com/?s=boo

The simple solution is to copy the twentyfourteen content-none.php to your theme and edit as you wish. It seems from your code that you intended to use this file or accidentally removed it since you refer to it in the post loops.

I realize this is not supposed to be a production-ready theme, but thought you might wanna know since it's an easy fix.

Has anyone tried this with Gravity Forms? I would love to know if someone has tried this yet...

Under foundation/js there is another foundation folder with a css folder and scss folder, which contains foundation/components folder full of scss files. If I need to make any changes to these component styles to zurb foundation, I won't be able to with Grunt. Why are these styles inside a js folder, and why the weird structure here?

First I want to say that I like this theme. But I have one problem at this moment and that is when I install WooCommerce the sub-menus won't appear anymore. And when the menu is in 'mobile mode' the button does nothing.

Missing kitchen-sink.js. Consequently joyride in kitchen sink is not working. Also missing jquery.min.map.

I simply uploaded cloned FoundationPress.git from my desktop via FTP in to wp-content/themes folder and activated theme. Quite possible I forgot some steps ...

Hi Olefredik, I just a have a brief question. How did you get foundation js plug ins working with out including '$(document).foundation();'

Before the end of the body tag?

It would be nice if all English strings where encapsulated with the translation functions of WordPress.

Like __('Footer') instead of just 'Footer' in widgets and changing echo ' Archive | ' in header to something like echo ' ' . __('Archive') . ' | '.

Inline elements (e.g. span) are turned into block elements when the visibility classes are applied. I read here that this was fixed in Foundation: foundation/foundation-sites#887

But I still have the same problem.

I used other theme and apply some of the FoundationPress. (enqueue-scripts.php, foundation.php, menu-walker.php, navigation.php) The menu appears, but I click and the page is the same. I set the menu appearance to Mobile and to the right-top-bar. The desktop version of top bar is working. Only the mobile.
Please help with this.

Hi there!

Love the theme, I've never worked on a Wordpress theme where I can use grunt, bower and sass, so impressed.

I'm having a problem with my fixed background images in Chrome. First they weren't appearing and I had to give a "overflow: visible" on the .off-canvas-wrap to allow them to appear. But now they're flickering when you scroll and change the slide in the boxed-wine slide show in the section section. I'm using deep linking with the Orbit Slider. I've tried all the solutions I found online. If you can please help me find a solution, that would be amazing.

http://publichousewines.hstestsite.info/

Best,

Tessa

I installed on Multisite with same settings as single install but its all messed up. Am I missing something or is it not compatible with MU? http://d.pr/i/AbEm

Hello -

Thanks for the framework - I'm a big fan.

Question: is it possible to take certain rows and display them at full, 100% browser width?

I try using the "homepage-hero" class that is used on the foundation homepage (http://foundation.zurb.com/index.html) but I cannot get this to span 100%.

I've also looked at standard Foundation 5 documentation and they recommended setting classes as below, but I can't seem to "get wide" when adding these to my _colors.scss file. I wonder if something about the off-canvas wrapper might be constraining my proportions.

Thanks.

Examples of recommended code in non-FoundationPress Foundation 5:

.row {
width: 100%;
margin-left: auto;
margin-right: auto;
margin-top: 0;
margin-bottom: 0;
max-width: 62.5em;
}

.full-width {
width: 100%;
margin-left: auto;
margin-right: auto;
max-width: initial;
}

Hello,

It's the first time i use Foundation (FoundationPress to start), i'm mostly a Bones developper... but i want to give Foundation/FoundationPress a try...

I'm having trouble when i try to save / compile my scss files (Coda / Codekit)
(Note : Node, Grunt, Compass are installed and updated to latest)

Tried to google with no chance...

Here

app.scss error
Syntax error: File to import not found or unreadable: foundation/functions.
Load paths:
xxx/wp-content/themes/accueil-child/scss
xxx/bower_components/foundation/scss
on line 13 of /xxx/wp-content/themes/accueil-child/scss/config/_settings.scss
from line 4 of /xxx/wp-content/themes/accueil-child/scss/app.scss
Use --trace for backtrace.

Thx for the support.

Hi,
Apologies, this is plugin related so feel free to ignore.
Activating WooCommerce causes the off-canvas navigation to become unresponsive ie. Clicking on the burger icon no longer triggers the slide in.
Here's a screenshot from Chrome Dev Tools

Any ideas?

Am I crazy or is the whole site wrapped in a div with .off-canvas-wrap?

Isn't just the off-canvas content (i.e. the mobile menu) supposed to be in that div?

I am referring to line 37 in header.php -- that div doesn't seem to be closed before the main content starts.

I've wanted to use FoundationPress on my local server (using MAMP) and I've followed your instructions to clone this repository etc except I get the following:

"Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists."

Is there something I'm missing?

Jetpack support page: http://jetpack.me/support/comments/troubleshooting-jetpack-comments/

It says there that comment_form() needs to be used in comments.php for the Jetpack comment form to be enabled.

Any way this can happen? or if you can suggest whats safe to delete, i can copy paste from twentyfourteens comments.php

This is a great theme. Would it be possible to get the demo data [either dump the database or a wordpress export?] so we can setup the kitchen sink and other stuff on our test rig.

When I replace the old code in enqueue-scripts.php with the new code, the issues with 3rd party plugins disappears but the js with Foundation stops working.

This is the error in the console: Uncaught TypeError: Property '$' of object [object Object] is not a function

I'm not sure if this is an issue or just some ineptitude on my part but I can't seem to enqueue jquery-ui-datepicker. I'm wondering if it has something to do with using the bower components version of jquery?

How do you feel about having a divider at the end of the main menu? It seems this is how the foundation site has it as well.

I removed the divider because I didn't want it anyways, but could be an issue for others.