Giter Club home page Giter Club logo

frictionless's People

Contributors

miggaiowski avatar mtudor avatar nikcub avatar oldestlivingboy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

frictionless's Issues

Washington Post Reader Support

The Washington Post reader will do nothing on cancel and also doesn't have a redirect_uri embedded.

<a data-appname="Washington Post Social Reader" href="https://fb.trove.com/fbwapolabs/me/channels/16647/content/kPIcx?fb_action_ids=10150493543360119%2C10150983273420183%2C10150983750600183%2C2756389187965%2C10150983750965183&amp;fb_action_types=news.reads&amp;fb_source=other_multiline" title="Newegg deal brings Google Offers to its knees" onmousedown="UntrustedLink.bootstrap($(this), &quot;ZAQGMWa6u&quot;, event, bagof(null));" rel="nofollow" target="_blank">Newegg deal brings Google Offers to its knees</a>

Kill Facebook Link Warning Page

when you click on an external link in facebook it sends you to a warning page. we should get rid of that, it is just a pain, since it just warns about every. single. website.

the way it works is that the actual link is in the href, but there is a onmousedown even which will load UntrustedLink.bootstrap(this), for eg.

<a href="http://www.guardian.co.uk/commentisfree/cifamerica/2011/nov/25/shocking-truth-about-crackdown-occupy?fb_action_ids=10150423542353820&amp;fb_action_types=news.reads&amp;fb_ref=U-7nS6oTSpJs5r4ZCUIdyggA-CFCONX01FRS-33thvXXX&amp;fb_source=other_multiline" data-hovercardx="/ajax/hovercard/hovercard.php?id=10150485705779276" onmousedown="UntrustedLink.bootstrap($(this), &quot;lAQFxMQFC&quot;, event, bagof(null));" rel="nofollow" target="_blank">The shocking truth about the crackdown on Occupy</a>

the solution here is to overwrite UntrustedLink, or to remove those onmousedown events and have the browser just do its thing

Links to The Guardian are not being anonymized

for eg.

<a href="http://www.guardian.co.uk/media/2011/dec/03/jeremy-clarkson-accused-trivialising-suicide?fb_action_ids=10150425803743820&amp;fb_action_types=news.reads&amp;fb_ref=U-_SeYg5GZzY8U4OLEI_pV0P-CFCONX01FRS-33zqmXXX&amp;fb_source=recent_activity" target="_blank" data-hovercardx="/ajax/hovercard/hovercard.php?id=10150434614723290&amp;shimparams=%7B%22p%22%3A500073819%2C%22t%22%3A85%2C%22a%22%3A180444840287%2C%22cb%22%3A8%2C%22v%22%3A%22tli_ogr%22%7D" rel="nofollow" data-frictionless-safe="true">Jeremy Clarkson goofs again as he is acc...</a>

Leads to:

http://www.guardian.co.uk/media/2011/dec/03/jeremy-clarkson-accused-trivialising-suicide?fb_action_ids=10150425803743820&fb_action_types=news.reads&fb_ref=U-_SeYg5GZzY8U4OLEI_pV0P-CFCONX01FRS-33zqmXXX&fb_source=recent_activity

which should be:

http://www.guardian.co.uk/media/2011/dec/03/jeremy-clarkson-accused-trivialising-suicide

Washpo Reader Links not being parsed

<a href="https://fb.trove.com/fbwapolabs/me/channels/78071/content/Nvnk5?fb_action_ids=10150425798668820&amp;fb_action_types=news.reads&amp;fb_source=recent_activity" target="_blank" data-hovercardx="/ajax/hovercard/hovercard.php?id=10150415807386395&amp;shimparams=%7B%22p%22%3A500073819%2C%22t%22%3A85%2C%22a%22%3A225771117449558%2C%22cb%22%3A8%2C%22v%22%3A%22tli_ogr%22%7D" rel="nofollow" data-frictionless-safe="true">Apple Licensed iOS Scrolling Patent to N...</a>

It has been marked safe but not rewritten.

Independent and Yahoo clickthroughs silently fail

Typo for Yahoo Sport link

There seems to be a typo or otherwise an issue with replacing the URL of a Yahoo news story on the Sport part of the website. The original URL that requests you install the app is:

https://www.facebook.com/connect/uiserver.php?app_id=194699337231859&method=permissions.request&redirect_uri=http%3A%2F%2Fsports.yahoo.com%2Fblogs%2Folympics-fourth-place-medal%2Fryan-lochte-used-olympic-pool-purposes-other-swimming-204307621--oly.html%3Ffb_action_ids%3D4328449178782%252C4328418818023%252C4327897564992%26fb_action_types%3Dnews.reads%26fb_ref%3Dtype%253Aread%252Cuser%253A5TDUmujuPWetV3P8GbIPWcLKOZY%26fb_source%3Dother_multiline%26action_object_map%3D%257B%25224328449178782%2522%253A10151070255149763%252C%25224328418818023%2522%253A10150952984112204%252C%25224327897564992%2522%253A10151081427406100%257D%26action_type_map%3D%257B%25224328449178782%2522%253A%2522news.reads%2522%252C%25224328418818023%2522%253A%2522news.reads%2522%252C%25224327897564992%2522%253A%2522news.reads%2522%257D%26action_ref_map%3D%257B%25224328449178782%2522%253A%2522type%253Aread%252Cuser%253A5TDUmujuPWetV3P8GbIPWcLKOZY%2522%252C%25224328418818023%2522%253A%2522type%253Aread%252Cuser%253A5TDUmujuPWetV3P8GbIPWcLKOZY%2522%252C%25224327897564992%2522%253A%2522type%253Aread%252Cuser%253A5TDUmujuPWetV3P8GbIPWcLKOZY%2522%257D&response_type=code&display=page&auth_referral=1

which when "fixed" by Frictionless, converts to the following link:

http://sports.yahoo.com/blogs/olympics-fourth-place-medal/ryan-lochte-used-olympic-pool-purposes-other-swimming-204307621--oly.htmlaction_object_map=%7B%224328449178782%22%3A10151070255149763%2C%224328418818023%22%3A10150952984112204%2C%224327897564992%22%3A10151081427406100%7D&action_type_map=%7B%224328449178782%22%3A%22news.reads%22%2C%224328418818023%22%3A%22news.reads%22%2C%224327897564992%22%3A%22news.reads%22%7D&action_ref_map=%7B%224328449178782%22%3A%22type%3Aread%2Cuser%3A5TDUmujuPWetV3P8GbIPWcLKOZY%22%2C%224328418818023%22%3A%22type%3Aread%2Cuser%3A5TDUmujuPWetV3P8GbIPWcLKOZY%22%2C%224327897564992%22%3A%22type%3Aread%2Cuser%3A5TDUmujuPWetV3P8GbIPWcLKOZY%22%7D

However, there is question-mark character missing - instead of reading "...oly.htmlaction_object_map...", it should read "...oly.html?action_object_map..." I have tested this and it appears to fix the problem.

Rewrite social video links

Currently all the social video links from Chill, Socialcam et al require app authorization to view videos. We want to rewrite those links and:

  1. Link to an original source of the video

  2. Embed a YouTube alternative link

Some "I'm Feeling Lucky" URLs busted

Any idea why this URL isn't autoredirecting?

https://www.google.com/search?btnI=1&q=%22Bond+girl+Michelle+Yeoh+wants+to+work+with+Aamir+Khan%22

Links all redirect to Google searches

Seems like all links (although I've only got WaPost links in my feed at the moment, so not sure about other sources) get redirected to Google searches. The rendered HTML from the news feed page looks like:

<a data-hover="tooltip" title="" tooltip-position="below" class="UIImageBlock_Content UIImageBlock_ICON_Content" data-appname="Washington Post Social Reader" href="https://www.google.com/search?btnI=1&amp;q=%22Read+using+Washington+Post+Social+Reader+app%22" target="_blank" data-frictionless="rewritten"><span class="ogAggregatedTableNormalItemContent">Oregon's Nike Uniforms For 2012 Rose Bowl Are From Outer Space</span></a>

The larger chunk with two links (in case it matters) is:

<ul class="uiList ogAggregatedTableManyToMany"><li class="ogAggregatedTableRow uiListItem uiListLight uiListVerticalItemBorder"><div class="UIImageBlock clearfix"><a class="UIImageBlock_Image UIImageBlock_ICON_Image" data-appname="Washington Post Social Reader" href="https://apps.facebook.com/wpsocialreader/" aria-hidden="true" tabindex="-1" data-hovercard="/ajax/hovercard/page.php?id=225771117449558"><img class="srcIcon img" src="https://fbcdn-photos-a.akamaihd.net/photos-ak-snc1/v43/86/225771117449558/app_2_225771117449558_4617.gif" alt=""></a><div class="ogAggregatedTableFacepileSmall UIImageBlock_Ext"><div class="uiFacepile uiFacepileSmall"><ul class="uiList uiListHorizontal clearfix"><li class="uiFacepileItem uiListItem  uiListHorizontalItemBorder uiListHorizontalItem"><a class="uiTooltip link" onmouseout="this.blur();" href="https://www.facebook.com/humphrey" data-jsid="anchor"><img class="uiProfilePhoto uiProfilePhotoSmall img" src="https://fbcdn-profile-a.akamaihd.net/hprofile-ak-snc4/49067_4803681_6793_q.jpg" alt="" data-jsid="img"><span class="uiTooltipWrap top left lefttop"><span class="uiTooltipText">Matt Humphrey</span></span></a></li></ul></div></div><a data-hover="tooltip" title="" tooltip-position="below" class="UIImageBlock_Content UIImageBlock_ICON_Content" data-appname="Washington Post Social Reader" href="https://www.google.com/search?btnI=1&amp;q=%22Read+using+Washington+Post+Social+Reader+app%22" target="_blank" data-frictionless="rewritten"><span class="ogAggregatedTableNormalItemContent">Oregon's Nike Uniforms For 2012 Rose Bowl Are From Outer Space</span></a></div></li><li class="ogAggregatedTableRow uiListItem uiListLight uiListVerticalItemBorder"><div class="UIImageBlock clearfix"><a class="UIImageBlock_Image UIImageBlock_ICON_Image" data-appname="Washington Post Social Reader" href="https://apps.facebook.com/wpsocialreader/" aria-hidden="true" tabindex="-1" data-hovercard="/ajax/hovercard/page.php?id=225771117449558"><img class="srcIcon img" src="https://fbcdn-photos-a.akamaihd.net/photos-ak-snc1/v43/86/225771117449558/app_2_225771117449558_4617.gif" alt=""></a><div class="ogAggregatedTableFacepileSmall UIImageBlock_Ext"><div class="uiFacepile uiFacepileSmall"><ul class="uiList uiListHorizontal clearfix"><li class="uiFacepileItem uiListItem  uiListHorizontalItemBorder uiListHorizontalItem"><a class="uiTooltip link" onmouseout="this.blur();" href="https://www.facebook.com/profile.php?id=4203185" data-jsid="anchor"><img class="uiProfilePhoto uiProfilePhotoSmall img" src="https://fbcdn-profile-a.akamaihd.net/hprofile-ak-snc4/211255_4203185_2968394_q.jpg" alt="" data-jsid="img"><span class="uiTooltipWrap top left lefttop"><span class="uiTooltipText">Anjali Saxxena</span></span></a></li></ul></div></div><a data-hover="tooltip" title="" tooltip-position="below" class="UIImageBlock_Content UIImageBlock_ICON_Content" data-appname="Washington Post Social Reader" href="https://www.google.com/search?btnI=1&amp;q=%22Read+using+Washington+Post+Social+Reader+app%22" target="_blank" data-frictionless="rewritten"><span class="ogAggregatedTableNormalItemContent">Girl who predicted her death on Facebook, dies of wounds</span></a></div></li></ul>

Cancel Dialog Boxes

when redirecting on redirect_uri the dialog box remains open. kill it by finding all rel='dialog' urls that are from social sharing apps and rewritting them.

Yahoo News

Doesnt work with Yahoo links.
Wants to install
"Yahoo!
Read the news with your friends"
App instead.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.