Box Stick の判定は特定のキーがアイテムに含まれているかで行っているため
任意のアイテムにそのキーをセットすればそれを Box Stick と同等の機能をもたせることができる。

コマンド予定: /boxadmin customstick

v4.0.0 リリース後に実行

develop/master -> master にマージ
master -> v3/master

デフォルトブランチを v4/master にする

レイアウト予定:

青/赤ガラス: 贈るアイテム量 増減
白ガラス: 増減単位変更
オーク扉隣の頭: 選択済み贈り先プレイヤー
土: 送るアイテム表示 & 確定ボタン

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency gradle to v8.9

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• fix(deps): update configapi to v5.0.0-snapshot (com.github.siroshun09.configapi:configapi-test-shared-classes, com.github.siroshun09.configapi:configapi-format-yaml, com.github.siroshun09.configapi:configapi-core)
• fix(deps): update dependency com.github.siroshun09.event4j:event4j to v4.0.0-snapshot

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

/box sell <item> [amount]

New Feature

Support for Minecraft 1.20.2

Box works fine in Minecraft 1.20.2.

Click the item in the inventory to open its category menu

When the Box menu is open, clicking on an item in the player's inventory now opens the category menu to which that item belongs.

Add --page (-pa) argument for /box gui

For example, run /box gui --category stones --page 2 to open the stone category on page 2.

Accordingly, clickable category buttons in /box iteminfo will now take you to the page with the item.

API Changes

#257 (comment)

Notice of Box v6

We are planning to further improve performance/stability and to change the internal structure for it. The release date is not yet scheduled, but it will come in the not-distant future.

Full Changelog: 5.4.2...main

Log:

[20:45:58 ERROR]: Could not pass event PlayerInteractEvent to Box v1.1.0-SNAPSHOT
java.lang.ClassCastException: org.bukkit.configuration.MemorySection cannot be cast to org.bukkit.configuration.Configuration
        at net.okocraft.box.listeners.GenerateItemConfig.onChestClick(GenerateItemConfig.java:109) ~[?:?]

TBA:

DatabaseConnectionReset

sender.sendMessage("§eデータベースへの接続をリセットしました。");

MapPlayersRecord

sender.sendMessage("記録されているプレイヤー");

MapColumnsList

sender.sendMessage("列リスト");

MapFormat

sender.sendMessage(String.format("%s - %s", columnName, columnType))

VersionInfo

sender.sendMessage(Box.getInstance().getVersion())

errorFetchCategoryName

System.out.println("カテゴリ名の取得に失敗しました。");

errorFetchItemConfig

System.out.println("アイテム設定の取得に失敗しました。");

errorFetchDisplayName

val categoryItemName          = Optional.ofNullable(section.getString("display_name"))
            .orElse("No display_name defined.")

New Features

Add Support for Minecraft 1.20

Minecraft 1.20 has been released, and Box is now compatible Paper 1.20!

Note: Folia support is temporally dropped in this version. After Folia 1.20 released, we will added back support.

Improvements

Add item's categories for /box iteminfo

Category names are clickable. When clicked, it opens the category menu directly (Minecraft: Java Edition only).

Add arguments for /box gui

• /box gui - Opens the Box menu
• /box gui <player name> -> /box gui --player <player name> - Opens the Box menu with the specified player's stockholder
• /box gui --category <category id> - Opens the specified category menu

Note: /box gui <player name> can still be used, but will be removed in the future.

Improve the default order of woods

Changes

Remove Categorizer

Categorizer is a system for automatically categorizing new items into the appropriate category. This system was implemented based on the name of the item and the item-tags. However, considering the planned changes to the Spigot/Paper API, we deemed difficult to maintain this system.

Instead, the default categories.yml is used to automatically categorize them into the category defined by default. While the Box is being maintained, new items are categorized in the same way as in the previous system. Items not defined in default categories.yml are categorized into the uncategorized category.

Note that if you do not manage categories yourself, it is recommended to delete plugins/Box/categories.yml and regenerate it after update (the order of items is not taken into account, both in the previous categoriser and after this change, which is ugly).

Fixes

• Increase stock of ingredient's "crafting remaining item"

New API

PlayerCollectItemInfoEvent

This event called when the player collects item information after typing /box iteminfo.

Category#containsItem

Checks if the BoxItem is contained in the category.

API Changes

• Add MCDataVersion#MC_1_20 and MCDataVersion#MC_1_20_1
• Remove deprecated constructors of stock
• Allow null for the permission node of TabCompleter#players
• Add Javadoc for models of the craft feature

New Features

Minecraft 1.20.5 Support

At the same time, Minecraft 1.20.4 or older support has been removed.

Add a new button to the craft menu for changing the order of ingredient

Demo Video

Deposit items from the player's inventory

In the Box menu, you can deposit items from your inventory by pressing shift + LMB to the item.

Demo Video

Changes

Box requires Java 21

The minimum Java version is updated to Java 21.

Restructured config.yml

Some settings are moved under the core section. The storage section is the same as v5.

#
# The core settings of Box.
#
core:
  # Settings related to player stock data.
  stock-data:
    # Number of seconds to unload the player's stock data after logging out.
    unload-time: 300
    # Interval in seconds to save player stock data.
    save-interval: 15
  # The list of worlds where Box cannot be used.
  disabled-worlds: []
  # Whether to enable debug mode or not.
  debug: false

• disabled-features and stick.menu-command has been removed.

Message format is now MiniMessage

All of the messages have been reformatted using MiniMessage. Also, the default message files have changed to LOCALE.properties.

If you are using custom messages, you need to migrate to the new format/file manually.

Enhanced categories.yml

New format:

dirt:
  disabled: false
  icon: DIRT
  display-name:
    default: Dirt
    ja: 土類
  items: [ ]

Most of the settings are migrated automatically. However, the display-name of the default category uses the default name.
If you are using custom names for default categories, you need to redefine them. (Before auto-migration, the old categories.yml will be copied)

When the Minecraft version is updated, new items are automatically added to the default category. This process is done only once after the update.

Other Changes

• Box is now Paper Plugin, so Box is no longer loaded on Bukkit/Spigot completely.
• Experimental items are no longer loaded when the experimental feature is disabled.
• Potion names have been renamed
  • Use Minecraft's potion name instead of Bukkit's one
  • Change extended/upgraded potion names
    • *_EXTENDED -> LONG_*
    • *_UPGRADED -> STRONG_*

API Changes

This changelog only lists changes under net.okocraft.box.api package. Other APIs such as feature's API and storage-api may have more breaking changes.

Added API

• MCDataVersion#MC_1_20_5
• ItemVersion
• ItemManager#getItemNameConverter
• Add EventManager to FeatureContext.Registration
• BootstrapContext

Dependency updates

• ConfigAPI v4 -> v5
• Event4J v3 -> v4

Newly exposed dependency

• messages

Removed API

All of the deprecated APIs in v5 have been removed. See #257.

• ItemImportEvent.ItemType
• Remove FeatureProvider from feature contexts
• Folia

タイトル通り。既存の DB 等がある場合は未検証。
Enable 時のログ:
https://gist.github.com/Siroshun09/b263572254749d6bfc35e8476855f635

と

が同じコードで重複してるふうに思えるんですけど意図してる？

鯖内での検証の通り、
拾う → DBから元の値取得 → 元の値 + 拾った数 → DBに新しい値をセット → 書き込み → 拾う
というのを 1つ拾うごとに行っている ので拾い切るのに時間がかかる上に鯖が一瞬止まる。
負荷的観点や、鯖民でもアイテム大量に拾えば鯖を容易に落とすことも可能ではあるので、修正は必須と思われる。

New Features

• Minecraft 1.19.3 Support (Added new items to default categories.yml)

  • Experimental Items that was added as experimentally are categorized dynamically to Experimental Items category
  • These items is not added to default categories.yml. When Mojang added them as officially, Box will add them to appropriate category
  • We have addressed this because it is not possible to exclude these items from Box, although future updates may make them incompatible

• Box Stick: More containers (furnaces and a brewing stand) support

  • Furnace, BlastFurnace, and Smoker
    • If you don't have items in your main hand, take out the refined items from the furnace
    • If you have items that can be smelted or used as a fuel in your main hand, put them from Box into the furnace
  • Brewing Stand
    • If you don't have items in your main hand, take out the potions from the brewing stand
    • If you have potions or blaze powders in your main hand, put them from Box into the brewing stand

Changes

• Unify the order of tree types in default "wood" category
• Only in the creative mode, the click on the block with the Box Stick is now canceled.

API Changes

• API: Expose MCDataVersion class (#166)
• Auto Store: clarify that PerItemSetting#getEnabledItems is unmodifiable
• Category: New Category API (see: #164)
  • net.okocraft.box.feature.category.model.Category and CategoryHolder are deprecated, and marked as for removal in the next major update.
• Added Javadocs for autostore, category, and stick module

#76 に伴い同じプロジェクトにある必要はないので移動する

現在 AutoStore と Stick で別々に通知機能を備えているが、ストックの増え/減りイベントは共通で発火してるので、それをもとにアクションバーに通知するよう実装する

こいつを Optional<Sound> にして呼び出し元で Optional#orElse でデフォルト値を指定すればいい。 #5 でやる予定。

こういうメッセージのハードコーディングを撲滅する。Optional<T> も同時に解決する。

#5 で解決予定。

コマンドの実装と同じようにする

    public static int parseIntOrDefault(String number, int def) {
        try {
            return Integer.parseInt(number);
        } catch (NumberFormatException exception) {
            return def;
        }
    }

現在では例外を発生させることでデフォ値を返しているが、Spigot には commons-lang が入っているため、 NumberUtils#isNumber(String str) を使って判定したほうが適切

例外が発生したからデフォ値を返す ではなく、 数値ではないからデフォ値を返す の方が良い
(例外を発生させるコストも考えると特に。)

    public static int parseIntOrDefault(String number, int def) {
        if (NumberUtils.isNumber(number)) {
            return Integer.parseInt(number);
        } else {
            return def;
        }
    }

long への変換も同様

注:
NumberUtils#isNumber(str) は commons-lang3 では非推奨、4で廃止予定。
代替として NumberUtils#isCreatable(str) が用意されている。
なお、 spigot は 2.6 なので isCreatable() は存在しない。

Features

New Player Command: /box stocklist

It has the same functionality as /boxadmin stock list, but the players can only see their own stock.

Box Stick: Click on a block to get its item

This is only available in Minecraft 1.19.4 (or later) because used API is added in that version.

Hold the Box Stick and click on the block while sneaking to withdraw the block's items from the Box to the main-hand.

The following list gives concrete specifications:

• Box Stick is in the off-hand and the main-hand is empty
  • The item of the clicked block will be withdrawn from Box to the main-hand
  • Note: This method is already used for depositing/withdrawing items from/to the container, so the item of the container block cannot be deposited
• Box Stick is in the main-hand and the off-hand is empty
  1. Box Stick will be moved to the off-hand
  2. The item of the clicked block will be withdrawn from Box to the main-hand
• Box Stick is in the main-hand and the off-hand is not empty
  1. If the item in the off-hand can not be deposited to Box, nothing to happen
  2. When step 1 is passed, the item in the off-hand will be deposited to Box
  3. Box Stick will be moved to the off-hand
  4. The item of the clicked block will be withdrawn from Box to the main-hand

New Storage Feature

MySQL

MySQL (MariaDB) is now supported as a data storage.

To use MySQL, configure the following in config.yml:

storage:
  type: "mysql"
  mysql:
    table-prefix: "box_" # The prefix of the tables
    address: "localhost" # The host of the database
    port: 3306 # The port to connect to the database
    database-name: "box" # The database name (You need to create the database before starting the server)
    username: "" # The username to connect to the database
    password: "" # The password to connect to the database

Migrator

Added feature to migrate data between different storage types.

For more information, check wiki page (Japanese).

API

• StockHolder#stockDataStream
• InventoryTransaction#depositItemsInInventory(Inventory, Predicate)

Changes

• Use sqlite.table-prefix instead of database.table_prefix in config.yml
  • database.table_prefix is still valid unless sqlite.table-prefix is not present
• Delay player data loading to one second after logging in

Improvements

• Set the initial capacity of the list and reduce the expansion of the list
• Call InventoryClickEvent before depositing/withdrawing items from/to the inventory
• Log picking up items to CoreProtect

Fixes

• Don't set idleTimeout to SQLite connection config
• Some fixes and improvements for language files

DB に記録されていない = お初さん がログインした際、おそらく初期値をセットするのに非常に負荷がかかっている。鯖が数秒間止まる現象も確認されている。
これもこれで大きな問題なので修正が必要です。

• /ba reset <player> -> /ba reset confirm - 在庫をすべて 0 にする
• /ba stockinfo <player> {sort} {page} -> 在庫情報を表示する ({sort} は多い順, 少ない順, A-Z 順をサポート)

とりあえず issue を起こす。

原因？

• 多分 Statement / ResultSet を close していない。こいつらを close しないで放置しておくとメモリリークの原因になるという。

https://www.atmarkit.co.jp/bbs/phpBB/viewtopic.php?topic=43209&forum=12

解決？

• Statement#close, ResultSet#close を叩く。

https://teratail.com/questions/1553
https://qiita.com/opengl-8080/items/a08b0f231f55a44c0151

破壊的変更を入れたので v5.0.0 でアップデートする

https://github.com/Siroshun09/Event4J/releases/tag/3.0.0

New Features

Add support for Folia

Added support for Folia, a multi-threaded server software by PaperMC. Please note that this is experimental and there may still be bugs.

Add goat horns

Removed the goat horn with no metadata (GOAT_HORN) from the default item and added goat horns available in normal survival.

• Old goat horn (GOAT_HORN) will be converted to PONDER_GOAT_HORN automatically (same as the vanilla)
• The new goat horns will be added to mob-drops category in default

API Changes

Deprecate some methods that are not working on Folia

• TaskFactory#run and TaskFactory#supply have been deprecated (but not marked for removal)
  • These methods throw UnsupportedOperationException on Folia
• For entity task, use TaskFactory#runEntityTask and TaskFactory#supplyFromEntity
• Other operations are not provided in this API (as they are not used in this project)

Other

• Add Folia class for checking if the server softwere is Folia
• Add MCDataVersion#of and MCDataVersion#isBetween

Fixes

• Ignore the illegal stack when withdrawing items to the inventory
• Unload player data synchronously on disabling