Giter Club home page Giter Club logo

Comments (10)

adamstruck avatar adamstruck commented on July 24, 2024

I haven't had time to look into this yet, I'll try to get to it early next week.

from funnel.

kmavrommatis avatar kmavrommatis commented on July 24, 2024

Hi,
is there any update on this?
Thanks again for your help

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

Sorry, I've been stuck on other projects. I am working on this now. I hope to have something for you to try out by EOD tomorrow.

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

I've prototyped out a solution in #623. Let me know if this works for you.

For SSE-KMS:

AmazonS3:
SSE:
    KMSKey: "1a03ce70-5f03-484e-8396-0e97de661b79"

For SSE-C:

Generate a key file:

openssl rand -out sse-c.key 32

Then configure funnel to use it:

AmazonS3:
  SSE:
    CustomerKeyFile: "./sse-c.key"

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

Note for SSE-KMS:

As long as your credentials can access the KMS key used for the given bucket, everything seems to work with no special configuration.

from funnel.

kmavrommatis avatar kmavrommatis commented on July 24, 2024

Great thanks, I will give it a try tomorrow.
Regarding the sse-c I assume the file ./sse-c.key is expected to be available to all workers, correct? how about the server? Are there any special permissions required for this file?
Thanks again for your help

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

The server doesn't require any storage configuration in this case. And yes the sse-c.key file is assumed to be accessible by all of the workers.

Upon further testing, I found that in the sse-c case my solution assumes that all files tasks will reference were encrypted using that key. So, for example, if you were to reference a file in an unencrypted bucket the task would fail upon trying to download it.

from funnel.

kmavrommatis avatar kmavrommatis commented on July 24, 2024

Thanks for the clarifications.
I will work with the assumption that all files are encrypted.
Is there any way and are you planning to change this behavior and allow encrypted (with sse-c) or unencrypted files to be used at the same time?
Thanks

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

Yes, I plan to add support for using sse-c encrypted and unencrypted files at the same time.

from funnel.

adamstruck avatar adamstruck commented on July 24, 2024

Yes, I plan to add support for using sse-c encrypted and unencrypted files at the same time.

Done.

from funnel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.