ohmu / poni Goto Github PK

http://melor.github.com/poni/getting-started.html needs to use cat <<'EOF', with the quotes, to avoid $node being expanded to an empty string.

The "poni audit --path-prefix=/tmp", and other audit commands need a -v option to match the output shown in Getting Started.

I hope you'll reconsider using regexps for matching identifiers on the command line. It makes it too easy for admins to shoot themselves in the foot. To prove my point, the docs at http://melor.github.com/poni/template-variables.html use an unanchored $find("webshop/frontend"), which would match e.g. webshop/frontendforsomethingelse.

I'd be much happier if Poni used globs, because they have way fewer magic characters, and those tend to stick out more. I've seen people hurt themselves even with the periods in DNS domain names, when used directly as a regexp pattern. You could always provide a --regex option for when the power is needed.

Poni enforces datatypes on its settings meaning that you can't ever change a setting's datatype. This is problematic with settings that default to null as the only acceptable value in NoneType is None.

Poni should raise warnings or errors when they are used, there's no good reason to allow them.

deploy checks existing files by reading them from the remote server; however, in case of bigger files, this can take forever.

Trivial solution would be to use e.g. md5 hashes of the files instead, as md5sum is available pretty much everywhere - and if not, fall back to reading stuff.

I have a proof of concept patch that does this written already, but it doesn't do fallback as nicely as it could be done.

(We're transferring .tar.gz or two to enable installation of stuff based just on poni resources, and paramiko seems to do only ~10MB/minute for some reason during the check phase.)

Getting Started shows the commands listed writing to /tmp/etc/postgres/8.4/pg_hba.conf but when I copy-paste the commands, they actually write to /tmp/webshop/backend/postgres1/etc/postgres/8.4/pg_hba.conf

On http://melor.github.com/poni/template-variables.html the example for variable "config" is $system.get("parent", "orphan!"). I expected it to use $config.