oheers / evenmorefish Goto Github PK

Hi! i using command with interact event and its fires twice on use
Also did you fixed bug with placing heads?

Think I found a slight bug with the shop.

So when you place a fish in the shop GUI the price doesn't update unless you click on something else, for example placing 1 fish in the shop will still show $0.0 unless you click on a glass plane or place something else in the shop, then the price will update.

Also not sure if this is possible but having the GUI only accept EMF fish would be really nice but I guess isn't a big issue. :)

[EvenMoreFish] Loaded class org.apache.commons.io.FileUtils from AntiAC v2.8-FIX which is not a depend, softdepend or loadbefore of this plugin.

[❌] causes players to be able to join a competition twice

A GUI showing all fish rarities and fish + details of fish. It would be all question marked out for fish that haven't been fished yet by any players

There'd be more information too, I'll leave it up for discussion for what people think should be included in information about fish in a fish gui.

Hello,

When in /rewards GUI you can take diamonds or whatever icon is there to your equipment. Could you please help with that? 🙁 Thank you.

An option for fish to not conform to the prices set by their rarity,

Currently working on getting a fix onto the master branch.

Null checks in the Messages class that prevent null values existing
The default config value will just be returned if it doesn't exist in messages.yml or whatever

A GUI that shows all the rewards obtainable from winning a competition.

If a fish is added into the "Sell Fish" menu via a SHIFT+CLICK after the "SELL" button is click (but before fully confirming) it will not be counted in the total money earned from the sale.

Steps to recreate:

1. Put a fish in the Sell Fish menu
2. Click the "Sell" button once
3. SHIFT+CLICK another fish into the menu
4. Click the confirm button

If there's no value in the messages.yml, don't print this message.

Title explains all really.

we where 2 players. in the competion the 1t one got all fine. the 2n one got not all. and the 3rd one got also something place 3 was a random player that was not even fishing with us just online.. he was not on the list in chat but he got rewardet

• CloudeLecaw

[FISH SPOT SYSTEM] Option(true/false) or Skill (to find them) or Global Characteristic.
Add random fishing spots in the different biomes (to be configured) where the main feature is that they are spots for only one type of fish. If you catch within the area you will get bonuses of:
-Increase the fish caught. (From one cast you can catch 3 fish)
-Improve the quality (Epics and Legendaries are more likely to appear)
-Reduce the waiting time when taking the bait. (More casts = More fish = More money)

Spots can be randomized by the biomes or you can place them in the desired locations.

The visual location of the spots could have a hologram text and some particle animation either around this text or in a radius of blocks (water blocks) to highlight the area where it is shown:
✅ Available. When the Spot is available for use
-The type of Spot (Fishing Cod Spot)
-The number of casts you have left.
❌ Unavailable. When the spot is regenerating
-Indicates that it is a Fishing Spot, but with unknown fish ( Fishing Spot ).
-Indicates the reuse time (10min) -Indicates the last Fishing Spot (Cod)

Similar to AE mobtrak & stattrak, but for fishing rod fish caught.

When the command seems to be a bit more complex nothing happens

What works is a normal small thing like this

  winnings:
    1:
      # Commands are run by the console, it's advised to change these before releasing your server.
      - "COMMAND:gmysteryboxes give {player} 1 5"
      - "COMMAND:cmi kit Votis {player}"
      - "MESSAGE:&aGratulation. Du hast den ersten Platz belegt."
      - "MESSAGE:&eDu erhällst &625 Taler&e, &6einen Voti&e, &5eine Mysterybox der Stufe 5&e und &b3 Diamanten&e."
      # Can't contain decimals.
      - "MONEY:25"
      # formatted as "effect_name,amplifier,duration"
      - "EFFECT:SPEED,2,5"
      - "ITEM:DIAMOND,3"

here both command work

  winnings:
    1:
      # Commands are run by the console, it's advised to change these before releasing your server.
      - "COMMAND:gmysteryboxes give {player} 1 5"
      - "COMMAND:cmi saveditems get Voti -t:{player} -a:1 -s"
      - "MESSAGE:&aGratulation. Du hast den ersten Platz belegt."
      - "MESSAGE:&eDu erhällst &625 Taler&e, &6einen Voti&e, &5eine Mysterybox der Stufe 5&e und &b3 Diamanten&e."
      # Can't contain decimals.
      - "MONEY:25"
      # formatted as "effect_name,amplifier,duration"
      - "EFFECT:SPEED,2,5"
      - "ITEM:DIAMOND,3"

in this case the command cmi saveditems get Voti -t:{player} -a:1 -s is not executed.,,,nothing happens the command is not executed

i tested the command from console, there it works so this mean the syntax seems to be ok

i also took a look into the console. there is no meassage like in the first version of EMF that the command was not loaded.

Part of a "rewards" problem. Affecting other rewards being given too.

"well i try to retell what happend in the 1.1.3 (the old) We has some schedules competitions while these some players where fishing and getting there 1,2,3erd place. after some rounds i started a admin competition for just two players so normaly there should be just place 1 and 2. the Result was the first was getting rewarded normaly the secounds got nothing and the the console chooses a 3rd one that was not even online anymore (from the schedules competitions before) and rewarded him twice. we tried it 2 more times. in all cases the player that was not online anymore got rewarded and me (that was the 2dn place all time) got only the rewards from "notcommands"
so to test this u might need minimum of 3 players
3 in first stage 2 after"

• CloudeLecaw

Placeholders for:

current competition winners, (1st,2nd,3rd,ect)
total competition winners (most wins, biggest fish, ect)
time until next competition
placeholders for every rarfity

All the guis to be put into something like guis.yml rather than clogging up the main config.yml

(I believe NPEs occur) leading to locale files not being generated

Adding a command for selling all EMF fish in /emf shop
Maybe an item in the GUI that allows to sell all fish.

[BOOST SYSTEM] (permission/ ability/ schedule/ activable item,)
Improved fish catching system, activated the player will receive:

◆ x2 experience
◆ x2 sales bonus
◆ fishing rod does not break
◆ +casting/catching speed
◆ +% of catching rarer fish
◆ +% of catching several fish with each cast
◆ +% of getting special items hooked on the hook (diamonds, emeralds, golden apples)

All these upgrades can be future player skills (either unlockable for money) or upgrades for the fishing rod.

Fishing being caught doesn't seem to work with hex colours very well.
https://gyazo.com/229285ccb812f4286d27468a7eb85c9f

Hi!
I am using latest version and Interact-event not fires at all, eat-event fires twice

A issue with the newest version of the plugin seems to have broken the leaderboard. When a competition ends, people get the rewards, but the leaderboard doesn't appear in chat.

Error command in console:

[13:17:18 WARN]: [EvenMoreFish] Task #412289 for EvenMoreFish v1.2.0 generated an exception
java.lang.NullPointerException: null
at java.util.Objects.requireNonNull(Objects.java:221) ~[?:?]
at com.oheers.fish.competition.reward.Reward.run(Reward.java:63) ~[?:?]
at com.oheers.fish.competition.Competition.giveRewards(Competition.java:159) ~[?:?]
at com.oheers.fish.competition.Competition.getLeaderboard(Competition.java:106) ~[?:?]
at com.oheers.fish.competition.Competition.announceWinners(Competition.java:95) ~[?:?]
at com.oheers.fish.competition.Competition.end(Competition.java:53) ~[?:?]
at com.oheers.fish.competition.Ticker.run(Ticker.java:19) ~[?:?]
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.16.5.jar:git-Paper-605]
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468) ~[patched_1.16.5.jar:git-Paper-605]
at net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1423) ~[patched_1.16.5.jar:git-Paper-605]
at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:418) ~[patched_1.16.5.jar:git-Paper-605]
at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1338) ~[patched_1.16.5.jar:git-Paper-605]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1126) ~[patched_1.16.5.jar:git-Paper-605]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:289) ~[patched_1.16.5.jar:git-Paper-605]
at java.lang.Thread.run(Thread.java:834) [?:?]

    Krabbe:
      item:
        material: COD
      size:
        minSize: 10
        maxSize: 100
      eat-event:
        - "ITEM:GOLD_INGOT,1"
        - "MESSAGE:&eDu hast einen Goldbarren erhalten!"
        - "COMMAND:cmi kit Votis {player}"

When you eat it you get

[23:41:03] [Craft Scheduler Thread - 12/WARN]: [EvenMoreFish] Plugin EvenMoreFish v1.1.2.1 generated an exception while executing task 7386
java.lang.IllegalStateException: Asynchronous command dispatch!
	at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:15) ~[patched_1.16.5.jar:git-Paper-592]
	at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchCommand(CraftServer.java:785) ~[patched_1.16.5.jar:git-Paper-592]
	at org.bukkit.Bukkit.dispatchCommand(Bukkit.java:776) ~[patched_1.16.5.jar:git-Paper-592]
	at com.oheers.fish.competition.reward.Reward.run(Reward.java:53) ~[?:?]
	at com.oheers.fish.events.FishEatEvent$1.run(FishEatEvent.java:32) ~[?:?]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.16.5.jar:git-Paper-592]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.16.5.jar:git-Paper-592]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.16.5.jar:git-Paper-592]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[?:?]
	at java.lang.Thread.run(Thread.java:831) [?:?]

latest EMF Version 1.1.2.1 from Spigot

Fishing rods aren't losing their durability when fishing custom fish.

There's a possibility to add a feature for certain fish to do more damage than others to rods, depending on how this can be implemented

There are two errors
I installed more-fish plugin and Vault plugin
The server version is 1.16.5
Using java 8

1. [08:31:41] [Server thread/ERROR]: EvenMoreFish couldn't hook into Vault economy. Disabling to prevent serious problems.
2. [08:31:32] [Server thread/ERROR]: Error occurred while disabling EvenMoreFish v1.1.1 (Is it up to date?)
   java.lang.NullPointerException: null
   at com.oheers.fish.EvenMoreFish.terminateSellGUIS(EvenMoreFish.java:172) ~[?:?]
   at com.oheers.fish.EvenMoreFish.onDisable(EvenMoreFish.java:132) ~[?:?]
   at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:376) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:501) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:493) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.plugin.SimplePluginManager.clearPlugins(SimplePluginManager.java:544) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.craftbukkit.v1_16_R3.CraftServer.reload(CraftServer.java:847) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.Bukkit.reload(Bukkit.java:651) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.command.defaults.ReloadCommand.execute(ReloadCommand.java:27) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchCommand(CraftServer.java:763) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchServerCommand(CraftServer.java:748) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at net.minecraft.server.v1_16_R3.DedicatedServer.handleCommandQueue(DedicatedServer.java:387) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:356) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1008) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:847) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$0(MinecraftServer.java:164) ~[spigot-1.16.5.jar:2991-Spigot-018b9a0-f3f3094]
   at java.lang.Thread.run(Unknown Source) [?:1.8.0_271]

One of the fish.yml mentions there being an issue with "EFFECT:HARM" - "HEALTH:-1" now exists so I might as well show that in the config.

Option for fish to be the head of the player that fished it.

A list of worlds that fish are limited to

In NBT, lore etc.

`[08:37:02] [Thread-1337/WARN]: java.sql.SQLException: The prepared statement has been finalized
[08:37:02] [Thread-1337/WARN]: at org.sqlite.core.NativeDB.throwex(NativeDB.java:487)
[08:37:02] [Thread-1337/WARN]: at org.sqlite.core.NativeDB.column_count(Native Method)
[08:37:02] [Thread-1337/WARN]: at org.sqlite.core.DB.column_names(DB.java:731)
[08:37:02] [Thread-1337/WARN]: at org.sqlite.jdbc3.JDBC3Statement.getResultSet(JDBC3Statement.java:131)
[08:37:02] [Thread-1337/WARN]: at org.sqlite.jdbc3.JDBC3PreparedStatement.executeQuery(JDBC3PreparedStatement.java:82)
[08:37:02] [Thread-1337/WARN]: at com.oheers.fish.database.Database.hasFish(Database.java:76)
[08:37:02] [Thread-1337/WARN]: at com.oheers.fish.fishing.FishEvent.run(FishEvent.java:211)
[08:37:02] [Thread-1337/WARN]: at java.lang.Thread.run(Unknown Source)

[08:37:57] [Thread-1359/WARN]: java.sql.SQLException: The database has been closed
[08:37:57] [Thread-1359/WARN]: at org.sqlite.core.NativeDB.throwex(NativeDB.java:487)
[08:37:57] [Thread-1359/WARN]: at org.sqlite.core.NativeDB.column_text_utf8(Native Method)
[08:37:57] [Thread-1359/WARN]: at org.sqlite.core.NativeDB.column_text(NativeDB.java:249)
[08:37:57] [Thread-1359/WARN]: at org.sqlite.jdbc3.JDBC3ResultSet.getString(JDBC3ResultSet.java:437)
[08:37:57] [Thread-1359/WARN]: at com.oheers.fish.database.Database.hasFish(Database.java:81)
[08:37:57] [Thread-1359/WARN]: at com.oheers.fish.fishing.FishEvent.run(FishEvent.java:211)
[08:37:57] [Thread-1359/WARN]: at java.lang.Thread.run(Unknown Source)`

As the title says.

Fish to only ocurr before/after times of day, would be something like

spawn-after:4000

it would only spawn if that time tick thingy is above 4000

CommandSender is cast as (Player) when it could potentially be a console sending the message.

Option to drop vanilla loot alongside custom fish

Eating a fish with a potion effect as an eat-event doesn't work.

My fish:

    Levi-Fish:
      item:
        material: TROPICAL_FISH
      biomes:
        - THE_END
        - END_BARRENS
        - END_HIGHLANDS
        - END_MIDLANDS
        - THE_VOID
      eat-event:
        - "EFFECT:LEVITATION,1,5"

Console log:

[18:24:34 INFO]: <LeeSpork> Eating a levi-fish
[18:24:39 WARN]: [EvenMoreFish] Plugin EvenMoreFish v1.3.3 generated an exception while executing task 230
java.lang.IllegalStateException: Asynchronous effect add!
	at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:14) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at net.minecraft.world.entity.EntityLiving.addEffect(EntityLiving.java:1084) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at net.minecraft.world.entity.EntityLiving.addEffect(EntityLiving.java:1076) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at org.bukkit.craftbukkit.v1_17_R1.entity.CraftLivingEntity.addPotionEffect(CraftLivingEntity.java:363) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at org.bukkit.craftbukkit.v1_17_R1.entity.CraftLivingEntity.addPotionEffect(CraftLivingEntity.java:358) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at com.oheers.fish.competition.reward.Reward.run(Reward.java:63) ~[?:?]
	at com.oheers.fish.events.FishEatEvent$1.run(FishEatEvent.java:36) ~[?:?]
	at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:82) ~[spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) [spigot-1.17.1.jar:3219-Spigot-b166a49-8c6d60c]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) [?:?]
	at java.lang.Thread.run(Thread.java:831) [?:?]
[18:24:40 INFO]: <LeeSpork> nothing happened

To be formatted like &#ffddee unless an api can be found that does it a different way

Seen since Version 1.1.3

part of config.yml

competitions:


  # When should competitions run?
  # It will use server's local timezone using a 24hour time format
  times:
    - "12:00" # midday

i had added 12:12 because i wanne test the competitions scheduler
5 player are needed in config, im alone so i should get a meassage it does not start.

• To reproduce simply set minimum-players to 2 or more (when your alone) set a time that might be in 2-3 minutes from actual time and reload the plugin by its command /emf admin reload. Now wait for the time to come.

Result - you will see the competitions has not started meassage twice

• now change to time to 2-3 minutes alter and reload aggain and wait aggain

Result - you will see the competitions has not started meassage tree times

and so on...

It's meant to copy the default time for competitions to start when admins don't start with a duration, but it's only using seconds, not doing a *60 like it should be.