Example:

<?php

function doSomething(?string $param): string {
    // ...
}

The ternary-max-length rule will fail because the function line has a ? followed by a :.

Issue

Starting a new project with blank rules as below

{
  "pathes": [
    "src/"
  ],
  "rules": {}
}

I think the expected output is that the test will pass. As there is no configuration here that it should extend or include a base config file.

Removing a rule that is now in the default would mean having to set that rule manually to "false". This might be possible but it will cause issues if we add rules in the future, as package users would require to keep up with new rules at every upgrade in orde to disable them.

tokens.current()for file-max-size is { body: '', type: 9 } here:

making at line ${token.line} column ${token.column} result in at line undefined column undefined.

Maybe just remove the line/column comment in case of file-max-size as it doesn't have a specific ln/col?

• this makes diffs easier to review
• use alphabetic order?

• Chose license
• Create github organization
• Open repo
• Travis CI (+ badge ?)
• Public version number (1.0.0 ?)
• Code of conduct

eg --help could explain how to save a new baseline,..

for file-max-size, we can do this:

    "file-max-size": {
      "max-lines": 200,
      "include-comments": false,
      "include-empty-lines": false
    },

if we do this for function-max-size this doesn't work.
Would it be possible to add this functionality as well? (to avoid including comments/empty lines)

Thanks! :)

this is seen as 24 (as it takes the first 4 spaces into account)

    $abc = $def ? 1 : 0;

'exclude_paths' should overrule 'paths'
e.g.

{
  "baseline": ".readable-baseline.json",
  "paths": [
    "server/"
  ],
  "exclude_paths": [
    "server/dir_to_be_excluded/"
  ]
}

Currently, when there's a function with multiple (long) parameters, we write them all on 1 line, because otherwise it would count for the file-max-size-limit we have. Example:

    public function testFunction($one, $two, $three, $four, $five, $six, $seven, $eight, $nine, $ten)
    {
    }

As you can see, this counts as 3 lines.
What we would like to have is this:

    public function testFunction(
        $one,
        $two,
        $three,
        $four,
        $five,
        $six,
        $seven,
        $eight,
        $nine,
        $ten
    ) {
    }

And still have it count as 3 lines instead of 13

Would that be possible to have an option to handle this?

Thanks!

$a = '';

// some comment
$b = '';

It would be better if this was seen as 2 lines instead of 4

Before

server/controllers/dashboard/employeeCount.php
  Class have no comment above.
    at line 4 column 5

Proposal

server/controllers/dashboard/employeeCount.php:4:5
  Class have no comment above.

This will allow VSCode to pick it up and open the file directly on the right position.

Pros:

1. It will be shorter than current @officient/readable
2. It will be easier to google it. Note, when searching for psalm, you anyway need to google for psalm php.

Cons:

1. Probably will need to create new package, when we add new language to readable (readable-js).